mirror of
https://github.com/torvalds/linux.git
synced 2024-11-28 23:21:31 +00:00
2516cb8822
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No return values were used, so direct replacement is safe. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy [2] https://github.com/KSPP/linux/issues/89 Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com> Link: https://lore.kernel.org/r/20230530164131.987213-1-azeemshaikh38@gmail.com Reviewed-by: Kees Cook <keescook@chromium.org> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
71 lines
1.8 KiB
C
71 lines
1.8 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
|
|
#include <linux/kconfig.h>
|
|
#include <linux/types.h>
|
|
#include <linux/fault-inject.h>
|
|
#include <linux/module.h>
|
|
#include "ufs-fault-injection.h"
|
|
|
|
static int ufs_fault_get(char *buffer, const struct kernel_param *kp);
|
|
static int ufs_fault_set(const char *val, const struct kernel_param *kp);
|
|
|
|
static const struct kernel_param_ops ufs_fault_ops = {
|
|
.get = ufs_fault_get,
|
|
.set = ufs_fault_set,
|
|
};
|
|
|
|
enum { FAULT_INJ_STR_SIZE = 80 };
|
|
|
|
/*
|
|
* For more details about fault injection, please refer to
|
|
* Documentation/fault-injection/fault-injection.rst.
|
|
*/
|
|
static char g_trigger_eh_str[FAULT_INJ_STR_SIZE];
|
|
module_param_cb(trigger_eh, &ufs_fault_ops, g_trigger_eh_str, 0644);
|
|
MODULE_PARM_DESC(trigger_eh,
|
|
"Fault injection. trigger_eh=<interval>,<probability>,<space>,<times>");
|
|
static DECLARE_FAULT_ATTR(ufs_trigger_eh_attr);
|
|
|
|
static char g_timeout_str[FAULT_INJ_STR_SIZE];
|
|
module_param_cb(timeout, &ufs_fault_ops, g_timeout_str, 0644);
|
|
MODULE_PARM_DESC(timeout,
|
|
"Fault injection. timeout=<interval>,<probability>,<space>,<times>");
|
|
static DECLARE_FAULT_ATTR(ufs_timeout_attr);
|
|
|
|
static int ufs_fault_get(char *buffer, const struct kernel_param *kp)
|
|
{
|
|
const char *fault_str = kp->arg;
|
|
|
|
return sysfs_emit(buffer, "%s\n", fault_str);
|
|
}
|
|
|
|
static int ufs_fault_set(const char *val, const struct kernel_param *kp)
|
|
{
|
|
struct fault_attr *attr = NULL;
|
|
|
|
if (kp->arg == g_trigger_eh_str)
|
|
attr = &ufs_trigger_eh_attr;
|
|
else if (kp->arg == g_timeout_str)
|
|
attr = &ufs_timeout_attr;
|
|
|
|
if (WARN_ON_ONCE(!attr))
|
|
return -EINVAL;
|
|
|
|
if (!setup_fault_attr(attr, (char *)val))
|
|
return -EINVAL;
|
|
|
|
strscpy(kp->arg, val, FAULT_INJ_STR_SIZE);
|
|
|
|
return 0;
|
|
}
|
|
|
|
bool ufs_trigger_eh(void)
|
|
{
|
|
return should_fail(&ufs_trigger_eh_attr, 1);
|
|
}
|
|
|
|
bool ufs_fail_completion(void)
|
|
{
|
|
return should_fail(&ufs_timeout_attr, 1);
|
|
}
|