mirror of
https://github.com/torvalds/linux.git
synced 2024-12-03 09:31:26 +00:00
a433658c30
Currently, memcg reclaim can disable swap token even if the swap token mm doesn't belong in its memory cgroup. It's slightly risky. If an admin creates very small mem-cgroup and silly guy runs contentious heavy memory pressure workload, every tasks are going to lose swap token and then system may become unresponsive. That's bad. This patch adds 'memcg' parameter into disable_swap_token(). and if the parameter doesn't match swap token, VM doesn't disable it. [akpm@linux-foundation.org: coding-style fixes] Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Reviewed-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> Reviewed-by: Rik van Riel<riel@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
127 lines
2.8 KiB
C
127 lines
2.8 KiB
C
/*
|
|
* mm/thrash.c
|
|
*
|
|
* Copyright (C) 2004, Red Hat, Inc.
|
|
* Copyright (C) 2004, Rik van Riel <riel@redhat.com>
|
|
* Released under the GPL, see the file COPYING for details.
|
|
*
|
|
* Simple token based thrashing protection, using the algorithm
|
|
* described in: http://www.cs.wm.edu/~sjiang/token.pdf
|
|
*
|
|
* Sep 2006, Ashwin Chaugule <ashwin.chaugule@celunite.com>
|
|
* Improved algorithm to pass token:
|
|
* Each task has a priority which is incremented if it contended
|
|
* for the token in an interval less than its previous attempt.
|
|
* If the token is acquired, that task's priority is boosted to prevent
|
|
* the token from bouncing around too often and to let the task make
|
|
* some progress in its execution.
|
|
*/
|
|
|
|
#include <linux/jiffies.h>
|
|
#include <linux/mm.h>
|
|
#include <linux/sched.h>
|
|
#include <linux/swap.h>
|
|
#include <linux/memcontrol.h>
|
|
|
|
static DEFINE_SPINLOCK(swap_token_lock);
|
|
struct mm_struct *swap_token_mm;
|
|
struct mem_cgroup *swap_token_memcg;
|
|
static unsigned int global_faults;
|
|
|
|
#ifdef CONFIG_CGROUP_MEM_RES_CTLR
|
|
static struct mem_cgroup *swap_token_memcg_from_mm(struct mm_struct *mm)
|
|
{
|
|
struct mem_cgroup *memcg;
|
|
|
|
memcg = try_get_mem_cgroup_from_mm(mm);
|
|
if (memcg)
|
|
css_put(mem_cgroup_css(memcg));
|
|
|
|
return memcg;
|
|
}
|
|
#else
|
|
static struct mem_cgroup *swap_token_memcg_from_mm(struct mm_struct *mm)
|
|
{
|
|
return NULL;
|
|
}
|
|
#endif
|
|
|
|
void grab_swap_token(struct mm_struct *mm)
|
|
{
|
|
int current_interval;
|
|
|
|
global_faults++;
|
|
|
|
current_interval = global_faults - mm->faultstamp;
|
|
|
|
if (!spin_trylock(&swap_token_lock))
|
|
return;
|
|
|
|
/* First come first served */
|
|
if (!swap_token_mm)
|
|
goto replace_token;
|
|
|
|
if (mm == swap_token_mm) {
|
|
mm->token_priority += 2;
|
|
goto out;
|
|
}
|
|
|
|
if (current_interval < mm->last_interval)
|
|
mm->token_priority++;
|
|
else {
|
|
if (likely(mm->token_priority > 0))
|
|
mm->token_priority--;
|
|
}
|
|
|
|
/* Check if we deserve the token */
|
|
if (mm->token_priority > swap_token_mm->token_priority)
|
|
goto replace_token;
|
|
|
|
out:
|
|
mm->faultstamp = global_faults;
|
|
mm->last_interval = current_interval;
|
|
spin_unlock(&swap_token_lock);
|
|
return;
|
|
|
|
replace_token:
|
|
mm->token_priority += 2;
|
|
swap_token_mm = mm;
|
|
swap_token_memcg = swap_token_memcg_from_mm(mm);
|
|
goto out;
|
|
}
|
|
|
|
/* Called on process exit. */
|
|
void __put_swap_token(struct mm_struct *mm)
|
|
{
|
|
spin_lock(&swap_token_lock);
|
|
if (likely(mm == swap_token_mm)) {
|
|
swap_token_mm = NULL;
|
|
swap_token_memcg = NULL;
|
|
}
|
|
spin_unlock(&swap_token_lock);
|
|
}
|
|
|
|
static bool match_memcg(struct mem_cgroup *a, struct mem_cgroup *b)
|
|
{
|
|
if (!a)
|
|
return true;
|
|
if (!b)
|
|
return true;
|
|
if (a == b)
|
|
return true;
|
|
return false;
|
|
}
|
|
|
|
void disable_swap_token(struct mem_cgroup *memcg)
|
|
{
|
|
/* memcg reclaim don't disable unrelated mm token. */
|
|
if (match_memcg(memcg, swap_token_memcg)) {
|
|
spin_lock(&swap_token_lock);
|
|
if (match_memcg(memcg, swap_token_memcg)) {
|
|
swap_token_mm = NULL;
|
|
swap_token_memcg = NULL;
|
|
}
|
|
spin_unlock(&swap_token_lock);
|
|
}
|
|
}
|