Filipe Manana 162d053e15 btrfs: do not BUG_ON() on ENOMEM when dropping extent items for a range ... If we get -ENOMEM while dropping file extent items in a given range, at btrfs_drop_extents(), due to failure to allocate memory when attempting to increment the reference count for an extent or drop the reference count, we handle it with a BUG_ON(). This is excessive, instead we can simply abort the transaction and return the error to the caller. In fact most callers of btrfs_drop_extents(), directly or indirectly, already abort the transaction if btrfs_drop_extents() returns any error. Also, we already have error paths at btrfs_drop_extents() that may return -ENOMEM and in those cases we abort the transaction, like for example anything that changes the b+tree may return -ENOMEM due to a failure to allocate a new extent buffer when COWing an existing extent buffer, such as a call to btrfs_duplicate_item() for example. So replace the BUG_ON() calls with proper logic to abort the transaction and return the error. Reported-by: syzbot+0b1fb6b0108c27419f9f@syzkaller.appspotmail.com Link: https://lore.kernel.org/linux-btrfs/00000000000089773e05ee4b9cb4@google.com/ CC: stable@vger.kernel.org # 5.4+ Reviewed-by: Josef Bacik <josef@toxicpanda.com> Signed-off-by: Filipe Manana <fdmanana@suse.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>		2022-12-05 18:00:59 +01:00
..
tests	btrfs: drop private_data parameter from extent_io_tree_init	2022-12-05 18:00:54 +01:00
accessors.c	btrfs: add eb to btrfs_node_key_ptr_offset	2022-12-05 18:00:58 +01:00
accessors.h	btrfs: add stack helpers for a few btrfs items	2022-12-05 18:00:58 +01:00
acl.c	btrfs: move acl prototypes into acl.h	2022-12-05 18:00:46 +01:00
acl.h	btrfs: move acl prototypes into acl.h	2022-12-05 18:00:46 +01:00
async-thread.c	btrfs: simplify WQ_HIGHPRI handling in struct btrfs_workqueue	2022-05-16 17:03:15 +02:00
async-thread.h	btrfs: remove unused typedefs get_extent_t and btrfs_work_func_t	2022-07-25 17:45:36 +02:00
backref.c	btrfs: move struct btrfs_tree_parent_check out of disk-io.h	2022-12-05 18:00:57 +01:00
backref.h	btrfs: send: skip resolution of our own backref when finding clone source	2022-12-05 18:00:50 +01:00
bio.c	btrfs: move repair_io_failure to bio.c	2022-12-05 18:00:57 +01:00
bio.h	btrfs: split the bio submission path into a separate file	2022-12-05 18:00:57 +01:00
block-group.c	btrfs: convert btrfs_block_group::needs_free_space to runtime flag	2022-12-05 18:00:51 +01:00
block-group.h	btrfs: convert btrfs_block_group::seq_zone to runtime flag	2022-12-05 18:00:51 +01:00
block-rsv.c	btrfs: simplify percent calculation helpers, rename div_factor	2022-12-05 18:00:48 +01:00
block-rsv.h	btrfs: simplify percent calculation helpers, rename div_factor	2022-12-05 18:00:48 +01:00
btrfs_inode.h	btrfs: pass btrfs_inode to btrfs_add_delayed_iput	2022-12-05 18:00:55 +01:00
check-integrity.c	btrfs: use btrfs_dev_name() helper to handle missing devices better	2022-12-05 18:00:57 +01:00
check-integrity.h	btrfs: check-integrity: split submit_bio from btrfsic checking	2022-05-16 17:03:12 +02:00
compression.c	btrfs: split the bio submission path into a separate file	2022-12-05 18:00:57 +01:00
compression.h	btrfs: constify input buffer parameter in compression code	2022-12-05 18:00:55 +01:00
ctree.c	btrfs: add might_sleep() annotations	2022-12-05 18:00:59 +01:00
ctree.h	btrfs: move the csum helpers into ctree.h	2022-12-05 18:00:58 +01:00
defrag.c	btrfs: pass btrfs_inode to btrfs_inode_unlock	2022-12-05 18:00:53 +01:00
defrag.h	btrfs: move defrag related prototypes to their own header	2022-12-05 18:00:46 +01:00
delalloc-space.c	btrfs: update function comments	2022-12-05 18:00:45 +01:00
delalloc-space.h	btrfs: move delalloc space related prototypes to delalloc-space.h	2022-12-05 18:00:44 +01:00
delayed-inode.c	btrfs: pass btrfs_inode to btrfs_inode_unlock	2022-12-05 18:00:53 +01:00
delayed-inode.h	btrfs: extend btrfs_dir_item type to store encryption status	2022-12-05 18:00:43 +01:00
delayed-ref.c	btrfs: update function comments	2022-12-05 18:00:45 +01:00
delayed-ref.h	btrfs: remove btrfs_delayed_extent_op::is_data	2022-05-16 17:17:31 +02:00
dev-replace.c	btrfs: use btrfs_dev_name() helper to handle missing devices better	2022-12-05 18:00:57 +01:00
dev-replace.h	btrfs: move dev-replace prototypes into dev-replace.h	2022-12-05 18:00:47 +01:00
dir-item.c	btrfs: move dir-item prototypes into dir-item.h	2022-12-05 18:00:46 +01:00
dir-item.h	btrfs: move dir-item prototypes into dir-item.h	2022-12-05 18:00:46 +01:00
discard.c	btrfs: update function comments	2022-12-05 18:00:45 +01:00
discard.h
disk-io.c	btrfs: move repair_io_failure to bio.c	2022-12-05 18:00:57 +01:00
disk-io.h	btrfs: move struct btrfs_tree_parent_check out of disk-io.h	2022-12-05 18:00:57 +01:00
export.c	btrfs: move super_block specific helpers into super.h	2022-12-05 18:00:47 +01:00
export.h	btrfs: simplify generation check in btrfs_get_dentry	2022-12-05 18:00:41 +01:00
extent_io.c	btrfs: remove BTRFS_LEAF_DATA_OFFSET	2022-12-05 18:00:58 +01:00
extent_io.h	btrfs: move eb offset helpers into extent_io.h	2022-12-05 18:00:58 +01:00
extent_map.c	btrfs: remove no longer used btrfs_next_extent_map()	2022-12-05 18:00:56 +01:00
extent_map.h	btrfs: remove no longer used btrfs_next_extent_map()	2022-12-05 18:00:56 +01:00
extent-io-tree.c	btrfs: fix uninitialized variable in find_first_clear_extent_bit	2022-12-05 18:00:59 +01:00
extent-io-tree.h	btrfs: allow passing a cached state record to count_range_bits()	2022-12-05 18:00:56 +01:00
extent-tree.c	btrfs: split the bio submission path into a separate file	2022-12-05 18:00:57 +01:00
extent-tree.h	btrfs: move the snapshot drop related prototypes to extent-tree.h	2022-12-05 18:00:46 +01:00
file-item.c	btrfs: split the bio submission path into a separate file	2022-12-05 18:00:57 +01:00
file-item.h	btrfs: move file_extent_item helpers into file-item.h	2022-12-05 18:00:58 +01:00
file.c	btrfs: do not BUG_ON() on ENOMEM when dropping extent items for a range	2022-12-05 18:00:59 +01:00
file.h	btrfs: use cached state when looking for delalloc ranges with fiemap	2022-12-05 18:00:56 +01:00
free-space-cache.c	btrfs: pass btrfs_inode to btrfs_add_delayed_iput	2022-12-05 18:00:55 +01:00
free-space-cache.h	btrfs: convert discard stat defs to enum	2022-12-05 18:00:45 +01:00
free-space-tree.c	btrfs: convert btrfs_block_group::needs_free_space to runtime flag	2022-12-05 18:00:51 +01:00
free-space-tree.h
fs.c	btrfs: move accessor helpers into accessors.h	2022-12-05 18:00:42 +01:00
fs.h	btrfs: remove the unused endio_raid56_workers and btrfs_raid_bio::end_io_work	2022-12-05 18:00:49 +01:00
inode-item.c	btrfs: move file-item prototypes into their own header	2022-12-05 18:00:46 +01:00
inode-item.h	btrfs: use struct fscrypt_str instead of struct qstr	2022-12-05 18:00:43 +01:00
inode.c	btrfs: split the bio submission path into a separate file	2022-12-05 18:00:57 +01:00
ioctl.c	btrfs: replace strncpy() with strscpy()	2022-12-05 18:00:59 +01:00
ioctl.h	btrfs: move ioctl prototypes into ioctl.h	2022-12-05 18:00:46 +01:00
Kconfig	btrfs: use generic Kconfig option for 256kB page size limit	2022-01-20 08:52:55 +02:00
locking.c	btrfs: move accessor helpers into accessors.h	2022-12-05 18:00:42 +01:00
locking.h	btrfs: move the lockdep helpers into locking.h	2022-12-05 18:00:44 +01:00
lzo.c	btrfs: constify input buffer parameter in compression code	2022-12-05 18:00:55 +01:00
Makefile	btrfs: split the bio submission path into a separate file	2022-12-05 18:00:57 +01:00
messages.c	btrfs: move super_block specific helpers into super.h	2022-12-05 18:00:47 +01:00
messages.h	btrfs: move the 32bit warn defines into messages.h	2022-12-05 18:00:46 +01:00
misc.h	btrfs: simplify percent calculation helpers, rename div_factor	2022-12-05 18:00:48 +01:00
ordered-data.c	btrfs: pass btrfs_inode to btrfs_add_delayed_iput	2022-12-05 18:00:55 +01:00
ordered-data.h	btrfs: use cached_state for btrfs_check_nocow_lock	2022-12-05 18:00:36 +01:00
orphan.c	btrfs: move orphan prototypes into orphan.h	2022-12-05 18:00:47 +01:00
orphan.h	btrfs: move orphan prototypes into orphan.h	2022-12-05 18:00:47 +01:00
print-tree.c	btrfs: move struct btrfs_tree_parent_check out of disk-io.h	2022-12-05 18:00:57 +01:00
print-tree.h
props.c	btrfs: move super_block specific helpers into super.h	2022-12-05 18:00:47 +01:00
props.h	btrfs: make module init/exit match their sequence	2022-12-05 18:00:40 +01:00
qgroup.c	btrfs: move struct btrfs_tree_parent_check out of disk-io.h	2022-12-05 18:00:57 +01:00
qgroup.h	btrfs: sink gfp_t parameter to btrfs_qgroup_trace_extent	2022-12-05 18:00:43 +01:00
raid56.c	btrfs: raid56: do data csum verification during RMW cycle	2022-12-05 18:00:57 +01:00
raid56.h	btrfs: raid56: prepare data checksums for later RMW verification	2022-12-05 18:00:57 +01:00
rcu-string.h	btrfs: replace strncpy() with strscpy()	2022-12-05 18:00:59 +01:00
ref-verify.c	btrfs: move accessor helpers into accessors.h	2022-12-05 18:00:42 +01:00
ref-verify.h
reflink.c	btrfs: pass btrfs_inode to btrfs_inode_unlock	2022-12-05 18:00:53 +01:00
reflink.h
relocation.c	btrfs: split the bio submission path into a separate file	2022-12-05 18:00:57 +01:00
relocation.h	btrfs: move relocation prototypes into relocation.h	2022-12-05 18:00:47 +01:00
root-tree.c	btrfs: move orphan prototypes into orphan.h	2022-12-05 18:00:47 +01:00
root-tree.h	btrfs: move root tree prototypes to their own header	2022-12-05 18:00:44 +01:00
scrub.c	btrfs: introduce a bitmap based csum range search function	2022-12-05 18:00:57 +01:00
scrub.h	btrfs: move scrub prototypes into scrub.h	2022-12-05 18:00:47 +01:00
send.c	btrfs: send: bump the extent reference count limit for backref walking	2022-12-05 18:00:51 +01:00
send.h	btrfs: send add define for v2 buffer size	2022-12-05 18:00:41 +01:00
space-info.c	btrfs: simplify percent calculation helpers, rename div_factor	2022-12-05 18:00:48 +01:00
space-info.h	btrfs: move btrfs_account_ro_block_groups_free_space into space-info.c	2022-12-05 18:00:44 +01:00
subpage.c	btrfs: move the printk helpers out of ctree.h	2022-12-05 18:00:41 +01:00
subpage.h	btrfs: make nodesize >= PAGE_SIZE case to reuse the non-subpage routine	2022-05-16 17:03:11 +02:00
super.c	btrfs: split the bio submission path into a separate file	2022-12-05 18:00:57 +01:00
super.h	btrfs: move super_block specific helpers into super.h	2022-12-05 18:00:47 +01:00
sysfs.c	btrfs: simplify percent calculation helpers, rename div_factor	2022-12-05 18:00:48 +01:00
sysfs.h
transaction.c	btrfs: drop private_data parameter from extent_io_tree_init	2022-12-05 18:00:54 +01:00
transaction.h	btrfs: remove fs_info::pending_changes and related code	2022-12-05 18:00:42 +01:00
tree-checker.c	btrfs: pass the extent buffer for the btrfs_item_nr helpers	2022-12-05 18:00:58 +01:00
tree-checker.h	btrfs: move struct btrfs_tree_parent_check out of disk-io.h	2022-12-05 18:00:57 +01:00
tree-log.c	btrfs: remove outdated logic from overwrite_item() and add assertion	2022-12-05 18:00:59 +01:00
tree-log.h	btrfs: use struct fscrypt_str instead of struct qstr	2022-12-05 18:00:43 +01:00
tree-mod-log.c	btrfs: add eb to btrfs_node_key_ptr_offset	2022-12-05 18:00:58 +01:00
tree-mod-log.h	btrfs: fix SPDX comment in tree-mod-log.h	2022-12-05 18:00:48 +01:00
ulist.c	btrfs: constify ulist parameter of ulist_next()	2022-12-05 18:00:50 +01:00
ulist.h	btrfs: constify ulist parameter of ulist_next()	2022-12-05 18:00:50 +01:00
uuid-tree.c	btrfs: move uuid tree prototypes to uuid-tree.h	2022-12-05 18:00:46 +01:00
uuid-tree.h	btrfs: move uuid tree prototypes to uuid-tree.h	2022-12-05 18:00:46 +01:00
verity.c	btrfs: move orphan prototypes into orphan.h	2022-12-05 18:00:47 +01:00
verity.h	btrfs: move verity prototypes into verity.h	2022-12-05 18:00:47 +01:00
volumes.c	btrfs: fix extent map use-after-free when handling missing device in read_one_chunk	2022-12-05 18:00:59 +01:00
volumes.h	btrfs: split the bio submission path into a separate file	2022-12-05 18:00:57 +01:00
xattr.c	btrfs: move dir-item prototypes into dir-item.h	2022-12-05 18:00:46 +01:00
xattr.h
zlib.c	btrfs: constify input buffer parameter in compression code	2022-12-05 18:00:55 +01:00
zoned.c	btrfs: convert btrfs_block_group::seq_zone to runtime flag	2022-12-05 18:00:51 +01:00
zoned.h	btrfs: move the printk helpers out of ctree.h	2022-12-05 18:00:41 +01:00
zstd.c	btrfs: constify input buffer parameter in compression code	2022-12-05 18:00:55 +01:00