mirror of
https://github.com/torvalds/linux.git
synced 2024-12-25 04:11:49 +00:00
0738c8b591
After commit cc9f8349cb ("arm64: crypto: add NEON accelerated XOR
implementation"), Clang builds for arm64 started failing with the
following error message.
arch/arm64/lib/xor-neon.c:58:28: error: incompatible pointer types
assigning to 'const unsigned long *' from 'uint64_t *' (aka 'unsigned
long long *') [-Werror,-Wincompatible-pointer-types]
v3 = veorq_u64(vld1q_u64(dp1 + 6), vld1q_u64(dp2 + 6));
^~~~~~~~
/usr/lib/llvm-9/lib/clang/9.0.0/include/arm_neon.h:7538:47: note:
expanded from macro 'vld1q_u64'
__ret = (uint64x2_t) __builtin_neon_vld1q_v(__p0, 51); \
^~~~
There has been quite a bit of debate and triage that has gone into
figuring out what the proper fix is, viewable at the link below, which
is still ongoing. Ard suggested disabling this warning with Clang with a
pragma so no neon code will have this type of error. While this is not
at all an ideal solution, this build error is the only thing preventing
KernelCI from having successful arm64 defconfig and allmodconfig builds
on linux-next. Getting continuous integration running is more important
so new warnings/errors or boot failures can be caught and fixed quickly.
Link: https://github.com/ClangBuiltLinux/linux/issues/283
Suggested-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
44 lines
1.1 KiB
C
44 lines
1.1 KiB
C
/*
|
|
* Copyright (C) 2018 Linaro, Ltd. <ard.biesheuvel@linaro.org>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*/
|
|
|
|
#ifndef __ASM_NEON_INTRINSICS_H
|
|
#define __ASM_NEON_INTRINSICS_H
|
|
|
|
#include <asm-generic/int-ll64.h>
|
|
|
|
/*
|
|
* In the kernel, u64/s64 are [un]signed long long, not [un]signed long.
|
|
* So by redefining these macros to the former, we can force gcc-stdint.h
|
|
* to define uint64_t / in64_t in a compatible manner.
|
|
*/
|
|
|
|
#ifdef __INT64_TYPE__
|
|
#undef __INT64_TYPE__
|
|
#define __INT64_TYPE__ long long
|
|
#endif
|
|
|
|
#ifdef __UINT64_TYPE__
|
|
#undef __UINT64_TYPE__
|
|
#define __UINT64_TYPE__ unsigned long long
|
|
#endif
|
|
|
|
/*
|
|
* genksyms chokes on the ARM NEON instrinsics system header, but we
|
|
* don't export anything it defines anyway, so just disregard when
|
|
* genksyms execute.
|
|
*/
|
|
#ifndef __GENKSYMS__
|
|
#include <arm_neon.h>
|
|
#endif
|
|
|
|
#ifdef CONFIG_CC_IS_CLANG
|
|
#pragma clang diagnostic ignored "-Wincompatible-pointer-types"
|
|
#endif
|
|
|
|
#endif /* __ASM_NEON_INTRINSICS_H */
|