mirror of
https://github.com/torvalds/linux.git
synced 2024-11-06 03:51:48 +00:00
a0bf1ca27b
The issue was observed when LUN Reset is issued through IOCTL or sg_reset utility. fnic driver issues LUN RESET to firmware. On successful completion of device reset, driver cleans up all the pending IOs that were issued prior to device reset. These pending IOs are expected to be in ABTS_PENDING state. This works fine, when the device reset operation resulted from midlayer, but not when device reset was triggered from IOCTL path as the pending IOs were not in ABTS_PENDING state. execution path hits panic if the pending IO is not in ABTS_PENDING state. Changes: The fix replaces BUG_ON check in fnic_clean_pending_aborts() with marking pending IOs as ABTS_PENDING if they were not in ABTS_PENDING state and skips if they were already in ABTS_PENDING state. An extra check is added to validate the abort status of the commands after a delay of 2 * E_D_TOV using a helper function. The helper function returns 1 if it finds any pending IO in ABTS_PENDING state, belong to the LUN on which device reset was issued else 0. With this, device reset operation returns success only if the helper funciton returns 0, otherwise it returns failure. Other changes: - Removed code in fnic_clean_pending_aborts() that returns failure if it finds io_req NULL, instead of returning failure added code to continue with next io - Added device reset flags for debugging in fnic_terminate_rport_io, fnic_rport_exch_reset, and fnic_clean_pending_aborts Signed-off-by: Narsimhulu Musini <nmusini@cisco.com> Signed-off-by: Hiral Patel <hiralpat@cisco.com> Signed-off-by: James Bottomley <JBottomley@Parallels.com> |
||
|---|---|---|
| .. | ||
| cq_desc.h | ||
| cq_enet_desc.h | ||
| cq_exch_desc.h | ||
| fcpio.h | ||
| fnic_attrs.c | ||
| fnic_fcs.c | ||
| fnic_io.h | ||
| fnic_isr.c | ||
| fnic_main.c | ||
| fnic_res.c | ||
| fnic_res.h | ||
| fnic_scsi.c | ||
| fnic.h | ||
| Makefile | ||
| rq_enet_desc.h | ||
| vnic_cq_copy.h | ||
| vnic_cq.c | ||
| vnic_cq.h | ||
| vnic_dev.c | ||
| vnic_dev.h | ||
| vnic_devcmd.h | ||
| vnic_intr.c | ||
| vnic_intr.h | ||
| vnic_nic.h | ||
| vnic_resource.h | ||
| vnic_rq.c | ||
| vnic_rq.h | ||
| vnic_scsi.h | ||
| vnic_stats.h | ||
| vnic_wq_copy.c | ||
| vnic_wq_copy.h | ||
| vnic_wq.c | ||
| vnic_wq.h | ||
| wq_enet_desc.h | ||