linux

mirror of https://github.com/torvalds/linux.git synced 2024-11-23 20:51:44 +00:00

A mirror of the official Linux kernel repository just in case

Go to file

Steffen Maier 9fe5d2b2fd scsi: zfcp: fix passing fsf_req to SCSI trace on TMF to correlate with HBA Without this fix we get SCSI trace records on task management functions which cannot be correlated to HBA trace records because all fields related to the FSF request are empty (zero). Also, the FCP_RSP_IU is missing as well as any sense data if available. This was caused by v2.6.14 commit `8a36e4532e` ("[SCSI] zfcp: enhancement of zfcp debug features") introducing trace records for TMFs but hard coding NULL for a possibly existing TMF FSF request. The scsi_cmnd scribble is also zero or unrelated for the TMF request so it also could not lookup a suitable FSF request from there. A broken example trace record formatted with zfcpdbf from the s390-tools package: Timestamp : ... Area : SCSI Subarea : 00 Level : 1 Exception : - CPU ID : .. Caller : 0x... Record ID : 1 Tag : lr_fail Request ID : 0x0000000000000000 ^^^^^^^^^^^^^^^^ no correlation to HBA record SCSI ID : 0x<scsitarget> SCSI LUN : 0x<scsilun> SCSI result : 0x000e0000 SCSI retries : 0x00 SCSI allowed : 0x05 SCSI scribble : 0x0000000000000000 SCSI opcode : 2a000017 3bb80000 08000000 00000000 FCP rsp inf cod: 0x00 ^^ no TMF response FCP rsp IU : 00000000 00000000 00000000 00000000 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 00000000 00000000 ^^^^^^^^^^^^^^^^^ no interesting FCP_RSP_IU Sense len : ... ^^^^^^^^^^^^^^^^^^^^ no sense data length Sense info : ... ^^^^^^^^^^^^^^^^^^^^ no sense data content, even if present There are some true cases where we really do not have an FSF request: "rsl_fai" from zfcp_dbf_scsi_fail_send() called for early returns / completions in zfcp_scsi_queuecommand(), "abrt_or", "abrt_bl", "abrt_ru", "abrt_ar" from zfcp_scsi_eh_abort_handler() where we did not get as far, "lr_nres", "tr_nres" from zfcp_task_mgmt_function() where we're successful and do not need to do anything because adapter stopped. For these cases it's correct to pass NULL for fsf_req to _zfcp_dbf_scsi(). Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com> Fixes: `8a36e4532e` ("[SCSI] zfcp: enhancement of zfcp debug features") Cc: <stable@vger.kernel.org> #2.6.38+ Reviewed-by: Benjamin Block <bblock@linux.vnet.ibm.com> Signed-off-by: Benjamin Block <bblock@linux.vnet.ibm.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>		2017-08-10 19:36:56 -04:00
arch	Merge branch 'upstream' of git://git.linux-mips.org/pub/scm/ralf/upstream-linus	2017-08-06 11:52:01 -07:00
block	blk-mq: map queues to all present CPUs	2017-07-24 10:01:31 -06:00
certs	modsign: add markers to endif-statements in certs/Makefile	2017-07-14 11:01:37 +10:00
crypto	crypto: authencesn - Fix digest_null crash	2017-07-18 17:01:11 +08:00
Documentation	media fixes for v4.13-rc2	2017-08-05 14:09:26 -07:00
drivers	scsi: zfcp: fix passing fsf_req to SCSI trace on TMF to correlate with HBA	2017-08-10 19:36:56 -04:00
firmware	firmware/Makefile: force recompilation if makefile changes	2017-05-08 17:15:10 -07:00
fs	A large number of ext4 bug fixes and cleanups for v4.13	2017-08-06 12:31:17 -07:00
include	scsi: fc: start decoupling fc_block_scsi_eh from scsi_cmnd	2017-08-07 14:04:02 -04:00
init	random: do not ignore early device randomness	2017-07-12 16:26:00 -07:00
ipc	ipc: add missing container_of()s for randstruct	2017-08-02 17:16:12 -07:00
kernel	Fix compat_sys_sigpending breakage	2017-08-06 11:48:27 -07:00
lib	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-07-31 22:36:42 -07:00
mm	mm: take memory hotplug lock within numa_zonelist_order_handler()	2017-08-02 17:16:11 -07:00
net	A bunch of fixes and follow-ups for -rc1 Luminous patches: issues with	2017-08-04 10:15:11 -07:00
samples	samples/bpf: fix bpf tunnel cleanup	2017-07-31 22:02:47 -07:00
scripts	DeviceTree fixes for 4.13:	2017-07-28 17:21:41 -07:00
security	Now that IPC and other changes have landed, enable manual markings for	2017-07-19 08:55:18 -07:00
sound	ASoC: Fixes for v4.13	2017-08-02 17:11:45 +02:00
tools	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-07-31 22:36:42 -07:00
usr	ramfs: clarify help text that compression applies to ramfs as well as legacy ramdisk.	2017-07-06 16:24:30 -07:00
virt	KVM/ARM Fixes for v4.13-rc4	2017-08-03 17:59:58 +02:00
.cocciconfig	scripts: add Linux .cocciconfig for coccinelle	2016-07-22 12:13:39 +02:00
.get_maintainer.ignore
.gitattributes	.gitattributes: set git diff driver for C source code files	2016-10-07 18:46:30 -07:00
.gitignore	kbuild: Add support to generate LLVM assembly files	2017-04-25 08:13:52 +09:00
.mailmap	power supply and reset changes for the v4.12 series (part 2)	2017-05-12 12:02:21 -07:00
COPYING
CREDITS	avr32: remove support for AVR32 architecture	2017-05-01 09:27:15 +02:00
Kbuild	kbuild: Consolidate header generation from ASM offset information	2017-04-13 05:43:37 +09:00
Kconfig
MAINTAINERS	MAINTAINERS: Add myself to S390 ZFCP DRIVER as a co-maintainer	2017-08-07 14:04:03 -04:00
Makefile	Linux 4.13-rc4	2017-08-06 18:44:49 -07:00
README	README: add a new README file, pointing to the Documentation/	2016-10-24 08:12:35 -02:00

README

Linux kernel
============

This file was moved to Documentation/admin-guide/README.rst

Please notice that there are several guides for kernel developers and users.
These guides can be rendered in a number of formats, like HTML and PDF.

In order to build the documentation, use ``make htmldocs`` or
``make pdfdocs``.

There are various text files in the Documentation/ subdirectory,
several of them using the Restructured Text markup notation.
See Documentation/00-INDEX for a list of what is contained in each file.

Please read the Documentation/process/changes.rst file, as it contains the
requirements for building and running the kernel, and information about
the problems which may result by upgrading your kernel.