linux/net/x25
Johannes Berg 59ae1d127a networking: introduce and use skb_put_data()
A common pattern with skb_put() is to just want to memcpy()
some data into the new space, introduce skb_put_data() for
this.

An spatch similar to the one for skb_put_zero() converts many
of the places using it:

    @@
    identifier p, p2;
    expression len, skb, data;
    type t, t2;
    @@
    (
    -p = skb_put(skb, len);
    +p = skb_put_data(skb, data, len);
    |
    -p = (t)skb_put(skb, len);
    +p = skb_put_data(skb, data, len);
    )
    (
    p2 = (t2)p;
    -memcpy(p2, data, len);
    |
    -memcpy(p, data, len);
    )

    @@
    type t, t2;
    identifier p, p2;
    expression skb, data;
    @@
    t *p;
    ...
    (
    -p = skb_put(skb, sizeof(t));
    +p = skb_put_data(skb, data, sizeof(t));
    |
    -p = (t *)skb_put(skb, sizeof(t));
    +p = skb_put_data(skb, data, sizeof(t));
    )
    (
    p2 = (t2)p;
    -memcpy(p2, data, sizeof(*p));
    |
    -memcpy(p, data, sizeof(*p));
    )

    @@
    expression skb, len, data;
    @@
    -memcpy(skb_put(skb, len), data, len);
    +skb_put_data(skb, data, len);

(again, manually post-processed to retain some comments)

Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2017-06-16 11:48:37 -04:00
..
af_x25.c net: x25: fix one potential use-after-free issue 2017-05-18 10:05:40 -04:00
Kconfig net: x25: Fix dead URLs in Kconfig 2013-10-29 17:35:17 -04:00
Makefile
sysctl_net_x25.c net: x25: fix one potential use-after-free issue 2017-05-18 10:05:40 -04:00
x25_dev.c x25: convert printks to pr_<level> 2013-12-09 20:24:18 -05:00
x25_facilities.c net: fix a kernel infoleak in x25 module 2016-05-09 22:45:33 -04:00
x25_forward.c x25: convert printks to pr_<level> 2013-12-09 20:24:18 -05:00
x25_in.c net: Fix use after free by removing length arg from sk_data_ready callbacks. 2014-04-11 16:15:36 -04:00
x25_link.c Replace <asm/uaccess.h> with <linux/uaccess.h> globally 2016-12-24 11:46:01 -08:00
x25_out.c x25: remove the BKL 2011-03-05 10:55:45 +01:00
x25_proc.c x25: use proc_remove_subtree() 2013-04-09 14:13:35 -04:00
x25_route.c net: Fix (nearly-)kernel-doc comments for various functions 2012-07-10 23:13:45 -07:00
x25_subr.c networking: introduce and use skb_put_data() 2017-06-16 11:48:37 -04:00
x25_timer.c