Mikulas Patocka 0a9bab391e dm-crypt, dm-verity: disable tasklets ... Tasklets have an inherent problem with memory corruption. The function tasklet_action_common calls tasklet_trylock, then it calls the tasklet callback and then it calls tasklet_unlock. If the tasklet callback frees the structure that contains the tasklet or if it calls some code that may free it, tasklet_unlock will write into free memory. The commits 8e14f61015 and d9a02e016a try to fix it for dm-crypt, but it is not a sufficient fix and the data corruption can still happen [1]. There is no fix for dm-verity and dm-verity will write into free memory with every tasklet-processed bio. There will be atomic workqueues implemented in the kernel 6.9 [2]. They will have better interface and they will not suffer from the memory corruption problem. But we need something that stops the memory corruption now and that can be backported to the stable kernels. So, I'm proposing this commit that disables tasklets in both dm-crypt and dm-verity. This commit doesn't remove the tasklet support, because the tasklet code will be reused when atomic workqueues will be implemented. [1] https://lore.kernel.org/all/d390d7ee-f142-44d3-822a-87949e14608b@suse.de/T/ [2] https://lore.kernel.org/lkml/20240130091300.2968534-1-tj@kernel.org/ Signed-off-by: Mikulas Patocka <mpatocka@redhat.com> Cc: stable@vger.kernel.org Fixes: 39d42fa96b ("dm crypt: add flags to optionally bypass kcryptd workqueues") Fixes: 5721d4e5a9 ("dm verity: Add optional "try_verify_in_tasklet" feature") Signed-off-by: Mike Snitzer <snitzer@kernel.org>		2024-02-02 12:33:50 -05:00
..
bcache	for-6.8/block-2024-01-08	2024-01-11 13:58:04 -08:00
persistent-data	dm thin metadata: Fix ABBA deadlock by resetting dm_bufio_client	2023-06-16 18:24:13 -04:00
dm-audit.c	dm: add missing SPDX-License-Indentifiers	2023-02-14 14:23:06 -05:00
dm-audit.h	dm: introduce audit event module for device mapper	2021-10-27 16:53:47 -04:00
dm-bio-prison-v1.c	dm: Annotate struct dm_bio_prison with __counted_by	2023-10-02 09:48:53 -07:00
dm-bio-prison-v1.h	dm bio prison v1: add dm_cell_key_has_valid_range	2023-03-30 15:57:51 -04:00
dm-bio-prison-v2.c	dm: address space issues relative to switch/while/for/...	2023-02-14 14:23:06 -05:00
dm-bio-prison-v2.h	dm: change "unsigned" to "unsigned int"	2023-02-14 14:23:06 -05:00
dm-bio-record.h	dm: add missing SPDX-License-Indentifiers	2023-02-14 14:23:06 -05:00
dm-bufio.c	mm, treewide: rename MAX_ORDER to MAX_PAGE_ORDER	2024-01-08 15:27:15 -08:00
dm-builtin.c	dm: adjust EXPORT_SYMBOL() to follow functions immediately	2023-02-14 14:23:07 -05:00
dm-cache-background-tracker.c	dm: change "unsigned" to "unsigned int"	2023-02-14 14:23:06 -05:00
dm-cache-background-tracker.h	dm: change "unsigned" to "unsigned int"	2023-02-14 14:23:06 -05:00
dm-cache-block-types.h	dm: add missing SPDX-License-Indentifiers	2023-02-14 14:23:06 -05:00
dm-cache-metadata.c	Many singleton patches against the MM code. The patch series which are	2023-11-02 19:38:47 -10:00
dm-cache-metadata.h	dm: change "unsigned" to "unsigned int"	2023-02-14 14:23:06 -05:00
dm-cache-policy-internal.h	dm: add missing empty lines	2023-02-14 14:23:06 -05:00
dm-cache-policy-smq.c	dm cache policy smq: ensure IO doesn't prevent cleaner policy progress	2023-07-25 11:55:50 -04:00
dm-cache-policy.c	dm: change "unsigned" to "unsigned int"	2023-02-14 14:23:06 -05:00
dm-cache-policy.h	dm: address indent/space issues	2023-02-14 14:23:06 -05:00
dm-cache-target.c	block: replace fmode_t with a block-specific type for block open flags	2023-06-12 08:04:05 -06:00
dm-clone-metadata.c
dm-clone-metadata.h
dm-clone-target.c	block: replace fmode_t with a block-specific type for block open flags	2023-06-12 08:04:05 -06:00
dm-core.h	dm: limit the number of targets and parameter size area	2024-01-30 14:05:02 -05:00
dm-crypt.c	dm-crypt, dm-verity: disable tasklets	2024-02-02 12:33:50 -05:00
dm-delay.c	dm-delay: avoid duplicate logic	2023-11-17 14:41:14 -05:00
dm-dust.c	dm: add helper macro for simple DM target module init and exit	2023-04-11 12:09:08 -04:00
dm-ebs-target.c	dm: add helper macro for simple DM target module init and exit	2023-04-11 12:09:08 -04:00
dm-era-target.c	block: replace fmode_t with a block-specific type for block open flags	2023-06-12 08:04:05 -06:00
dm-exception-store.c	dm: change "unsigned" to "unsigned int"	2023-02-14 14:23:06 -05:00
dm-exception-store.h	dm: avoid spaces before function arguments or in favour of tabs	2023-02-14 14:23:06 -05:00
dm-flakey.c	mm, treewide: rename MAX_ORDER to MAX_PAGE_ORDER	2024-01-08 15:27:15 -08:00
dm-ima.c	dm: avoid inline filenames	2023-02-14 14:23:07 -05:00
dm-ima.h	dm: avoid inline filenames	2023-02-14 14:23:07 -05:00
dm-init.c	dm: open code dm_get_dev_t in dm_init_init	2023-06-05 10:57:40 -06:00
dm-integrity.c	dm-integrity: don't modify bio's immutable bio_vec in integrity_metadata()	2023-12-18 13:11:05 -05:00
dm-io-rewind.c	dm: avoid void function return statements	2023-02-14 14:23:07 -05:00
dm-io-tracker.h	dm: add missing SPDX-License-Indentifiers	2023-02-14 14:23:06 -05:00
dm-io.c	dm: remove unnecessary (void*) conversions	2023-04-11 12:01:01 -04:00
dm-ioctl.c	dm: limit the number of targets and parameter size area	2024-01-30 14:05:02 -05:00
dm-kcopyd.c	block: remove support for the host aware zone model	2023-12-19 20:17:43 -07:00
dm-linear.c	dm: shortcut the calls to linear_map and stripe_map	2023-10-06 19:09:25 -04:00
dm-log-userspace-base.c	dm log userspace: replace deprecated strncpy with strscpy	2023-10-23 13:02:48 -04:00
dm-log-userspace-transfer.c	dm: avoid split of quoted strings where possible	2023-02-14 14:23:07 -05:00
dm-log-userspace-transfer.h	dm: add missing SPDX-License-Indentifiers	2023-02-14 14:23:06 -05:00
dm-log-writes.c	dm: add helper macro for simple DM target module init and exit	2023-04-11 12:09:08 -04:00
dm-log.c	dm: remove unnecessary (void*) conversions	2023-04-11 12:01:01 -04:00
dm-mpath.c	dm: push error reporting down to dm_register_target()	2023-04-11 12:01:01 -04:00
dm-mpath.h	dm: change "unsigned" to "unsigned int"	2023-02-14 14:23:06 -05:00
dm-path-selector.c	dm: adjust EXPORT_SYMBOL() to follow functions immediately	2023-02-14 14:23:07 -05:00
dm-path-selector.h	dm: avoid spaces before function arguments or in favour of tabs	2023-02-14 14:23:06 -05:00
dm-ps-historical-service-time.c	dm: add missing SPDX-License-Indentifiers	2023-02-14 14:23:06 -05:00
dm-ps-io-affinity.c	dm: address space issues relative to switch/while/for/...	2023-02-14 14:23:06 -05:00
dm-ps-queue-length.c	dm: avoid spaces before function arguments or in favour of tabs	2023-02-14 14:23:06 -05:00
dm-ps-round-robin.c	dm: correct block comments format.	2023-02-14 14:23:06 -05:00
dm-ps-service-time.c	dm: avoid spaces before function arguments or in favour of tabs	2023-02-14 14:23:06 -05:00
dm-raid1.c	dm: remove unnecessary (void*) conversions	2023-04-11 12:01:01 -04:00
dm-raid.c	dm-raid: delay flushing event_work() after reconfig_mutex is released	2023-12-18 13:05:21 -05:00
dm-region-hash.c	dm: correct block comments format.	2023-02-14 14:23:06 -05:00
dm-rq.c	dm: avoid using symbolic permissions	2023-02-14 14:23:07 -05:00
dm-rq.h	dm: change "unsigned" to "unsigned int"	2023-02-14 14:23:06 -05:00
dm-snap-persistent.c	dm: remove unnecessary (void*) conversions	2023-04-11 12:01:01 -04:00
dm-snap-transient.c	dm: avoid split of quoted strings where possible	2023-02-14 14:23:07 -05:00
dm-snap.c	block: replace fmode_t with a block-specific type for block open flags	2023-06-12 08:04:05 -06:00
dm-stats.c	dm stats: limit the number of entries	2024-01-30 14:06:44 -05:00
dm-stats.h	dm stats: check for and propagate alloc_percpu failure	2023-03-16 13:37:06 -04:00
dm-stripe.c	- Update DM core to directly call the map function for both the linear	2023-11-01 12:55:54 -10:00
dm-switch.c	dm: add helper macro for simple DM target module init and exit	2023-04-11 12:09:08 -04:00
dm-sysfs.c	dm sysfs: make kobj_type structure constant	2023-02-14 14:23:08 -05:00
dm-table.c	dm: limit the number of targets and parameter size area	2024-01-30 14:05:02 -05:00
dm-target.c	dm error: Add support for zoned block devices	2023-10-31 11:06:21 -04:00
dm-thin-metadata.c	- Update DM crypt to allocate compound pages if possible.	2023-06-30 12:16:00 -07:00
dm-thin-metadata.h	dm: add missing SPDX-License-Indentifiers	2023-02-14 14:23:06 -05:00
dm-thin.c	- Update DM crypt to allocate compound pages if possible.	2023-06-30 12:16:00 -07:00
dm-uevent.c	dm: avoid spaces before function arguments or in favour of tabs	2023-02-14 14:23:06 -05:00
dm-uevent.h	dm: fix undue/missing spaces	2023-02-14 14:23:06 -05:00
dm-unstripe.c	dm: add helper macro for simple DM target module init and exit	2023-04-11 12:09:08 -04:00
dm-verity-fec.c	dm-verity: align struct dm_verity_fec_io properly	2023-11-29 12:58:06 -05:00
dm-verity-fec.h	dm: change "unsigned" to "unsigned int"	2023-02-14 14:23:06 -05:00
dm-verity-loadpin.c	dm: verity-loadpin: Add NULL pointer check for 'bdev' parameter	2023-06-28 10:43:04 -07:00
dm-verity-target.c	dm-crypt, dm-verity: disable tasklets	2024-02-02 12:33:50 -05:00
dm-verity-verify-sig.c	dm: add missing SPDX-License-Indentifiers	2023-02-14 14:23:06 -05:00
dm-verity-verify-sig.h	dm: add missing SPDX-License-Indentifiers	2023-02-14 14:23:06 -05:00
dm-verity.h	dm-crypt, dm-verity: disable tasklets	2024-02-02 12:33:50 -05:00
dm-writecache.c	dm writecache: allow allocations larger than 2GiB	2024-01-30 14:07:30 -05:00
dm-zero.c	dm: add helper macro for simple DM target module init and exit	2023-04-11 12:09:08 -04:00
dm-zone.c	dm zone: Use the bitmap API to allocate bitmaps	2023-06-16 18:24:13 -04:00
dm-zoned-metadata.c	block: remove support for the host aware zone model	2023-12-19 20:17:43 -07:00
dm-zoned-reclaim.c
dm-zoned-target.c	block: remove support for the host aware zone model	2023-12-19 20:17:43 -07:00
dm-zoned.h	dm/dm-zoned: Use the enum req_op type	2022-07-14 12:14:31 -06:00
dm.c	bdev: rename freeze and thaw helpers	2023-11-18 14:59:23 +01:00
dm.h	dm: shortcut the calls to linear_map and stripe_map	2023-10-06 19:09:25 -04:00
Kconfig	for-6.8/block-2024-01-08	2024-01-11 13:58:04 -08:00
Makefile	md: Remove deprecated CONFIG_MD_FAULTY	2023-12-19 10:37:50 -08:00
md-autodetect.c	md: Remove deprecated CONFIG_MD_LINEAR	2023-12-19 10:16:51 -08:00
md-bitmap.c	md: cleanup mddev_create/destroy_serial_pool()	2023-10-10 18:49:51 -07:00
md-bitmap.h	md-bitmap: don't use ->index for pages backing the bitmap file	2023-07-27 00:13:29 -07:00
md-cluster.c	md-cluster: check for timeout while a new disk adding	2023-10-12 09:16:19 -07:00
md-cluster.h
md-linear.h	md/md-linear: Annotate struct linear_conf with __counted_by	2023-09-22 11:23:01 -07:00
md-multipath.h
md.c	for-6.8/block-2024-01-18	2024-01-18 18:22:40 -08:00
md.h	md: remove flag RemoveSynchronized	2023-11-27 15:49:04 -08:00
raid0.c	md: raid0: account for split bio in iostat accounting	2023-08-17 21:11:31 -07:00
raid0.h	md/raid0: add discard support for the 'original' layout	2023-06-30 15:43:50 -07:00
raid1-10.c	md: factor out a helper exceed_read_errors() to check read_errors	2023-12-15 15:22:15 -08:00
raid1.c	md: fix a suspicious RCU usage warning	2024-01-24 22:58:00 -08:00
raid1.h	md/raid1: switch to use md_account_bio() for io accounting	2023-07-27 00:13:29 -07:00
raid5-cache.c	md/raid5: remove rcu protection to access rdev from conf	2023-11-27 15:49:05 -08:00
raid5-log.h	md/raid5-ppl: Drop unused argument from ppl_handle_flush_request()	2022-08-02 17:14:31 -06:00
raid5-ppl.c	md/raid5: remove rcu protection to access rdev from conf	2023-11-27 15:49:05 -08:00
raid5.c	for-6.8/block-2024-01-08	2024-01-11 13:58:04 -08:00
raid5.h	md/raid5: remove rcu protection to access rdev from conf	2023-11-27 15:49:05 -08:00
raid10.c	md: factor out a helper exceed_read_errors() to check read_errors	2023-12-15 15:22:15 -08:00
raid10.h	md/raid10: switch to use md_account_bio() for io accounting	2023-07-27 00:13:29 -07:00