linux/fs/f2fs
Chao Yu 958ccbbf1c Revert "f2fs: fix to do sanity check on extent cache correctly"
syzbot reports a f2fs bug as below:

UBSAN: array-index-out-of-bounds in fs/f2fs/f2fs.h:3275:19
index 1409 is out of range for type '__le32[923]' (aka 'unsigned int[923]')
Call Trace:
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106
 ubsan_epilogue lib/ubsan.c:217 [inline]
 __ubsan_handle_out_of_bounds+0x11c/0x150 lib/ubsan.c:348
 inline_data_addr fs/f2fs/f2fs.h:3275 [inline]
 __recover_inline_status fs/f2fs/inode.c:113 [inline]
 do_read_inode fs/f2fs/inode.c:480 [inline]
 f2fs_iget+0x4730/0x48b0 fs/f2fs/inode.c:604
 f2fs_fill_super+0x640e/0x80c0 fs/f2fs/super.c:4601
 mount_bdev+0x276/0x3b0 fs/super.c:1391
 legacy_get_tree+0xef/0x190 fs/fs_context.c:611
 vfs_get_tree+0x8c/0x270 fs/super.c:1519
 do_new_mount+0x28f/0xae0 fs/namespace.c:3335
 do_mount fs/namespace.c:3675 [inline]
 __do_sys_mount fs/namespace.c:3884 [inline]
 __se_sys_mount+0x2d9/0x3c0 fs/namespace.c:3861
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd

The issue was bisected to:

commit d48a7b3a72
Author: Chao Yu <chao@kernel.org>
Date:   Mon Jan 9 03:49:20 2023 +0000

    f2fs: fix to do sanity check on extent cache correctly

The root cause is we applied both v1 and v2 of the patch, v2 is the right
fix, so it needs to revert v1 in order to fix reported issue.

v1:
commit d48a7b3a72 ("f2fs: fix to do sanity check on extent cache correctly")
https://lore.kernel.org/lkml/20230109034920.492914-1-chao@kernel.org/

v2:
commit 269d119481 ("f2fs: fix to do sanity check on extent cache correctly")
https://lore.kernel.org/lkml/20230207134808.1827869-1-chao@kernel.org/

Reported-by: syzbot+601018296973a481f302@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/linux-f2fs-devel/000000000000fcf0690600e4d04d@google.com/
Fixes: d48a7b3a72 ("f2fs: fix to do sanity check on extent cache correctly")
Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
2023-08-14 13:41:09 -07:00
..
acl.c fs: port i_{g,u}id_into_vfs{g,u}id() to mnt_idmap 2023-01-19 09:24:29 +01:00
acl.h fs: port ->set_acl() to pass mnt_idmap 2023-01-19 09:24:27 +01:00
checkpoint.c f2fs: support errors=remount-ro|continue|panic mountoption 2023-05-08 11:18:04 -07:00
compress.c f2fs: don't handle error case of f2fs_compress_alloc_page() 2023-08-14 13:41:06 -07:00
data.c f2fs: increase usage of folio_next_index() helper 2023-08-14 13:41:09 -07:00
debug.c f2fs: fix to recover quota data correctly 2023-04-12 20:00:36 -07:00
dir.c f2fs: fix deadlock in i_xattr_sem and inode page lock 2023-06-30 16:38:09 -07:00
extent_cache.c f2fs: remove unnessary comment in __may_age_extent_tree 2023-04-24 11:03:10 -07:00
f2fs.h f2fs: check zone type before sending async reset zone command 2023-08-14 13:41:09 -07:00
file.c f2fs: compress: don't {,de}compress non-full cluster 2023-08-14 13:41:08 -07:00
gc.c f2fs: check return value of freeze_super() 2023-06-26 06:07:08 -07:00
gc.h f2fs: Fix system crash due to lack of free space in LFS 2023-04-10 10:58:45 -07:00
hash.c f2fs: don't use casefolded comparison for "." and ".." 2022-05-17 11:19:23 -07:00
inline.c f2fs: use common implementation of file type 2023-04-10 10:58:45 -07:00
inode.c Revert "f2fs: fix to do sanity check on extent cache correctly" 2023-08-14 13:41:09 -07:00
iostat.c f2fs: add async reset zone command support 2023-06-12 13:04:09 -07:00
iostat.h f2fs: use iostat_lat_type directly as a parameter in the iostat_update_and_unbind_ctx() 2023-02-07 10:39:28 -08:00
Kconfig f2fs: introduce F2FS_UNFAIR_RWSEM to support unfair rwsem 2022-03-04 09:15:53 -08:00
Makefile f2fs: separate out iostat feature 2021-08-23 10:25:51 -07:00
namei.c f2fs update for 6.5-rc1 2023-07-05 14:14:37 -07:00
node.c f2fs: fix to do sanity check on direct node in truncate_dnode() 2023-06-30 16:38:27 -07:00
node.h f2fs: fix compile warning in f2fs_destroy_node_manager() 2023-06-30 16:38:27 -07:00
recovery.c f2fs: remove redundant assignment to variable err 2023-06-26 06:21:41 -07:00
segment.c f2fs: check zone type before sending async reset zone command 2023-08-14 13:41:09 -07:00
segment.h f2fs: add has_enough_free_secs() 2023-04-18 09:05:54 -07:00
shrinker.c f2fs: add block_age-based extent cache 2022-12-12 14:53:56 -08:00
super.c f2fs: Only lfs mode is allowed with zoned block device feature 2023-08-14 13:41:09 -07:00
sysfs.c f2fs: refactor struct f2fs_attr macro 2023-06-26 06:21:41 -07:00
verity.c f2fs-for-6.3-rc1 2023-02-27 16:18:51 -08:00
xattr.c f2fs: fix deadlock in i_xattr_sem and inode page lock 2023-06-30 16:38:09 -07:00
xattr.h f2fs: cleanup MIN_INLINE_XATTR_SIZE 2023-06-26 06:07:10 -07:00