mirror of
https://github.com/torvalds/linux.git
synced 2024-12-12 14:12:51 +00:00
16bdbae394
Most hw_random devices return entropy which is assumed to be of full quality, but driver authors don't bother setting the quality knob. Some hw_random devices return less than full quality entropy, and then driver authors set the quality knob. Therefore, the entropy crediting should be opt-out rather than opt-in per-driver, to reflect the actual reality on the ground. For example, the two Raspberry Pi RNG drivers produce full entropy randomness, and both EDK2 and U-Boot's drivers for these treat them as such. The result is that EFI then uses these numbers and passes the to Linux, and Linux credits them as boot, thereby initializing the RNG. Yet, in Linux, the quality knob was never set to anything, and so on the chance that Linux is booted without EFI, nothing is ever credited. That's annoying. The same pattern appears to repeat itself throughout various drivers. In fact, very very few drivers have bothered setting quality=1024. Looking at the git history of existing drivers and corresponding mailing list discussion, this conclusion tracks. There's been a decent amount of discussion about drivers that set quality < 1024 -- somebody read and interepreted a datasheet, or made some back of the envelope calculation somehow. But there's been very little, if any, discussion about most drivers where the quality is just set to 1024 or unset (or set to 1000 when the authors misunderstood the API and assumed it was base-10 rather than base-2); in both cases the intent was fairly clear of, "this is a hardware random device; it's fine." So let's invert this logic. A hw_random struct's quality knob now controls the maximum quality a driver can produce, or 0 to specify 1024. Then, the module-wide switch called "default_quality" is changed to represent the maximum quality of any driver. By default it's 1024, and the quality of any particular driver is then given by: min(default_quality, rng->quality ?: 1024); This way, the user can still turn this off for weird reasons (and we can replace whatever driver-specific disabling hacks existed in the past), yet we get proper crediting for relevant RNGs. Cc: Dominik Brodowski <linux@dominikbrodowski.net> Cc: Ard Biesheuvel <ardb@kernel.org> Cc: Herbert Xu <herbert@gondor.apana.org.au> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
211 lines
5.3 KiB
C
211 lines
5.3 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* drivers/char/hw_random/timeriomem-rng.c
|
|
*
|
|
* Copyright (C) 2009 Alexander Clouter <alex@digriz.org.uk>
|
|
*
|
|
* Derived from drivers/char/hw_random/omap-rng.c
|
|
* Copyright 2005 (c) MontaVista Software, Inc.
|
|
* Author: Deepak Saxena <dsaxena@plexity.net>
|
|
*
|
|
* Overview:
|
|
* This driver is useful for platforms that have an IO range that provides
|
|
* periodic random data from a single IO memory address. All the platform
|
|
* has to do is provide the address and 'wait time' that new data becomes
|
|
* available.
|
|
*
|
|
* TODO: add support for reading sizes other than 32bits and masking
|
|
*/
|
|
|
|
#include <linux/completion.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/hrtimer.h>
|
|
#include <linux/hw_random.h>
|
|
#include <linux/io.h>
|
|
#include <linux/ktime.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/time.h>
|
|
#include <linux/timeriomem-rng.h>
|
|
|
|
struct timeriomem_rng_private {
|
|
void __iomem *io_base;
|
|
ktime_t period;
|
|
unsigned int present:1;
|
|
|
|
struct hrtimer timer;
|
|
struct completion completion;
|
|
|
|
struct hwrng rng_ops;
|
|
};
|
|
|
|
static int timeriomem_rng_read(struct hwrng *hwrng, void *data,
|
|
size_t max, bool wait)
|
|
{
|
|
struct timeriomem_rng_private *priv =
|
|
container_of(hwrng, struct timeriomem_rng_private, rng_ops);
|
|
int retval = 0;
|
|
int period_us = ktime_to_us(priv->period);
|
|
|
|
/*
|
|
* There may not have been enough time for new data to be generated
|
|
* since the last request. If the caller doesn't want to wait, let them
|
|
* bail out. Otherwise, wait for the completion. If the new data has
|
|
* already been generated, the completion should already be available.
|
|
*/
|
|
if (!wait && !priv->present)
|
|
return 0;
|
|
|
|
wait_for_completion(&priv->completion);
|
|
|
|
do {
|
|
/*
|
|
* After the first read, all additional reads will need to wait
|
|
* for the RNG to generate new data. Since the period can have
|
|
* a wide range of values (1us to 1s have been observed), allow
|
|
* for 1% tolerance in the sleep time rather than a fixed value.
|
|
*/
|
|
if (retval > 0)
|
|
usleep_range(period_us,
|
|
period_us + max(1, period_us / 100));
|
|
|
|
*(u32 *)data = readl(priv->io_base);
|
|
retval += sizeof(u32);
|
|
data += sizeof(u32);
|
|
max -= sizeof(u32);
|
|
} while (wait && max > sizeof(u32));
|
|
|
|
/*
|
|
* Block any new callers until the RNG has had time to generate new
|
|
* data.
|
|
*/
|
|
priv->present = 0;
|
|
reinit_completion(&priv->completion);
|
|
hrtimer_forward_now(&priv->timer, priv->period);
|
|
hrtimer_restart(&priv->timer);
|
|
|
|
return retval;
|
|
}
|
|
|
|
static enum hrtimer_restart timeriomem_rng_trigger(struct hrtimer *timer)
|
|
{
|
|
struct timeriomem_rng_private *priv
|
|
= container_of(timer, struct timeriomem_rng_private, timer);
|
|
|
|
priv->present = 1;
|
|
complete(&priv->completion);
|
|
|
|
return HRTIMER_NORESTART;
|
|
}
|
|
|
|
static int timeriomem_rng_probe(struct platform_device *pdev)
|
|
{
|
|
struct timeriomem_rng_data *pdata = pdev->dev.platform_data;
|
|
struct timeriomem_rng_private *priv;
|
|
struct resource *res;
|
|
int err = 0;
|
|
int period;
|
|
|
|
if (!pdev->dev.of_node && !pdata) {
|
|
dev_err(&pdev->dev, "timeriomem_rng_data is missing\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
if (!res)
|
|
return -ENXIO;
|
|
|
|
if (res->start % 4 != 0 || resource_size(res) < 4) {
|
|
dev_err(&pdev->dev,
|
|
"address must be at least four bytes wide and 32-bit aligned\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
/* Allocate memory for the device structure (and zero it) */
|
|
priv = devm_kzalloc(&pdev->dev,
|
|
sizeof(struct timeriomem_rng_private), GFP_KERNEL);
|
|
if (!priv)
|
|
return -ENOMEM;
|
|
|
|
platform_set_drvdata(pdev, priv);
|
|
|
|
if (pdev->dev.of_node) {
|
|
int i;
|
|
|
|
if (!of_property_read_u32(pdev->dev.of_node,
|
|
"period", &i))
|
|
period = i;
|
|
else {
|
|
dev_err(&pdev->dev, "missing period\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
if (!of_property_read_u32(pdev->dev.of_node,
|
|
"quality", &i))
|
|
priv->rng_ops.quality = i;
|
|
} else {
|
|
period = pdata->period;
|
|
priv->rng_ops.quality = pdata->quality;
|
|
}
|
|
|
|
priv->period = ns_to_ktime(period * NSEC_PER_USEC);
|
|
init_completion(&priv->completion);
|
|
hrtimer_init(&priv->timer, CLOCK_MONOTONIC, HRTIMER_MODE_ABS);
|
|
priv->timer.function = timeriomem_rng_trigger;
|
|
|
|
priv->rng_ops.name = dev_name(&pdev->dev);
|
|
priv->rng_ops.read = timeriomem_rng_read;
|
|
|
|
priv->io_base = devm_ioremap_resource(&pdev->dev, res);
|
|
if (IS_ERR(priv->io_base)) {
|
|
return PTR_ERR(priv->io_base);
|
|
}
|
|
|
|
/* Assume random data is already available. */
|
|
priv->present = 1;
|
|
complete(&priv->completion);
|
|
|
|
err = devm_hwrng_register(&pdev->dev, &priv->rng_ops);
|
|
if (err) {
|
|
dev_err(&pdev->dev, "problem registering\n");
|
|
return err;
|
|
}
|
|
|
|
dev_info(&pdev->dev, "32bits from 0x%p @ %dus\n",
|
|
priv->io_base, period);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int timeriomem_rng_remove(struct platform_device *pdev)
|
|
{
|
|
struct timeriomem_rng_private *priv = platform_get_drvdata(pdev);
|
|
|
|
hrtimer_cancel(&priv->timer);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct of_device_id timeriomem_rng_match[] = {
|
|
{ .compatible = "timeriomem_rng" },
|
|
{},
|
|
};
|
|
MODULE_DEVICE_TABLE(of, timeriomem_rng_match);
|
|
|
|
static struct platform_driver timeriomem_rng_driver = {
|
|
.driver = {
|
|
.name = "timeriomem_rng",
|
|
.of_match_table = timeriomem_rng_match,
|
|
},
|
|
.probe = timeriomem_rng_probe,
|
|
.remove = timeriomem_rng_remove,
|
|
};
|
|
|
|
module_platform_driver(timeriomem_rng_driver);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_AUTHOR("Alexander Clouter <alex@digriz.org.uk>");
|
|
MODULE_DESCRIPTION("Timer IOMEM H/W RNG driver");
|