mirror of
https://github.com/torvalds/linux.git
synced 2024-11-27 22:51:35 +00:00
61f611593f
This is a fix for another instance of the skid problem Milian recently
found [1]
The LBRs don't freeze at the exact same time as the PMI is triggered.
The perf script brstackinsn code that dumps LBR assembler assumes that
the last branch in the LBR leads to the sample point. But with skid
it's possible that the CPU executes one or more branches before the
sample, but which do not appear in the LBR.
What happens then is either that the sample point is before the last LBR
branch. In this case the dumper sees a negative length and ignores it.
Or it the sample point is long after the last branch. Then the dumper
sees a very long block and dumps it upto its block limit (16k bytes),
which is noise in the output.
On typical sample session this can happen regularly.
This patch tries to detect and handle the situation. On the last block
that is dumped by the LBR dumper we always stop on the first branch. If
the block length is negative just scan forward to the first branch.
Otherwise scan until a branch is found.
The PT decoder already has a function that uses the instruction decoder
to detect branches, so we can just reuse it here.
Then when a terminating branch is found print an indication and stop
dumping. This might miss a few instructions, but at least shows no
runaway blocks.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Milian Wolff <milian.wolff@kdab.com>
Link: http://lkml.kernel.org/r/20181120050617.4119-1-andi@firstfloor.org
[ Resolved conflict with dd2e18e9ac ("perf tools: Support 'srccode' output") ]
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
26 lines
502 B
C
26 lines
502 B
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef __PERF_DUMP_INSN_H
|
|
#define __PERF_DUMP_INSN_H 1
|
|
|
|
#define MAXINSN 15
|
|
|
|
#include <linux/types.h>
|
|
|
|
struct thread;
|
|
|
|
struct perf_insn {
|
|
/* Initialized by callers: */
|
|
struct thread *thread;
|
|
u8 cpumode;
|
|
bool is64bit;
|
|
int cpu;
|
|
/* Temporary */
|
|
char out[256];
|
|
};
|
|
|
|
const char *dump_insn(struct perf_insn *x, u64 ip,
|
|
u8 *inbuf, int inlen, int *lenp);
|
|
int arch_is_branch(const unsigned char *buf, size_t len, int x86_64);
|
|
|
|
#endif
|