mirror of
https://github.com/torvalds/linux.git
synced 2024-12-25 12:21:37 +00:00
0a0d1740bd
The existing code copies the hw_params pointer and reuses it later in
.prepare, specifically to re-initialize the ALH DMA channel
information that's lost in suspend-resume cycles.
This is not needed, we can directly access the information from the
substream/rtd - as done for the HDAudio DAIs in
sound/soc/sof/intel/hda-dai.c
In addition, using the saved pointer causes the suspend-resume test
cases to fail on specific platforms, depending on which version of GCC
is used. Péter Ujfalusi and I have spent long hours to root-cause this
problem that was reported by the Intel CI first with 6.2-rc1 and again
v6.3-rc1. In the latter case we were lucky that the problem was 100%
reproducible on local test devices, and found out that adding a
dev_dbg() or adding a call to usleep_range() just before accessing the
saved pointer "fixed" the issue. With errors appearing just by
changing the compiler version or minor changes in the code generated,
clearly we have a memory management Heisenbug.
The root-cause seems to be that the hw_params pointer is not
persistent. The soc-pcm code allocates the hw_params structure on the
stack, and passes it to the BE dailink hw_params and DAIs
hw_params. Saving such a pointer and reusing it later during the
.prepare stage cannot possibly work reliably, it's broken-by-design
since v5.10. It's astonishing that the problem was not seen earlier.
This simple fix will have to be back-ported to -stable, due to changes
to avoid the use of the get/set_dmadata routines this patch will only
apply on kernels older than v6.1.
Fixes: a5a0239c27 ("soundwire: intel: reinitialize IP+DSP in .prepare(), but only when resuming")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Link: https://lore.kernel.org/r/20230321022642.1426611-1-yung-chuan.liao@linux.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
201 lines
5.2 KiB
C
201 lines
5.2 KiB
C
/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */
|
|
/* Copyright(c) 2015-17 Intel Corporation. */
|
|
#include <sound/soc.h>
|
|
|
|
#ifndef __SDW_CADENCE_H
|
|
#define __SDW_CADENCE_H
|
|
|
|
#define SDW_CADENCE_GSYNC_KHZ 4 /* 4 kHz */
|
|
#define SDW_CADENCE_GSYNC_HZ (SDW_CADENCE_GSYNC_KHZ * 1000)
|
|
|
|
/*
|
|
* The Cadence IP supports up to 32 entries in the FIFO, though implementations
|
|
* can configure the IP to have a smaller FIFO.
|
|
*/
|
|
#define CDNS_MCP_IP_MAX_CMD_LEN 32
|
|
|
|
/**
|
|
* struct sdw_cdns_pdi: PDI (Physical Data Interface) instance
|
|
*
|
|
* @num: pdi number
|
|
* @intel_alh_id: link identifier
|
|
* @l_ch_num: low channel for PDI
|
|
* @h_ch_num: high channel for PDI
|
|
* @ch_count: total channel count for PDI
|
|
* @dir: data direction
|
|
* @type: stream type, (only PCM supported)
|
|
*/
|
|
struct sdw_cdns_pdi {
|
|
int num;
|
|
int intel_alh_id;
|
|
int l_ch_num;
|
|
int h_ch_num;
|
|
int ch_count;
|
|
enum sdw_data_direction dir;
|
|
enum sdw_stream_type type;
|
|
};
|
|
|
|
/**
|
|
* struct sdw_cdns_streams: Cadence stream data structure
|
|
*
|
|
* @num_bd: number of bidirectional streams
|
|
* @num_in: number of input streams
|
|
* @num_out: number of output streams
|
|
* @num_ch_bd: number of bidirectional stream channels
|
|
* @num_ch_bd: number of input stream channels
|
|
* @num_ch_bd: number of output stream channels
|
|
* @num_pdi: total number of PDIs
|
|
* @bd: bidirectional streams
|
|
* @in: input streams
|
|
* @out: output streams
|
|
*/
|
|
struct sdw_cdns_streams {
|
|
unsigned int num_bd;
|
|
unsigned int num_in;
|
|
unsigned int num_out;
|
|
unsigned int num_ch_bd;
|
|
unsigned int num_ch_in;
|
|
unsigned int num_ch_out;
|
|
unsigned int num_pdi;
|
|
struct sdw_cdns_pdi *bd;
|
|
struct sdw_cdns_pdi *in;
|
|
struct sdw_cdns_pdi *out;
|
|
};
|
|
|
|
/**
|
|
* struct sdw_cdns_stream_config: stream configuration
|
|
*
|
|
* @pcm_bd: number of bidirectional PCM streams supported
|
|
* @pcm_in: number of input PCM streams supported
|
|
* @pcm_out: number of output PCM streams supported
|
|
*/
|
|
struct sdw_cdns_stream_config {
|
|
unsigned int pcm_bd;
|
|
unsigned int pcm_in;
|
|
unsigned int pcm_out;
|
|
};
|
|
|
|
/**
|
|
* struct sdw_cdns_dai_runtime: Cadence DAI runtime data
|
|
*
|
|
* @name: SoundWire stream name
|
|
* @stream: stream runtime
|
|
* @pdi: PDI used for this dai
|
|
* @bus: Bus handle
|
|
* @stream_type: Stream type
|
|
* @link_id: Master link id
|
|
* @suspended: status set when suspended, to be used in .prepare
|
|
* @paused: status set in .trigger, to be used in suspend
|
|
* @direction: stream direction
|
|
*/
|
|
struct sdw_cdns_dai_runtime {
|
|
char *name;
|
|
struct sdw_stream_runtime *stream;
|
|
struct sdw_cdns_pdi *pdi;
|
|
struct sdw_bus *bus;
|
|
enum sdw_stream_type stream_type;
|
|
int link_id;
|
|
bool suspended;
|
|
bool paused;
|
|
int direction;
|
|
};
|
|
|
|
/**
|
|
* struct sdw_cdns - Cadence driver context
|
|
* @dev: Linux device
|
|
* @bus: Bus handle
|
|
* @instance: instance number
|
|
* @ip_offset: version-dependent offset to access IP_MCP registers and fields
|
|
* @response_buf: SoundWire response buffer
|
|
* @tx_complete: Tx completion
|
|
* @ports: Data ports
|
|
* @num_ports: Total number of data ports
|
|
* @pcm: PCM streams
|
|
* @registers: Cadence registers
|
|
* @link_up: Link status
|
|
* @msg_count: Messages sent on bus
|
|
* @dai_runtime_array: runtime context for each allocated DAI.
|
|
*/
|
|
struct sdw_cdns {
|
|
struct device *dev;
|
|
struct sdw_bus bus;
|
|
unsigned int instance;
|
|
|
|
u32 ip_offset;
|
|
|
|
/*
|
|
* The datasheet says the RX FIFO AVAIL can be 2 entries more
|
|
* than the FIFO capacity, so allow for this.
|
|
*/
|
|
u32 response_buf[CDNS_MCP_IP_MAX_CMD_LEN + 2];
|
|
|
|
struct completion tx_complete;
|
|
|
|
struct sdw_cdns_port *ports;
|
|
int num_ports;
|
|
|
|
struct sdw_cdns_streams pcm;
|
|
|
|
int pdi_loopback_source;
|
|
int pdi_loopback_target;
|
|
|
|
void __iomem *registers;
|
|
|
|
bool link_up;
|
|
unsigned int msg_count;
|
|
bool interrupt_enabled;
|
|
|
|
struct work_struct work;
|
|
|
|
struct list_head list;
|
|
|
|
struct sdw_cdns_dai_runtime **dai_runtime_array;
|
|
};
|
|
|
|
#define bus_to_cdns(_bus) container_of(_bus, struct sdw_cdns, bus)
|
|
|
|
/* Exported symbols */
|
|
|
|
int sdw_cdns_probe(struct sdw_cdns *cdns);
|
|
|
|
irqreturn_t sdw_cdns_irq(int irq, void *dev_id);
|
|
irqreturn_t sdw_cdns_thread(int irq, void *dev_id);
|
|
|
|
int sdw_cdns_init(struct sdw_cdns *cdns);
|
|
int sdw_cdns_pdi_init(struct sdw_cdns *cdns,
|
|
struct sdw_cdns_stream_config config);
|
|
int sdw_cdns_exit_reset(struct sdw_cdns *cdns);
|
|
int sdw_cdns_enable_interrupt(struct sdw_cdns *cdns, bool state);
|
|
|
|
bool sdw_cdns_is_clock_stop(struct sdw_cdns *cdns);
|
|
int sdw_cdns_clock_stop(struct sdw_cdns *cdns, bool block_wake);
|
|
int sdw_cdns_clock_restart(struct sdw_cdns *cdns, bool bus_reset);
|
|
|
|
#ifdef CONFIG_DEBUG_FS
|
|
void sdw_cdns_debugfs_init(struct sdw_cdns *cdns, struct dentry *root);
|
|
#endif
|
|
|
|
struct sdw_cdns_pdi *sdw_cdns_alloc_pdi(struct sdw_cdns *cdns,
|
|
struct sdw_cdns_streams *stream,
|
|
u32 ch, u32 dir, int dai_id);
|
|
void sdw_cdns_config_stream(struct sdw_cdns *cdns,
|
|
u32 ch, u32 dir, struct sdw_cdns_pdi *pdi);
|
|
|
|
enum sdw_command_response
|
|
cdns_xfer_msg(struct sdw_bus *bus, struct sdw_msg *msg);
|
|
|
|
enum sdw_command_response
|
|
cdns_xfer_msg_defer(struct sdw_bus *bus);
|
|
|
|
u32 cdns_read_ping_status(struct sdw_bus *bus);
|
|
|
|
int cdns_bus_conf(struct sdw_bus *bus, struct sdw_bus_params *params);
|
|
|
|
int cdns_set_sdw_stream(struct snd_soc_dai *dai,
|
|
void *stream, int direction);
|
|
|
|
void sdw_cdns_check_self_clearing_bits(struct sdw_cdns *cdns, const char *string,
|
|
bool initial_delay, int reset_iterations);
|
|
|
|
#endif /* __SDW_CADENCE_H */
|