mirror of
https://github.com/torvalds/linux.git
synced 2024-12-13 22:53:20 +00:00
3230f4a8d4
The following warning can happen when a memory shortage
occurs during txreq allocation:
[10220.939246] SLUB: Unable to allocate memory on node -1, gfp=0xa20(GFP_ATOMIC)
[10220.939246] Hardware name: Intel Corporation S2600WT2R/S2600WT2R, BIOS SE5C610.86B.01.01.0018.C4.072020161249 07/20/2016
[10220.939247] cache: mnt_cache, object size: 384, buffer size: 384, default order: 2, min order: 0
[10220.939260] Workqueue: hfi0_0 _hfi1_do_send [hfi1]
[10220.939261] node 0: slabs: 1026568, objs: 43115856, free: 0
[10220.939262] Call Trace:
[10220.939262] node 1: slabs: 820872, objs: 34476624, free: 0
[10220.939263] dump_stack+0x5a/0x73
[10220.939265] warn_alloc+0x103/0x190
[10220.939267] ? wake_all_kswapds+0x54/0x8b
[10220.939268] __alloc_pages_slowpath+0x86c/0xa2e
[10220.939270] ? __alloc_pages_nodemask+0x2fe/0x320
[10220.939271] __alloc_pages_nodemask+0x2fe/0x320
[10220.939273] new_slab+0x475/0x550
[10220.939275] ___slab_alloc+0x36c/0x520
[10220.939287] ? hfi1_make_rc_req+0x90/0x18b0 [hfi1]
[10220.939299] ? __get_txreq+0x54/0x160 [hfi1]
[10220.939310] ? hfi1_make_rc_req+0x90/0x18b0 [hfi1]
[10220.939312] __slab_alloc+0x40/0x61
[10220.939323] ? hfi1_make_rc_req+0x90/0x18b0 [hfi1]
[10220.939325] kmem_cache_alloc+0x181/0x1b0
[10220.939336] hfi1_make_rc_req+0x90/0x18b0 [hfi1]
[10220.939348] ? hfi1_verbs_send_dma+0x386/0xa10 [hfi1]
[10220.939359] ? find_prev_entry+0xb0/0xb0 [hfi1]
[10220.939371] hfi1_do_send+0x1d9/0x3f0 [hfi1]
[10220.939372] process_one_work+0x171/0x380
[10220.939374] worker_thread+0x49/0x3f0
[10220.939375] kthread+0xf8/0x130
[10220.939377] ? max_active_store+0x80/0x80
[10220.939378] ? kthread_bind+0x10/0x10
[10220.939379] ret_from_fork+0x35/0x40
[10220.939381] SLUB: Unable to allocate memory on node -1, gfp=0xa20(GFP_ATOMIC)
The shortage is handled properly so the message isn't needed. Silence by
adding the no warn option to the slab allocation.
Fixes: 45842abbb2
("staging/rdma/hfi1: move txreq header code")
Cc: <stable@vger.kernel.org>
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
127 lines
4.0 KiB
C
127 lines
4.0 KiB
C
/*
|
|
* Copyright(c) 2016 - 2018 Intel Corporation.
|
|
*
|
|
* This file is provided under a dual BSD/GPLv2 license. When using or
|
|
* redistributing this file, you may do so under either license.
|
|
*
|
|
* GPL LICENSE SUMMARY
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of version 2 of the GNU General Public License as
|
|
* published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* BSD LICENSE
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
*
|
|
* - Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* - Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in
|
|
* the documentation and/or other materials provided with the
|
|
* distribution.
|
|
* - Neither the name of Intel Corporation nor the names of its
|
|
* contributors may be used to endorse or promote products derived
|
|
* from this software without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
|
|
* "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
|
|
* LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
|
|
* A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
|
|
* OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
|
|
* LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*
|
|
*/
|
|
|
|
#ifndef HFI1_VERBS_TXREQ_H
|
|
#define HFI1_VERBS_TXREQ_H
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/slab.h>
|
|
|
|
#include "verbs.h"
|
|
#include "sdma_txreq.h"
|
|
#include "iowait.h"
|
|
|
|
struct verbs_txreq {
|
|
struct hfi1_sdma_header phdr;
|
|
struct sdma_txreq txreq;
|
|
struct rvt_qp *qp;
|
|
struct rvt_swqe *wqe;
|
|
struct rvt_mregion *mr;
|
|
struct rvt_sge_state *ss;
|
|
struct sdma_engine *sde;
|
|
struct send_context *psc;
|
|
u16 hdr_dwords;
|
|
u16 s_cur_size;
|
|
};
|
|
|
|
struct hfi1_ibdev;
|
|
struct verbs_txreq *__get_txreq(struct hfi1_ibdev *dev,
|
|
struct rvt_qp *qp);
|
|
|
|
#define VERBS_TXREQ_GFP (GFP_ATOMIC | __GFP_NOWARN)
|
|
static inline struct verbs_txreq *get_txreq(struct hfi1_ibdev *dev,
|
|
struct rvt_qp *qp)
|
|
__must_hold(&qp->slock)
|
|
{
|
|
struct verbs_txreq *tx;
|
|
struct hfi1_qp_priv *priv = qp->priv;
|
|
|
|
tx = kmem_cache_alloc(dev->verbs_txreq_cache, VERBS_TXREQ_GFP);
|
|
if (unlikely(!tx)) {
|
|
/* call slow path to get the lock */
|
|
tx = __get_txreq(dev, qp);
|
|
if (!tx)
|
|
return tx;
|
|
}
|
|
tx->qp = qp;
|
|
tx->mr = NULL;
|
|
tx->sde = priv->s_sde;
|
|
tx->psc = priv->s_sendcontext;
|
|
/* so that we can test if the sdma decriptors are there */
|
|
tx->txreq.num_desc = 0;
|
|
/* Set the header type */
|
|
tx->phdr.hdr.hdr_type = priv->hdr_type;
|
|
tx->txreq.flags = 0;
|
|
return tx;
|
|
}
|
|
|
|
static inline struct sdma_txreq *get_sdma_txreq(struct verbs_txreq *tx)
|
|
{
|
|
return &tx->txreq;
|
|
}
|
|
|
|
static inline struct verbs_txreq *get_waiting_verbs_txreq(struct iowait_work *w)
|
|
{
|
|
struct sdma_txreq *stx;
|
|
|
|
stx = iowait_get_txhead(w);
|
|
if (stx)
|
|
return container_of(stx, struct verbs_txreq, txreq);
|
|
return NULL;
|
|
}
|
|
|
|
static inline bool verbs_txreq_queued(struct iowait_work *w)
|
|
{
|
|
return iowait_packet_queued(w);
|
|
}
|
|
|
|
void hfi1_put_txreq(struct verbs_txreq *tx);
|
|
int verbs_txreq_init(struct hfi1_ibdev *dev);
|
|
void verbs_txreq_exit(struct hfi1_ibdev *dev);
|
|
|
|
#endif /* HFI1_VERBS_TXREQ_H */
|