mirror of
https://github.com/torvalds/linux.git
synced 2024-11-30 08:01:59 +00:00
bf2b59f60e
The arm64 page table dump code can race with concurrent modification of the kernel page tables. When a leaf entries are modified concurrently, the dump code may log stale or inconsistent information for a VA range, but this is otherwise not harmful. When intermediate levels of table are freed, the dump code will continue to use memory which has been freed and potentially reallocated for another purpose. In such cases, the dump code may dereference bogus addresses, leading to a number of potential problems. Intermediate levels of table may by freed during memory hot-remove, which will be enabled by a subsequent patch. To avoid racing with this, take the memory hotplug lock when walking the kernel page table. Acked-by: David Hildenbrand <david@redhat.com> Acked-by: Mark Rutland <mark.rutland@arm.com> Acked-by: Catalin Marinas <catalin.marinas@arm.com> Reviewed-by: Steven Price <steven.price@arm.com> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
23 lines
491 B
C
23 lines
491 B
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include <linux/debugfs.h>
|
|
#include <linux/memory_hotplug.h>
|
|
#include <linux/seq_file.h>
|
|
|
|
#include <asm/ptdump.h>
|
|
|
|
static int ptdump_show(struct seq_file *m, void *v)
|
|
{
|
|
struct ptdump_info *info = m->private;
|
|
|
|
get_online_mems();
|
|
ptdump_walk(m, info);
|
|
put_online_mems();
|
|
return 0;
|
|
}
|
|
DEFINE_SHOW_ATTRIBUTE(ptdump);
|
|
|
|
void ptdump_debugfs_register(struct ptdump_info *info, const char *name)
|
|
{
|
|
debugfs_create_file(name, 0400, NULL, info, &ptdump_fops);
|
|
}
|