linux/net/rds
Jason Gunthorpe 071ba4cc55 RDMA: Add rdma_connect_locked()
There are two flows for handling RDMA_CM_EVENT_ROUTE_RESOLVED, either the
handler triggers a completion and another thread does rdma_connect() or
the handler directly calls rdma_connect().

In all cases rdma_connect() needs to hold the handler_mutex, but when
handler's are invoked this is already held by the core code. This causes
ULPs using the 2nd method to deadlock.

Provide a rdma_connect_locked() and have all ULPs call it from their
handlers.

Link: https://lore.kernel.org/r/0-v2-53c22d5c1405+33-rdma_connect_locking_jgg@nvidia.com
Reported-and-tested-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
Fixes: 2a7cec5381 ("RDMA/cma: Fix locking for the RDMA_CM_CONNECT state")
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Acked-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
2020-10-28 09:14:49 -03:00
..
af_rds.c net: pass a sockptr_t into ->setsockopt 2020-07-24 15:41:54 -07:00
bind.c
cong.c net: rds: delete duplicated words 2020-09-18 14:12:43 -07:00
connection.c rds: If one path needs re-connection, check all and re-connect 2020-07-01 17:35:17 -07:00
ib_cm.c RDMA: Add rdma_connect_locked() 2020-10-28 09:14:49 -03:00
ib_frmr.c RDMA/rds: Remove FMR support for memory registration 2020-06-02 20:32:53 -03:00
ib_mr.h RDMA/rds: Remove FMR support for memory registration 2020-06-02 20:32:53 -03:00
ib_rdma.c RDMA/rds: Remove FMR support for memory registration 2020-06-02 20:32:53 -03:00
ib_recv.c net/rds: suppress page allocation failure error in recv buffer refill 2020-10-09 12:32:03 -07:00
ib_ring.c
ib_send.c
ib_stats.c
ib_sysctl.c
ib.c RDMA: Remove 'max_fmr' 2020-06-02 20:32:54 -03:00
ib.h net/rds: NULL pointer de-reference in rds_ib_add_one() 2020-06-15 12:58:59 -07:00
info.c rds: fix crash in rds_info_getsockopt() 2020-05-20 14:08:06 -07:00
info.h
Kconfig treewide: replace '---help---' in Kconfig files with 'help' 2020-06-14 01:57:21 +09:00
loop.c
loop.h
Makefile RDMA/rds: Remove FMR support for memory registration 2020-06-02 20:32:53 -03:00
message.c
page.c
rdma_transport.c
rdma_transport.h net: rds: rdma_transport.h: delete duplicated word 2020-07-19 18:14:51 -07:00
rdma.c RDS: drop double zeroing 2020-09-20 19:09:11 -07:00
rds_single_path.h
rds.h net: pass a sockptr_t into ->setsockopt 2020-07-24 15:41:54 -07:00
recv.c rds: Prevent kernel-infoleak in rds_notify_queue_get() 2020-07-31 16:52:48 -07:00
send.c treewide: Use fallthrough pseudo-keyword 2020-08-23 17:36:59 -05:00
stats.c
sysctl.c
tcp_connect.c net: add sock_no_linger 2020-05-28 11:11:44 -07:00
tcp_listen.c tcp: add tcp_sock_set_keepcnt 2020-05-28 11:11:45 -07:00
tcp_recv.c
tcp_send.c tcp: add tcp_sock_set_cork 2020-05-28 11:11:45 -07:00
tcp_stats.c
tcp.c tcp: add tcp_sock_set_nodelay 2020-05-28 11:11:45 -07:00
tcp.h tcp: add tcp_sock_set_keepcnt 2020-05-28 11:11:45 -07:00
threads.c
transport.c rds: transport module should be auto loaded when transport is set 2020-06-25 16:26:25 -07:00