Jakub Kicinski 9188d5ca45 net/tls: fix refcount adjustment in fallback ... Unlike atomic_add(), refcount_add() does not deal well with a negative argument. TLS fallback code reallocates the skb and is very likely to shrink the truesize, leading to: [ 189.513254] WARNING: CPU: 5 PID: 0 at lib/refcount.c:81 refcount_add_not_zero_checked+0x15c/0x180 Call Trace: refcount_add_checked+0x6/0x40 tls_enc_skb+0xb93/0x13e0 [tls] Once wmem_allocated count saturates the application can no longer send data on the socket. This is similar to Eric's fixes for GSO, TCP: commit 7ec318feee ("tcp: gso: avoid refcount_t warning from tcp_gso_segment()") and UDP: commit 575b65bc5b ("udp: avoid refcount_t saturation in __udp_gso_segment()"). Unlike the GSO case, for TLS fallback it's likely that the skb has shrunk, so the "likely" annotation is the other way around (likely branch being "sub"). Fixes: e8f6979981 ("net/tls: Add generic NIC offload infrastructure") Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com> Reviewed-by: John Hurley <john.hurley@netronome.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-04-18 16:51:03 -07:00
..
Kconfig	tls: convert to generic sk_msg interface	2018-10-15 12:23:19 -07:00
Makefile	net/tls: Add generic NIC offload infrastructure	2018-05-01 09:42:47 -04:00
tls_device_fallback.c	net/tls: fix refcount adjustment in fallback	2019-04-18 16:51:03 -07:00
tls_device.c	net/tls: don't leak partially sent record in device mode	2019-04-10 13:07:02 -07:00
tls_main.c	net/tls: fix build without CONFIG_TLS_DEVICE	2019-04-10 17:23:26 -07:00
tls_sw.c	net/tls: don't leak partially sent record in device mode	2019-04-10 13:07:02 -07:00