mirror of
https://github.com/torvalds/linux.git
synced 2024-12-01 08:31:37 +00:00
89f579ce99
When building the kernel with W=1 we get a lot of -Wmissing-prototypes warnings, which are trivial in nature and easy to fix - and which may mask some real future bugs if the prototypes get out of sync with the function definition. This patch fixes most of -Wmissing-prototypes warnings which are in the root directory of arch/x86/kernel, not including the subdirectories. These are the warnings fixed in this patch: arch/x86/kernel/signal.c:865:17: warning: no previous prototype for ‘sys32_x32_rt_sigreturn’ [-Wmissing-prototypes] arch/x86/kernel/signal_compat.c:164:6: warning: no previous prototype for ‘sigaction_compat_abi’ [-Wmissing-prototypes] arch/x86/kernel/traps.c:625:46: warning: no previous prototype for ‘sync_regs’ [-Wmissing-prototypes] arch/x86/kernel/traps.c:640:24: warning: no previous prototype for ‘fixup_bad_iret’ [-Wmissing-prototypes] arch/x86/kernel/traps.c:929:13: warning: no previous prototype for ‘trap_init’ [-Wmissing-prototypes] arch/x86/kernel/irq.c:270:28: warning: no previous prototype for ‘smp_x86_platform_ipi’ [-Wmissing-prototypes] arch/x86/kernel/irq.c:301:16: warning: no previous prototype for ‘smp_kvm_posted_intr_ipi’ [-Wmissing-prototypes] arch/x86/kernel/irq.c:314:16: warning: no previous prototype for ‘smp_kvm_posted_intr_wakeup_ipi’ [-Wmissing-prototypes] arch/x86/kernel/irq.c:328:16: warning: no previous prototype for ‘smp_kvm_posted_intr_nested_ipi’ [-Wmissing-prototypes] arch/x86/kernel/irq_work.c:16:28: warning: no previous prototype for ‘smp_irq_work_interrupt’ [-Wmissing-prototypes] arch/x86/kernel/irqinit.c:79:13: warning: no previous prototype for ‘init_IRQ’ [-Wmissing-prototypes] arch/x86/kernel/quirks.c:672:13: warning: no previous prototype for ‘early_platform_quirks’ [-Wmissing-prototypes] arch/x86/kernel/tsc.c:1499:15: warning: no previous prototype for ‘calibrate_delay_is_known’ [-Wmissing-prototypes] arch/x86/kernel/process.c:653:13: warning: no previous prototype for ‘arch_post_acpi_subsys_init’ [-Wmissing-prototypes] arch/x86/kernel/process.c:717:15: warning: no previous prototype for ‘arch_randomize_brk’ [-Wmissing-prototypes] arch/x86/kernel/process.c:784:6: warning: no previous prototype for ‘do_arch_prctl_common’ [-Wmissing-prototypes] arch/x86/kernel/reboot.c:869:6: warning: no previous prototype for ‘nmi_panic_self_stop’ [-Wmissing-prototypes] arch/x86/kernel/smp.c:176:27: warning: no previous prototype for ‘smp_reboot_interrupt’ [-Wmissing-prototypes] arch/x86/kernel/smp.c:260:28: warning: no previous prototype for ‘smp_reschedule_interrupt’ [-Wmissing-prototypes] arch/x86/kernel/smp.c:281:28: warning: no previous prototype for ‘smp_call_function_interrupt’ [-Wmissing-prototypes] arch/x86/kernel/smp.c:291:28: warning: no previous prototype for ‘smp_call_function_single_interrupt’ [-Wmissing-prototypes] arch/x86/kernel/ftrace.c:840:6: warning: no previous prototype for ‘arch_ftrace_update_trampoline’ [-Wmissing-prototypes] arch/x86/kernel/ftrace.c:934:7: warning: no previous prototype for ‘arch_ftrace_trampoline_func’ [-Wmissing-prototypes] arch/x86/kernel/ftrace.c:946:6: warning: no previous prototype for ‘arch_ftrace_trampoline_free’ [-Wmissing-prototypes] arch/x86/kernel/crash.c:114:6: warning: no previous prototype for ‘crash_smp_send_stop’ [-Wmissing-prototypes] arch/x86/kernel/crash.c:351:5: warning: no previous prototype for ‘crash_setup_memmap_entries’ [-Wmissing-prototypes] arch/x86/kernel/crash.c:424:5: warning: no previous prototype for ‘crash_load_segments’ [-Wmissing-prototypes] arch/x86/kernel/machine_kexec_64.c:372:7: warning: no previous prototype for ‘arch_kexec_kernel_image_load’ [-Wmissing-prototypes] arch/x86/kernel/paravirt-spinlocks.c:12:16: warning: no previous prototype for ‘__native_queued_spin_unlock’ [-Wmissing-prototypes] arch/x86/kernel/paravirt-spinlocks.c:18:6: warning: no previous prototype for ‘pv_is_native_spin_unlock’ [-Wmissing-prototypes] arch/x86/kernel/paravirt-spinlocks.c:24:16: warning: no previous prototype for ‘__native_vcpu_is_preempted’ [-Wmissing-prototypes] arch/x86/kernel/paravirt-spinlocks.c:30:6: warning: no previous prototype for ‘pv_is_native_vcpu_is_preempted’ [-Wmissing-prototypes] arch/x86/kernel/kvm.c:258:1: warning: no previous prototype for ‘do_async_page_fault’ [-Wmissing-prototypes] arch/x86/kernel/jailhouse.c:200:6: warning: no previous prototype for ‘jailhouse_paravirt’ [-Wmissing-prototypes] arch/x86/kernel/check.c:91:13: warning: no previous prototype for ‘setup_bios_corruption_check’ [-Wmissing-prototypes] arch/x86/kernel/check.c:139:6: warning: no previous prototype for ‘check_for_bios_corruption’ [-Wmissing-prototypes] arch/x86/kernel/devicetree.c:32:13: warning: no previous prototype for ‘early_init_dt_scan_chosen_arch’ [-Wmissing-prototypes] arch/x86/kernel/devicetree.c:42:13: warning: no previous prototype for ‘add_dtb’ [-Wmissing-prototypes] arch/x86/kernel/devicetree.c:108:6: warning: no previous prototype for ‘x86_of_pci_init’ [-Wmissing-prototypes] arch/x86/kernel/devicetree.c:314:13: warning: no previous prototype for ‘x86_dtb_init’ [-Wmissing-prototypes] arch/x86/kernel/tracepoint.c:16:5: warning: no previous prototype for ‘trace_pagefault_reg’ [-Wmissing-prototypes] arch/x86/kernel/tracepoint.c:22:6: warning: no previous prototype for ‘trace_pagefault_unreg’ [-Wmissing-prototypes] arch/x86/kernel/head64.c:113:22: warning: no previous prototype for ‘__startup_64’ [-Wmissing-prototypes] arch/x86/kernel/head64.c:262:15: warning: no previous prototype for ‘__startup_secondary_64’ [-Wmissing-prototypes] arch/x86/kernel/head64.c:350:12: warning: no previous prototype for ‘early_make_pgtable’ [-Wmissing-prototypes] [ mingo: rewrote the changelog, fixed build errors. ] Signed-off-by: Yi Wang <wang.yi59@zte.com.cn> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: akataria@vmware.com Cc: akpm@linux-foundation.org Cc: andy.shevchenko@gmail.com Cc: anton@enomsg.org Cc: ard.biesheuvel@linaro.org Cc: bhe@redhat.com Cc: bhelgaas@google.com Cc: bp@alien8.de Cc: ccross@android.com Cc: devicetree@vger.kernel.org Cc: douly.fnst@cn.fujitsu.com Cc: dwmw@amazon.co.uk Cc: dyoung@redhat.com Cc: ebiederm@xmission.com Cc: frank.rowand@sony.com Cc: frowand.list@gmail.com Cc: ivan.gorinov@intel.com Cc: jailhouse-dev@googlegroups.com Cc: jan.kiszka@siemens.com Cc: jgross@suse.com Cc: jroedel@suse.de Cc: keescook@chromium.org Cc: kexec@lists.infradead.org Cc: konrad.wilk@oracle.com Cc: kvm@vger.kernel.org Cc: linux-efi@vger.kernel.org Cc: linux-pci@vger.kernel.org Cc: luto@kernel.org Cc: m.mizuma@jp.fujitsu.com Cc: namit@vmware.com Cc: oleg@redhat.com Cc: pasha.tatashin@oracle.com Cc: pbonzini@redhat.com Cc: prarit@redhat.com Cc: pravin.shedge4linux@gmail.com Cc: rajvi.jingar@intel.com Cc: rkrcmar@redhat.com Cc: robh+dt@kernel.org Cc: robh@kernel.org Cc: rostedt@goodmis.org Cc: takahiro.akashi@linaro.org Cc: thomas.lendacky@amd.com Cc: tony.luck@intel.com Cc: up2wing@gmail.com Cc: virtualization@lists.linux-foundation.org Cc: zhe.he@windriver.com Cc: zhong.weidong@zte.com.cn Link: http://lkml.kernel.org/r/1542852249-19820-1-git-send-email-wang.yi59@zte.com.cn Signed-off-by: Ingo Molnar <mingo@kernel.org>
188 lines
4.2 KiB
C
188 lines
4.2 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
|
|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
|
|
|
#include <linux/init.h>
|
|
#include <linux/sched.h>
|
|
#include <linux/kthread.h>
|
|
#include <linux/workqueue.h>
|
|
#include <linux/memblock.h>
|
|
|
|
#include <asm/proto.h>
|
|
#include <asm/setup.h>
|
|
|
|
/*
|
|
* Some BIOSes seem to corrupt the low 64k of memory during events
|
|
* like suspend/resume and unplugging an HDMI cable. Reserve all
|
|
* remaining free memory in that area and fill it with a distinct
|
|
* pattern.
|
|
*/
|
|
#define MAX_SCAN_AREAS 8
|
|
|
|
static int __read_mostly memory_corruption_check = -1;
|
|
|
|
static unsigned __read_mostly corruption_check_size = 64*1024;
|
|
static unsigned __read_mostly corruption_check_period = 60; /* seconds */
|
|
|
|
static struct scan_area {
|
|
u64 addr;
|
|
u64 size;
|
|
} scan_areas[MAX_SCAN_AREAS];
|
|
static int num_scan_areas;
|
|
|
|
static __init int set_corruption_check(char *arg)
|
|
{
|
|
ssize_t ret;
|
|
unsigned long val;
|
|
|
|
if (!arg) {
|
|
pr_err("memory_corruption_check config string not provided\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
ret = kstrtoul(arg, 10, &val);
|
|
if (ret)
|
|
return ret;
|
|
|
|
memory_corruption_check = val;
|
|
|
|
return 0;
|
|
}
|
|
early_param("memory_corruption_check", set_corruption_check);
|
|
|
|
static __init int set_corruption_check_period(char *arg)
|
|
{
|
|
ssize_t ret;
|
|
unsigned long val;
|
|
|
|
if (!arg) {
|
|
pr_err("memory_corruption_check_period config string not provided\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
ret = kstrtoul(arg, 10, &val);
|
|
if (ret)
|
|
return ret;
|
|
|
|
corruption_check_period = val;
|
|
return 0;
|
|
}
|
|
early_param("memory_corruption_check_period", set_corruption_check_period);
|
|
|
|
static __init int set_corruption_check_size(char *arg)
|
|
{
|
|
char *end;
|
|
unsigned size;
|
|
|
|
if (!arg) {
|
|
pr_err("memory_corruption_check_size config string not provided\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
size = memparse(arg, &end);
|
|
|
|
if (*end == '\0')
|
|
corruption_check_size = size;
|
|
|
|
return (size == corruption_check_size) ? 0 : -EINVAL;
|
|
}
|
|
early_param("memory_corruption_check_size", set_corruption_check_size);
|
|
|
|
|
|
void __init setup_bios_corruption_check(void)
|
|
{
|
|
phys_addr_t start, end;
|
|
u64 i;
|
|
|
|
if (memory_corruption_check == -1) {
|
|
memory_corruption_check =
|
|
#ifdef CONFIG_X86_BOOTPARAM_MEMORY_CORRUPTION_CHECK
|
|
1
|
|
#else
|
|
0
|
|
#endif
|
|
;
|
|
}
|
|
|
|
if (corruption_check_size == 0)
|
|
memory_corruption_check = 0;
|
|
|
|
if (!memory_corruption_check)
|
|
return;
|
|
|
|
corruption_check_size = round_up(corruption_check_size, PAGE_SIZE);
|
|
|
|
for_each_free_mem_range(i, NUMA_NO_NODE, MEMBLOCK_NONE, &start, &end,
|
|
NULL) {
|
|
start = clamp_t(phys_addr_t, round_up(start, PAGE_SIZE),
|
|
PAGE_SIZE, corruption_check_size);
|
|
end = clamp_t(phys_addr_t, round_down(end, PAGE_SIZE),
|
|
PAGE_SIZE, corruption_check_size);
|
|
if (start >= end)
|
|
continue;
|
|
|
|
memblock_reserve(start, end - start);
|
|
scan_areas[num_scan_areas].addr = start;
|
|
scan_areas[num_scan_areas].size = end - start;
|
|
|
|
/* Assume we've already mapped this early memory */
|
|
memset(__va(start), 0, end - start);
|
|
|
|
if (++num_scan_areas >= MAX_SCAN_AREAS)
|
|
break;
|
|
}
|
|
|
|
if (num_scan_areas)
|
|
pr_info("Scanning %d areas for low memory corruption\n", num_scan_areas);
|
|
}
|
|
|
|
|
|
static void check_for_bios_corruption(void)
|
|
{
|
|
int i;
|
|
int corruption = 0;
|
|
|
|
if (!memory_corruption_check)
|
|
return;
|
|
|
|
for (i = 0; i < num_scan_areas; i++) {
|
|
unsigned long *addr = __va(scan_areas[i].addr);
|
|
unsigned long size = scan_areas[i].size;
|
|
|
|
for (; size; addr++, size -= sizeof(unsigned long)) {
|
|
if (!*addr)
|
|
continue;
|
|
pr_err("Corrupted low memory at %p (%lx phys) = %08lx\n", addr, __pa(addr), *addr);
|
|
corruption = 1;
|
|
*addr = 0;
|
|
}
|
|
}
|
|
|
|
WARN_ONCE(corruption, KERN_ERR "Memory corruption detected in low memory\n");
|
|
}
|
|
|
|
static void check_corruption(struct work_struct *dummy);
|
|
static DECLARE_DELAYED_WORK(bios_check_work, check_corruption);
|
|
|
|
static void check_corruption(struct work_struct *dummy)
|
|
{
|
|
check_for_bios_corruption();
|
|
schedule_delayed_work(&bios_check_work,
|
|
round_jiffies_relative(corruption_check_period*HZ));
|
|
}
|
|
|
|
static int start_periodic_check_for_corruption(void)
|
|
{
|
|
if (!num_scan_areas || !memory_corruption_check || corruption_check_period == 0)
|
|
return 0;
|
|
|
|
pr_info("Scanning for low memory corruption every %d seconds\n", corruption_check_period);
|
|
|
|
/* First time we run the checks right away */
|
|
schedule_delayed_work(&bios_check_work, 0);
|
|
|
|
return 0;
|
|
}
|
|
device_initcall(start_periodic_check_for_corruption);
|
|
|