Alexandru Elisei 8f11fe7e40 Revert "usb: dwc3: core: Add shutdown callback for dwc3" ... This reverts commit 568262bf54. The commit causes the following panic when shutting down a rockpro64-v2 board: [..] [ 41.684569] xhci-hcd xhci-hcd.2.auto: USB bus 1 deregistered [ 41.686301] Unable to handle kernel NULL pointer dereference at virtual address 00000000000000a0 [ 41.687096] Mem abort info: [ 41.687345] ESR = 0x96000004 [ 41.687615] EC = 0x25: DABT (current EL), IL = 32 bits [ 41.688082] SET = 0, FnV = 0 [ 41.688352] EA = 0, S1PTW = 0 [ 41.688628] Data abort info: [ 41.688882] ISV = 0, ISS = 0x00000004 [ 41.689219] CM = 0, WnR = 0 [ 41.689481] user pgtable: 4k pages, 48-bit VAs, pgdp=00000000073b2000 [ 41.690046] [00000000000000a0] pgd=0000000000000000, p4d=0000000000000000 [ 41.690654] Internal error: Oops: 96000004 [#1] PREEMPT SMP [ 41.691143] Modules linked in: [ 41.691416] CPU: 5 PID: 1 Comm: shutdown Not tainted 5.13.0-rc4 #43 [ 41.691966] Hardware name: Pine64 RockPro64 v2.0 (DT) [ 41.692409] pstate: 60000005 (nZCv daif -PAN -UAO -TCO BTYPE=--) [ 41.692937] pc : down_read_interruptible+0xec/0x200 [ 41.693373] lr : simple_recursive_removal+0x48/0x280 [ 41.693815] sp : ffff800011fab910 [ 41.694107] x29: ffff800011fab910 x28: ffff0000008fe480 x27: ffff0000008fe4d8 [ 41.694736] x26: ffff800011529a90 x25: 00000000000000a0 x24: ffff800011edd030 [ 41.695364] x23: 0000000000000080 x22: 0000000000000000 x21: ffff800011f23994 [ 41.695992] x20: ffff800011f23998 x19: ffff0000008fe480 x18: ffffffffffffffff [ 41.696620] x17: 000c0400bb44ffff x16: 0000000000000009 x15: ffff800091faba3d [ 41.697248] x14: 0000000000000004 x13: 0000000000000000 x12: 0000000000000020 [ 41.697875] x11: 0101010101010101 x10: 7f7f7f7f7f7f7f7f x9 : 6f6c746364716e62 [ 41.698502] x8 : 7f7f7f7f7f7f7f7f x7 : fefefeff6364626d x6 : 0000000000000440 [ 41.699130] x5 : 0000000000000000 x4 : 0000000000000000 x3 : 00000000000000a0 [ 41.699758] x2 : 0000000000000001 x1 : 0000000000000000 x0 : 00000000000000a0 [ 41.700386] Call trace: [ 41.700602] down_read_interruptible+0xec/0x200 [ 41.701003] debugfs_remove+0x5c/0x80 [ 41.701328] dwc3_debugfs_exit+0x1c/0x6c [ 41.701676] dwc3_remove+0x34/0x1a0 [ 41.701988] platform_remove+0x28/0x60 [ 41.702322] __device_release_driver+0x188/0x22c [ 41.702730] device_release_driver+0x2c/0x44 [ 41.703106] bus_remove_device+0x124/0x130 [ 41.703468] device_del+0x16c/0x424 [ 41.703777] platform_device_del.part.0+0x1c/0x90 [ 41.704193] platform_device_unregister+0x28/0x44 [ 41.704608] of_platform_device_destroy+0xe8/0x100 [ 41.705031] device_for_each_child_reverse+0x64/0xb4 [ 41.705470] of_platform_depopulate+0x40/0x84 [ 41.705853] __dwc3_of_simple_teardown+0x20/0xd4 [ 41.706260] dwc3_of_simple_shutdown+0x14/0x20 [ 41.706652] platform_shutdown+0x28/0x40 [ 41.706998] device_shutdown+0x158/0x330 [ 41.707344] kernel_power_off+0x38/0x7c [ 41.707684] __do_sys_reboot+0x16c/0x2a0 [ 41.708029] __arm64_sys_reboot+0x28/0x34 [ 41.708383] invoke_syscall+0x48/0x114 [ 41.708716] el0_svc_common.constprop.0+0x44/0xdc [ 41.709131] do_el0_svc+0x28/0x90 [ 41.709426] el0_svc+0x2c/0x54 [ 41.709698] el0_sync_handler+0xa4/0x130 [ 41.710045] el0_sync+0x198/0x1c0 [ 41.710342] Code: c8047c62 35ffff84 17fffe5f f9800071 (c85ffc60) [ 41.710881] ---[ end trace 406377df5178f75c ]--- [ 41.711299] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b [ 41.712084] Kernel Offset: disabled [ 41.712391] CPU features: 0x10001031,20000846 [ 41.712775] Memory Limit: none [ 41.713049] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b ]--- As Felipe explained: "dwc3_shutdown() is just called dwc3_remove() directly, then we end up calling debugfs_remove_recursive() twice." Reverting the commit fixes the panic. Fixes: 568262bf54 ("usb: dwc3: core: Add shutdown callback for dwc3") Acked-by: Felipe Balbi <balbi@kernel.org> Signed-off-by: Alexandru Elisei <alexandru.elisei@arm.com> Link: https://lore.kernel.org/r/20210603151742.298243-1-alexandru.elisei@arm.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2021-06-04 10:40:57 +02:00
..
accessibility	TTY/Serial driver updates for 5.13-rc1	2021-04-26 11:20:10 -07:00
acpi	TTY / Serial driver fixes for 5.13-rc4	2021-05-29 06:25:16 -10:00
amba
android	binder: Return EFAULT if we fail BINDER_ENABLE_ONEWAY_SPAM_DETECTION	2021-05-13 20:35:26 +02:00
ata	pci-v5.13-changes	2021-05-05 13:24:11 -07:00
atm	atm: firestream: Use fallthrough pseudo-keyword	2021-05-07 16:01:08 -07:00
auxdisplay	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
base	drivers: base: Reduce device link removal code duplication	2021-05-21 22:12:14 +02:00
bcma	bcma: remove unused function	2021-04-18 09:36:56 +03:00
block	block-5.13-2021-05-14	2021-05-15 08:52:30 -07:00
bluetooth	Networking changes for 5.13.	2021-04-29 11:57:23 -07:00
bus	ARM: SoC drivers for v5.13	2021-04-26 12:11:52 -07:00
cdrom	cdrom: gdrom: initialize global variable at init time	2021-05-13 18:58:44 +02:00
char	Char/misc driver fixes for 5.13-rc3	2021-05-20 06:31:52 -10:00
clk	clk: Skip clk provider registration when np is NULL	2021-05-11 08:47:25 +02:00
clocksource	clocksource/drivers/hyper-v: Re-enable VDSO_CLOCKMODE_HVCLOCK on X86	2021-05-14 14:55:13 +02:00
comedi	staging: comedi: move out of staging directory	2021-04-15 09:26:25 +02:00
connector
counter
cpufreq	Fix an idle CPU selection bug, and an AMD Ryzen maximum frequency enumeration bug.	2021-05-15 10:24:48 -07:00
cpuidle
crypto	Revert "crypto: cavium/nitrox - add an error message to explain the failure of pci_request_mem_regions"	2021-05-13 17:23:05 +02:00
cxl	cxl/mem: Fix memory device capacity probing	2021-04-16 18:21:56 -07:00
dax
dca
devfreq
dio
dma	dmaengine: qcom_hidma: comment platform_driver_register call	2021-05-13 18:32:29 +02:00
dma-buf	dma-buf: fix unintended pin/unpin warnings	2021-05-20 14:02:27 +02:00
edac	x86/msr: Rename MSR_K8_SYSCFG to MSR_AMD64_SYSCFG	2021-05-10 07:51:38 +02:00
eisa
extcon	- Core Frameworks	2021-04-28 15:59:13 -07:00
firewire	The usual updates from the irq departement:	2021-04-26 09:43:16 -07:00
firmware	ARM: SoC fixes for 5.13	2021-05-20 14:46:26 -10:00
fpga	ARM: SoC drivers for v5.13	2021-04-26 12:11:52 -07:00
fsi
gnss
gpio	gpio: tegra186: Don't set parent IRQ affinity	2021-05-12 13:56:43 +02:00
gpu	Merge tag 'drm-intel-fixes-2021-05-27' of ssh://git.freedesktop.org/git/drm/drm-intel into drm-fixes	2021-05-28 13:28:18 +10:00
greybus	greybus: es2: fix kernel-doc warnings	2021-04-16 07:26:50 +02:00
hid	Merge branch 'for-5.13/warnings' into for-linus	2021-04-29 21:47:22 +02:00
hsi	HSI: core: fix resource leaks in hsi_add_client_from_dt()	2021-04-16 00:14:49 +02:00
hv	printk changes for 5.13	2021-04-27 18:09:44 -07:00
hwmon	Char/misc driver fixes for 5.13-rc3	2021-05-20 06:31:52 -10:00
hwspinlock
hwtracing	ARM:	2021-05-01 10:14:08 -07:00
i2c	i2c: s3c2410: fix possible NULL pointer deref on read message after write	2021-05-28 10:16:23 +02:00
i3c	Revert "i3c master: fix missing destroy_workqueue() on error in i3c_master_register"	2021-04-24 22:21:01 +02:00
ide
idle
iio	iio: adc: ad7793: Add missing error code in ad7793_setup()	2021-05-22 08:32:36 +01:00
infiniband	Networking fixes for 5.13-rc4, including fixes from bpf, netfilter,	2021-05-26 17:44:49 -10:00
input	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input	2021-05-06 23:37:55 -07:00
interconnect	interconnect: qcom: Add missing MODULE_DEVICE_TABLE	2021-05-11 07:26:31 +03:00
iommu	iommu/vt-d: Fix sysfs leak in alloc_iommu()	2021-05-27 16:07:08 +02:00
ipack
irqchip	irqchip: Remove redundant error printing	2021-05-16 13:07:18 +01:00
isdn	Networking fixes for 5.13-rc4, including fixes from bpf, netfilter,	2021-05-26 17:44:49 -10:00
leds	leds: lp5523: check return value of lp5xx_read and jump to cleanup code	2021-05-13 17:30:15 +02:00
lightnvm	lightnvm: deprecated OCSSD support and schedule it for removal in Linux 5.15	2021-04-13 09:16:12 -06:00
macintosh	macintosh/via-pmu: Fix build warning	2021-04-16 23:57:51 +10:00
mailbox	- qcom: enable support for SM8350 and SC7280	2021-04-28 16:10:33 -07:00
mcb
md	block-5.13-2021-05-28	2021-05-28 14:42:37 -10:00
media	media: gspca: properly check for errors in po1030_probe()	2021-05-13 18:58:32 +02:00
memory	.gitignore: prefix local generated files with a slash	2021-05-02 00:43:35 +09:00
memstick	memstick: r592: ignore kfifo_out() return code again	2021-04-26 11:08:23 +02:00
message	scsi: message: fusion: Remove unused local variable 'vtarget'	2021-04-13 01:39:12 -04:00
mfd	- Core Frameworks	2021-04-28 15:59:13 -07:00
misc	Char/Misc driver fixes for 5.13-rc4	2021-05-29 06:41:50 -10:00
mmc	mmc: sdhci-pci-gli: increase 1.8V regulator wait	2021-05-10 14:39:06 +02:00
most	Staging/IIO driver updates for 5.13-rc1	2021-04-26 11:14:21 -07:00
mtd	mtd: parsers: ofpart: fix parsing subpartitions	2021-05-10 18:34:30 +02:00
mux
net	Networking fixes for 5.13-rc4, including fixes from bpf, netfilter,	2021-05-26 17:44:49 -10:00
nfc	NFC: nfcmrvl: fix kernel-doc syntax in file headers	2021-05-23 17:26:38 -07:00
ntb
nubus
nvdimm	include: remove pagemap.h from blkdev.h	2021-05-06 19:24:11 -07:00
nvme	nvmet: fix false keep-alive timeout when a controller is torn down	2021-05-26 16:18:22 +02:00
nvmem
of	of: overlay: Remove redundant assignment to ret	2021-05-03 13:57:56 -05:00
opp
parisc
parport	treewide: remove editor modelines and cruft	2021-05-07 00:26:34 -07:00
pci	more s390 updates for 5.13 merge window	2021-05-06 14:39:50 -07:00
pcmcia
perf	ARM:	2021-05-01 10:14:08 -07:00
phy	Networking changes for 5.13.	2021-04-29 11:57:23 -07:00
pinctrl	linux/kconfig.h: replace IF_ENABLED() with PTR_IF() in <linux/kernel.h>	2021-05-09 00:29:45 +09:00
platform	platform/x86: touchscreen_dmi: Add info for the Chuwi Hi10 Pro (CWI529) tablet	2021-05-20 14:11:03 +02:00
pnp
power	power supply and reset changes for the v5.13 series	2021-04-28 15:43:58 -07:00
powercap
pps	TTY/Serial driver updates for 5.13-rc1	2021-04-26 11:20:10 -07:00
ps3
ptp	ptp: ocp: Fix a resource leak in an error handling path	2021-05-12 14:06:33 -07:00
pwm	pwm: Changes for v5.13-rc1	2021-05-05 12:53:16 -07:00
rapidio	rapidio: handle create_workqueue() failure	2021-05-13 18:32:19 +02:00
ras
regulator	- Core Frameworks	2021-04-28 15:59:13 -07:00
remoteproc	remoteproc updates for v5.13	2021-05-04 11:13:33 -07:00
reset	pci-v5.13-changes	2021-05-05 13:24:11 -07:00
rpmsg
rtc	RTC for 5.13	2021-05-03 12:15:21 -07:00
s390	- Fix races in vfio-ccw request handling.	2021-05-29 05:51:53 -10:00
sbus
scsi	SCSI fixes on 20210528	2021-05-28 14:47:48 -10:00
sh	The usual updates from the irq departement:	2021-04-26 09:43:16 -07:00
siox
slimbus
soc	IOMMU Updates for Linux v5.13	2021-05-01 09:33:00 -07:00
soundwire	soundwire: qcom: fix handling of qcom,ports-block-pack-mode	2021-05-13 11:14:13 +05:30
spi	spi: sc18is602: implement .max_{transfer,message}_size() for the controller	2021-05-21 13:13:33 +01:00
spmi
ssb
staging	Second set of IIO fixes for the 5.13 cycle	2021-05-22 09:49:59 +02:00
target	scsi: target: iblock: Fix smp_processor_id() BUG messages	2021-05-21 16:40:00 -04:00
tc
tee	AMD-TEE reference count loaded TAs	2021-05-17 16:06:02 +02:00
thermal	thermal/drivers/qcom: Fix error code in adc_tm5_get_dt_channel_data()	2021-05-27 11:38:34 +02:00
thunderbolt	thunderbolt: usb4: Fix NVM read buffer bounds and offset issue	2021-05-20 11:52:58 +03:00
tty	TTY / Serial driver fixes for 5.13-rc4	2021-05-29 06:25:16 -10:00
uio	uio_hv_generic: Fix another memory leak in error handling paths	2021-05-14 13:26:04 +02:00
usb	Revert "usb: dwc3: core: Add shutdown callback for dwc3"	2021-06-04 10:40:57 +02:00
vdpa	{net,vdpa}/mlx5: Configure interface MAC into mpfs L2 table	2021-05-18 23:01:48 -07:00
vfio	IOMMU Updates for Linux v5.13	2021-05-01 09:33:00 -07:00
vhost	virtio,vhost,vdpa: features, fixes	2021-05-05 13:31:39 -07:00
video	video: hgafb: correctly handle card detect failure during probe	2021-05-21 15:04:05 +02:00
virt	nitro_enclaves: Fix stale file descriptors on failed usercopy	2021-04-29 19:06:49 +02:00
virtio	virtio_pci_modern: correct sparse tags for notify	2021-05-04 04:19:59 -04:00
visorbus
vlynq
vme
w1
watchdog	- Core Frameworks	2021-04-28 15:59:13 -07:00
xen	xen-pciback: reconfigure also from backend watch handler	2021-05-21 09:55:16 +02:00
zorro
Kconfig	staging: comedi: move out of staging directory	2021-04-15 09:26:25 +02:00
Makefile	virtio,vhost,vdpa: features, fixes	2021-05-05 13:31:39 -07:00