mirror of
https://github.com/torvalds/linux.git
synced 2024-12-14 23:25:54 +00:00
a56df73ba5
snd_rk_mc_probe() gets a couple of device nodes with of_parse_phandle(), but there is no release of them. The patch adds remove handler and proper error handling in the probe. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru> Signed-off-by: Mark Brown <broonie@kernel.org>
249 lines
6.2 KiB
C
249 lines
6.2 KiB
C
/*
|
|
* Rockchip machine ASoC driver for boards using a RT5645/RT5650 CODEC.
|
|
*
|
|
* Copyright (c) 2015, ROCKCHIP CORPORATION. All rights reserved.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms and conditions of the GNU General Public License,
|
|
* version 2, as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
|
|
* more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/gpio.h>
|
|
#include <linux/of_gpio.h>
|
|
#include <linux/delay.h>
|
|
#include <sound/core.h>
|
|
#include <sound/jack.h>
|
|
#include <sound/pcm.h>
|
|
#include <sound/pcm_params.h>
|
|
#include <sound/soc.h>
|
|
#include "rockchip_i2s.h"
|
|
#include "../codecs/rt5645.h"
|
|
|
|
#define DRV_NAME "rockchip-snd-rt5645"
|
|
|
|
static struct snd_soc_jack headset_jack;
|
|
|
|
static const struct snd_soc_dapm_widget rk_dapm_widgets[] = {
|
|
SND_SOC_DAPM_HP("Headphones", NULL),
|
|
SND_SOC_DAPM_SPK("Speakers", NULL),
|
|
SND_SOC_DAPM_MIC("Headset Mic", NULL),
|
|
SND_SOC_DAPM_MIC("Int Mic", NULL),
|
|
};
|
|
|
|
static const struct snd_soc_dapm_route rk_audio_map[] = {
|
|
/* Input Lines */
|
|
{"DMIC L2", NULL, "Int Mic"},
|
|
{"DMIC R2", NULL, "Int Mic"},
|
|
{"RECMIXL", NULL, "Headset Mic"},
|
|
{"RECMIXR", NULL, "Headset Mic"},
|
|
|
|
/* Output Lines */
|
|
{"Headphones", NULL, "HPOR"},
|
|
{"Headphones", NULL, "HPOL"},
|
|
{"Speakers", NULL, "SPOL"},
|
|
{"Speakers", NULL, "SPOR"},
|
|
};
|
|
|
|
static const struct snd_kcontrol_new rk_mc_controls[] = {
|
|
SOC_DAPM_PIN_SWITCH("Headphones"),
|
|
SOC_DAPM_PIN_SWITCH("Speakers"),
|
|
SOC_DAPM_PIN_SWITCH("Headset Mic"),
|
|
SOC_DAPM_PIN_SWITCH("Int Mic"),
|
|
};
|
|
|
|
static int rk_aif1_hw_params(struct snd_pcm_substream *substream,
|
|
struct snd_pcm_hw_params *params)
|
|
{
|
|
int ret = 0;
|
|
struct snd_soc_pcm_runtime *rtd = substream->private_data;
|
|
struct snd_soc_dai *cpu_dai = rtd->cpu_dai;
|
|
struct snd_soc_dai *codec_dai = rtd->codec_dai;
|
|
int mclk;
|
|
|
|
switch (params_rate(params)) {
|
|
case 8000:
|
|
case 16000:
|
|
case 24000:
|
|
case 32000:
|
|
case 48000:
|
|
case 64000:
|
|
case 96000:
|
|
mclk = 12288000;
|
|
break;
|
|
case 11025:
|
|
case 22050:
|
|
case 44100:
|
|
case 88200:
|
|
mclk = 11289600;
|
|
break;
|
|
default:
|
|
return -EINVAL;
|
|
}
|
|
|
|
ret = snd_soc_dai_set_sysclk(cpu_dai, 0, mclk,
|
|
SND_SOC_CLOCK_OUT);
|
|
if (ret < 0) {
|
|
dev_err(codec_dai->dev, "Can't set codec clock %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
ret = snd_soc_dai_set_sysclk(codec_dai, 0, mclk,
|
|
SND_SOC_CLOCK_IN);
|
|
if (ret < 0) {
|
|
dev_err(codec_dai->dev, "Can't set codec clock %d\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int rk_init(struct snd_soc_pcm_runtime *runtime)
|
|
{
|
|
struct snd_soc_card *card = runtime->card;
|
|
int ret;
|
|
|
|
/* Enable Headset and 4 Buttons Jack detection */
|
|
ret = snd_soc_card_jack_new(card, "Headset Jack",
|
|
SND_JACK_HEADPHONE | SND_JACK_MICROPHONE |
|
|
SND_JACK_BTN_0 | SND_JACK_BTN_1 |
|
|
SND_JACK_BTN_2 | SND_JACK_BTN_3,
|
|
&headset_jack, NULL, 0);
|
|
if (ret) {
|
|
dev_err(card->dev, "New Headset Jack failed! (%d)\n", ret);
|
|
return ret;
|
|
}
|
|
|
|
return rt5645_set_jack_detect(runtime->codec_dai->component,
|
|
&headset_jack,
|
|
&headset_jack,
|
|
&headset_jack);
|
|
}
|
|
|
|
static const struct snd_soc_ops rk_aif1_ops = {
|
|
.hw_params = rk_aif1_hw_params,
|
|
};
|
|
|
|
static struct snd_soc_dai_link rk_dailink = {
|
|
.name = "rt5645",
|
|
.stream_name = "rt5645 PCM",
|
|
.codec_dai_name = "rt5645-aif1",
|
|
.init = rk_init,
|
|
.ops = &rk_aif1_ops,
|
|
/* set rt5645 as slave */
|
|
.dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
|
|
SND_SOC_DAIFMT_CBS_CFS,
|
|
};
|
|
|
|
static struct snd_soc_card snd_soc_card_rk = {
|
|
.name = "I2S-RT5650",
|
|
.owner = THIS_MODULE,
|
|
.dai_link = &rk_dailink,
|
|
.num_links = 1,
|
|
.dapm_widgets = rk_dapm_widgets,
|
|
.num_dapm_widgets = ARRAY_SIZE(rk_dapm_widgets),
|
|
.dapm_routes = rk_audio_map,
|
|
.num_dapm_routes = ARRAY_SIZE(rk_audio_map),
|
|
.controls = rk_mc_controls,
|
|
.num_controls = ARRAY_SIZE(rk_mc_controls),
|
|
};
|
|
|
|
static int snd_rk_mc_probe(struct platform_device *pdev)
|
|
{
|
|
int ret = 0;
|
|
struct snd_soc_card *card = &snd_soc_card_rk;
|
|
struct device_node *np = pdev->dev.of_node;
|
|
|
|
/* register the soc card */
|
|
card->dev = &pdev->dev;
|
|
|
|
rk_dailink.codec_of_node = of_parse_phandle(np,
|
|
"rockchip,audio-codec", 0);
|
|
if (!rk_dailink.codec_of_node) {
|
|
dev_err(&pdev->dev,
|
|
"Property 'rockchip,audio-codec' missing or invalid\n");
|
|
return -EINVAL;
|
|
}
|
|
|
|
rk_dailink.cpu_of_node = of_parse_phandle(np,
|
|
"rockchip,i2s-controller", 0);
|
|
if (!rk_dailink.cpu_of_node) {
|
|
dev_err(&pdev->dev,
|
|
"Property 'rockchip,i2s-controller' missing or invalid\n");
|
|
ret = -EINVAL;
|
|
goto put_codec_of_node;
|
|
}
|
|
|
|
rk_dailink.platform_of_node = rk_dailink.cpu_of_node;
|
|
|
|
ret = snd_soc_of_parse_card_name(card, "rockchip,model");
|
|
if (ret) {
|
|
dev_err(&pdev->dev,
|
|
"Soc parse card name failed %d\n", ret);
|
|
goto put_cpu_of_node;
|
|
}
|
|
|
|
ret = devm_snd_soc_register_card(&pdev->dev, card);
|
|
if (ret) {
|
|
dev_err(&pdev->dev,
|
|
"Soc register card failed %d\n", ret);
|
|
goto put_cpu_of_node;
|
|
}
|
|
|
|
return ret;
|
|
|
|
put_cpu_of_node:
|
|
of_node_put(rk_dailink.cpu_of_node);
|
|
rk_dailink.cpu_of_node = NULL;
|
|
put_codec_of_node:
|
|
of_node_put(rk_dailink.codec_of_node);
|
|
rk_dailink.codec_of_node = NULL;
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int snd_rk_mc_remove(struct platform_device *pdev)
|
|
{
|
|
of_node_put(rk_dailink.cpu_of_node);
|
|
rk_dailink.cpu_of_node = NULL;
|
|
of_node_put(rk_dailink.codec_of_node);
|
|
rk_dailink.codec_of_node = NULL;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct of_device_id rockchip_rt5645_of_match[] = {
|
|
{ .compatible = "rockchip,rockchip-audio-rt5645", },
|
|
{},
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(of, rockchip_rt5645_of_match);
|
|
|
|
static struct platform_driver snd_rk_mc_driver = {
|
|
.probe = snd_rk_mc_probe,
|
|
.remove = snd_rk_mc_remove,
|
|
.driver = {
|
|
.name = DRV_NAME,
|
|
.pm = &snd_soc_pm_ops,
|
|
.of_match_table = rockchip_rt5645_of_match,
|
|
},
|
|
};
|
|
|
|
module_platform_driver(snd_rk_mc_driver);
|
|
|
|
MODULE_AUTHOR("Xing Zheng <zhengxing@rock-chips.com>");
|
|
MODULE_DESCRIPTION("Rockchip rt5645 machine ASoC driver");
|
|
MODULE_LICENSE("GPL v2");
|
|
MODULE_ALIAS("platform:" DRV_NAME);
|