linux/drivers/block/xen-blkback
Konrad Rzeszutek Wilk 8c9ce606a6 xen/blkback: Copy id field when doing BLKIF_DISCARD.
We weren't copying the id field so when we sent the response
back to the frontend (especially with a 64-bit host and 32-bit
guest), we ended up using a random value. This lead to the
frontend crashing as it would try to pass to __blk_end_request_all
a NULL 'struct request' (b/c it would use the 'id' to find the
proper 'struct request' in its shadow array) and end up crashing:

BUG: unable to handle kernel NULL pointer dereference at 000000e4
IP: [<c0646d4c>] __blk_end_request_all+0xc/0x40
.. snip..
EIP is at __blk_end_request_all+0xc/0x40
.. snip..
 [<ed95db72>] blkif_interrupt+0x172/0x330 [xen_blkfront]

This fixes the bug by passing in the proper id for the response.

Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=824641

CC: stable@kernel.org
Tested-by: William Dauchy <wdauchy@gmail.com>
Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
2012-05-30 17:20:04 -04:00
..
blkback.c xen/blkback: Squash the discard support for 'file' and 'phy' type. 2012-03-24 10:04:35 -04:00
common.h xen/blkback: Copy id field when doing BLKIF_DISCARD. 2012-05-30 17:20:04 -04:00
Makefile xen/blkback: Squash vbd.c,interface.c in blkback.c and xenbus.c respectivly. 2011-04-20 11:57:59 -04:00
xenbus.c xen/blkback: Make optional features be really optional. 2012-03-24 10:04:36 -04:00