mirror of
https://github.com/torvalds/linux.git
synced 2024-11-25 13:41:51 +00:00
0a66d6f90c
Running a lockedp-enabled kernel on a vim3l board (Amlogic SM1) leads to the following splat: [ 13.557138] WARNING: HARDIRQ-safe -> HARDIRQ-unsafe lock order detected [ 13.587485] ip/456 [HC0[0]:SC0[0]:HE0:SE1] is trying to acquire: [ 13.625922] ffff000059908cf0 (&irq_desc_lock_class){-.-.}-{2:2}, at: __setup_irq+0xf8/0x8d8 [ 13.632273] which would create a new lock dependency: [ 13.637272] (&irq_desc_lock_class){-.-.}-{2:2} -> (&ctl->lock){+.+.}-{2:2} [ 13.644209] [ 13.644209] but this new dependency connects a HARDIRQ-irq-safe lock: [ 13.654122] (&irq_desc_lock_class){-.-.}-{2:2} [ 13.654125] [ 13.654125] ... which became HARDIRQ-irq-safe at: [ 13.664759] lock_acquire+0xec/0x368 [ 13.666926] _raw_spin_lock+0x60/0x88 [ 13.669979] handle_fasteoi_irq+0x30/0x178 [ 13.674082] generic_handle_irq+0x38/0x50 [ 13.678098] __handle_domain_irq+0x6c/0xc8 [ 13.682209] gic_handle_irq+0x5c/0xb0 [ 13.685872] el1_irq+0xd0/0x180 [ 13.689010] arch_cpu_idle+0x40/0x220 [ 13.692732] default_idle_call+0x54/0x60 [ 13.696677] do_idle+0x23c/0x2e8 [ 13.699903] cpu_startup_entry+0x30/0x50 [ 13.703852] rest_init+0x1e0/0x2b4 [ 13.707301] arch_call_rest_init+0x18/0x24 [ 13.711449] start_kernel+0x4ec/0x51c [ 13.715167] [ 13.715167] to a HARDIRQ-irq-unsafe lock: [ 13.722426] (&ctl->lock){+.+.}-{2:2} [ 13.722430] [ 13.722430] ... which became HARDIRQ-irq-unsafe at: [ 13.732319] ... [ 13.732324] lock_acquire+0xec/0x368 [ 13.735985] _raw_spin_lock+0x60/0x88 [ 13.739452] meson_gpio_irq_domain_alloc+0xcc/0x290 [ 13.744392] irq_domain_alloc_irqs_hierarchy+0x24/0x60 [ 13.749586] __irq_domain_alloc_irqs+0x160/0x2f0 [ 13.754254] irq_create_fwspec_mapping+0x118/0x320 [ 13.759073] irq_create_of_mapping+0x78/0xa0 [ 13.763360] of_irq_get+0x6c/0x80 [ 13.766701] of_mdiobus_register_phy+0x10c/0x238 [of_mdio] [ 13.772227] of_mdiobus_register+0x158/0x380 [of_mdio] [ 13.777388] mdio_mux_init+0x180/0x2e8 [mdio_mux] [ 13.782128] g12a_mdio_mux_probe+0x290/0x398 [mdio_mux_meson_g12a] [ 13.788349] platform_drv_probe+0x5c/0xb0 [ 13.792379] really_probe+0xe4/0x448 [ 13.795979] driver_probe_device+0xe8/0x140 [ 13.800189] __device_attach_driver+0x94/0x120 [ 13.804639] bus_for_each_drv+0x84/0xd8 [ 13.808474] __device_attach+0xe4/0x168 [ 13.812361] device_initial_probe+0x1c/0x28 [ 13.816592] bus_probe_device+0xa4/0xb0 [ 13.820430] deferred_probe_work_func+0xa8/0x100 [ 13.825064] process_one_work+0x264/0x688 [ 13.829088] worker_thread+0x4c/0x458 [ 13.832768] kthread+0x154/0x158 [ 13.836018] ret_from_fork+0x10/0x18 [ 13.839612] [ 13.839612] other info that might help us debug this: [ 13.839612] [ 13.850354] Possible interrupt unsafe locking scenario: [ 13.850354] [ 13.855720] CPU0 CPU1 [ 13.858774] ---- ---- [ 13.863242] lock(&ctl->lock); [ 13.866330] local_irq_disable(); [ 13.872233] lock(&irq_desc_lock_class); [ 13.878705] lock(&ctl->lock); [ 13.884297] <Interrupt> [ 13.886857] lock(&irq_desc_lock_class); [ 13.891014] [ 13.891014] *** DEADLOCK *** The issue can occur when CPU1 is doing something like irq_set_type() and CPU0 performing an interrupt allocation, for example. Taking an interrupt (like the one being reconfigured) would lead to a deadlock. A solution to this is: - Reorder the locking so that meson_gpio_irq_update_bits takes the lock itself at all times, instead of relying on the caller to lock or not, hence making the RMW sequence atomic, - Rework the critical section in meson_gpio_irq_request_channel to only cover the allocation itself, and let the gpio_irq_sel_pin callback deal with its own locking if required, - Take the private spin-lock with interrupts disabled at all times Reviewed-by: Jerome Brunet <jbrunet@baylibre.com> Signed-off-by: Marc Zyngier <maz@kernel.org>
526 lines
14 KiB
C
526 lines
14 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (c) 2015 Endless Mobile, Inc.
|
|
* Author: Carlo Caione <carlo@endlessm.com>
|
|
* Copyright (c) 2016 BayLibre, SAS.
|
|
* Author: Jerome Brunet <jbrunet@baylibre.com>
|
|
*/
|
|
|
|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
|
|
|
#include <linux/io.h>
|
|
#include <linux/module.h>
|
|
#include <linux/irq.h>
|
|
#include <linux/irqdomain.h>
|
|
#include <linux/irqchip.h>
|
|
#include <linux/of.h>
|
|
#include <linux/of_address.h>
|
|
|
|
#define NUM_CHANNEL 8
|
|
#define MAX_INPUT_MUX 256
|
|
|
|
#define REG_EDGE_POL 0x00
|
|
#define REG_PIN_03_SEL 0x04
|
|
#define REG_PIN_47_SEL 0x08
|
|
#define REG_FILTER_SEL 0x0c
|
|
|
|
/* use for A1 like chips */
|
|
#define REG_PIN_A1_SEL 0x04
|
|
|
|
/*
|
|
* Note: The S905X3 datasheet reports that BOTH_EDGE is controlled by
|
|
* bits 24 to 31. Tests on the actual HW show that these bits are
|
|
* stuck at 0. Bits 8 to 15 are responsive and have the expected
|
|
* effect.
|
|
*/
|
|
#define REG_EDGE_POL_EDGE(params, x) BIT((params)->edge_single_offset + (x))
|
|
#define REG_EDGE_POL_LOW(params, x) BIT((params)->pol_low_offset + (x))
|
|
#define REG_BOTH_EDGE(params, x) BIT((params)->edge_both_offset + (x))
|
|
#define REG_EDGE_POL_MASK(params, x) ( \
|
|
REG_EDGE_POL_EDGE(params, x) | \
|
|
REG_EDGE_POL_LOW(params, x) | \
|
|
REG_BOTH_EDGE(params, x))
|
|
#define REG_PIN_SEL_SHIFT(x) (((x) % 4) * 8)
|
|
#define REG_FILTER_SEL_SHIFT(x) ((x) * 4)
|
|
|
|
struct meson_gpio_irq_controller;
|
|
static void meson8_gpio_irq_sel_pin(struct meson_gpio_irq_controller *ctl,
|
|
unsigned int channel, unsigned long hwirq);
|
|
static void meson_gpio_irq_init_dummy(struct meson_gpio_irq_controller *ctl);
|
|
static void meson_a1_gpio_irq_sel_pin(struct meson_gpio_irq_controller *ctl,
|
|
unsigned int channel,
|
|
unsigned long hwirq);
|
|
static void meson_a1_gpio_irq_init(struct meson_gpio_irq_controller *ctl);
|
|
|
|
struct irq_ctl_ops {
|
|
void (*gpio_irq_sel_pin)(struct meson_gpio_irq_controller *ctl,
|
|
unsigned int channel, unsigned long hwirq);
|
|
void (*gpio_irq_init)(struct meson_gpio_irq_controller *ctl);
|
|
};
|
|
|
|
struct meson_gpio_irq_params {
|
|
unsigned int nr_hwirq;
|
|
bool support_edge_both;
|
|
unsigned int edge_both_offset;
|
|
unsigned int edge_single_offset;
|
|
unsigned int pol_low_offset;
|
|
unsigned int pin_sel_mask;
|
|
struct irq_ctl_ops ops;
|
|
};
|
|
|
|
#define INIT_MESON_COMMON(irqs, init, sel) \
|
|
.nr_hwirq = irqs, \
|
|
.ops = { \
|
|
.gpio_irq_init = init, \
|
|
.gpio_irq_sel_pin = sel, \
|
|
},
|
|
|
|
#define INIT_MESON8_COMMON_DATA(irqs) \
|
|
INIT_MESON_COMMON(irqs, meson_gpio_irq_init_dummy, \
|
|
meson8_gpio_irq_sel_pin) \
|
|
.edge_single_offset = 0, \
|
|
.pol_low_offset = 16, \
|
|
.pin_sel_mask = 0xff, \
|
|
|
|
#define INIT_MESON_A1_COMMON_DATA(irqs) \
|
|
INIT_MESON_COMMON(irqs, meson_a1_gpio_irq_init, \
|
|
meson_a1_gpio_irq_sel_pin) \
|
|
.support_edge_both = true, \
|
|
.edge_both_offset = 16, \
|
|
.edge_single_offset = 8, \
|
|
.pol_low_offset = 0, \
|
|
.pin_sel_mask = 0x7f, \
|
|
|
|
static const struct meson_gpio_irq_params meson8_params = {
|
|
INIT_MESON8_COMMON_DATA(134)
|
|
};
|
|
|
|
static const struct meson_gpio_irq_params meson8b_params = {
|
|
INIT_MESON8_COMMON_DATA(119)
|
|
};
|
|
|
|
static const struct meson_gpio_irq_params gxbb_params = {
|
|
INIT_MESON8_COMMON_DATA(133)
|
|
};
|
|
|
|
static const struct meson_gpio_irq_params gxl_params = {
|
|
INIT_MESON8_COMMON_DATA(110)
|
|
};
|
|
|
|
static const struct meson_gpio_irq_params axg_params = {
|
|
INIT_MESON8_COMMON_DATA(100)
|
|
};
|
|
|
|
static const struct meson_gpio_irq_params sm1_params = {
|
|
INIT_MESON8_COMMON_DATA(100)
|
|
.support_edge_both = true,
|
|
.edge_both_offset = 8,
|
|
};
|
|
|
|
static const struct meson_gpio_irq_params a1_params = {
|
|
INIT_MESON_A1_COMMON_DATA(62)
|
|
};
|
|
|
|
static const struct of_device_id meson_irq_gpio_matches[] = {
|
|
{ .compatible = "amlogic,meson8-gpio-intc", .data = &meson8_params },
|
|
{ .compatible = "amlogic,meson8b-gpio-intc", .data = &meson8b_params },
|
|
{ .compatible = "amlogic,meson-gxbb-gpio-intc", .data = &gxbb_params },
|
|
{ .compatible = "amlogic,meson-gxl-gpio-intc", .data = &gxl_params },
|
|
{ .compatible = "amlogic,meson-axg-gpio-intc", .data = &axg_params },
|
|
{ .compatible = "amlogic,meson-g12a-gpio-intc", .data = &axg_params },
|
|
{ .compatible = "amlogic,meson-sm1-gpio-intc", .data = &sm1_params },
|
|
{ .compatible = "amlogic,meson-a1-gpio-intc", .data = &a1_params },
|
|
{ }
|
|
};
|
|
|
|
struct meson_gpio_irq_controller {
|
|
const struct meson_gpio_irq_params *params;
|
|
void __iomem *base;
|
|
u32 channel_irqs[NUM_CHANNEL];
|
|
DECLARE_BITMAP(channel_map, NUM_CHANNEL);
|
|
spinlock_t lock;
|
|
};
|
|
|
|
static void meson_gpio_irq_update_bits(struct meson_gpio_irq_controller *ctl,
|
|
unsigned int reg, u32 mask, u32 val)
|
|
{
|
|
unsigned long flags;
|
|
u32 tmp;
|
|
|
|
spin_lock_irqsave(&ctl->lock, flags);
|
|
|
|
tmp = readl_relaxed(ctl->base + reg);
|
|
tmp &= ~mask;
|
|
tmp |= val;
|
|
writel_relaxed(tmp, ctl->base + reg);
|
|
|
|
spin_unlock_irqrestore(&ctl->lock, flags);
|
|
}
|
|
|
|
static void meson_gpio_irq_init_dummy(struct meson_gpio_irq_controller *ctl)
|
|
{
|
|
}
|
|
|
|
static void meson8_gpio_irq_sel_pin(struct meson_gpio_irq_controller *ctl,
|
|
unsigned int channel, unsigned long hwirq)
|
|
{
|
|
unsigned int reg_offset;
|
|
unsigned int bit_offset;
|
|
|
|
reg_offset = (channel < 4) ? REG_PIN_03_SEL : REG_PIN_47_SEL;
|
|
bit_offset = REG_PIN_SEL_SHIFT(channel);
|
|
|
|
meson_gpio_irq_update_bits(ctl, reg_offset,
|
|
ctl->params->pin_sel_mask << bit_offset,
|
|
hwirq << bit_offset);
|
|
}
|
|
|
|
static void meson_a1_gpio_irq_sel_pin(struct meson_gpio_irq_controller *ctl,
|
|
unsigned int channel,
|
|
unsigned long hwirq)
|
|
{
|
|
unsigned int reg_offset;
|
|
unsigned int bit_offset;
|
|
|
|
bit_offset = ((channel % 2) == 0) ? 0 : 16;
|
|
reg_offset = REG_PIN_A1_SEL + ((channel / 2) << 2);
|
|
|
|
meson_gpio_irq_update_bits(ctl, reg_offset,
|
|
ctl->params->pin_sel_mask << bit_offset,
|
|
hwirq << bit_offset);
|
|
}
|
|
|
|
/* For a1 or later chips like a1 there is a switch to enable/disable irq */
|
|
static void meson_a1_gpio_irq_init(struct meson_gpio_irq_controller *ctl)
|
|
{
|
|
meson_gpio_irq_update_bits(ctl, REG_EDGE_POL, BIT(31), BIT(31));
|
|
}
|
|
|
|
static int
|
|
meson_gpio_irq_request_channel(struct meson_gpio_irq_controller *ctl,
|
|
unsigned long hwirq,
|
|
u32 **channel_hwirq)
|
|
{
|
|
unsigned long flags;
|
|
unsigned int idx;
|
|
|
|
spin_lock_irqsave(&ctl->lock, flags);
|
|
|
|
/* Find a free channel */
|
|
idx = find_first_zero_bit(ctl->channel_map, NUM_CHANNEL);
|
|
if (idx >= NUM_CHANNEL) {
|
|
spin_unlock_irqrestore(&ctl->lock, flags);
|
|
pr_err("No channel available\n");
|
|
return -ENOSPC;
|
|
}
|
|
|
|
/* Mark the channel as used */
|
|
set_bit(idx, ctl->channel_map);
|
|
|
|
spin_unlock_irqrestore(&ctl->lock, flags);
|
|
|
|
/*
|
|
* Setup the mux of the channel to route the signal of the pad
|
|
* to the appropriate input of the GIC
|
|
*/
|
|
ctl->params->ops.gpio_irq_sel_pin(ctl, idx, hwirq);
|
|
|
|
/*
|
|
* Get the hwirq number assigned to this channel through
|
|
* a pointer the channel_irq table. The added benifit of this
|
|
* method is that we can also retrieve the channel index with
|
|
* it, using the table base.
|
|
*/
|
|
*channel_hwirq = &(ctl->channel_irqs[idx]);
|
|
|
|
pr_debug("hwirq %lu assigned to channel %d - irq %u\n",
|
|
hwirq, idx, **channel_hwirq);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static unsigned int
|
|
meson_gpio_irq_get_channel_idx(struct meson_gpio_irq_controller *ctl,
|
|
u32 *channel_hwirq)
|
|
{
|
|
return channel_hwirq - ctl->channel_irqs;
|
|
}
|
|
|
|
static void
|
|
meson_gpio_irq_release_channel(struct meson_gpio_irq_controller *ctl,
|
|
u32 *channel_hwirq)
|
|
{
|
|
unsigned int idx;
|
|
|
|
idx = meson_gpio_irq_get_channel_idx(ctl, channel_hwirq);
|
|
clear_bit(idx, ctl->channel_map);
|
|
}
|
|
|
|
static int meson_gpio_irq_type_setup(struct meson_gpio_irq_controller *ctl,
|
|
unsigned int type,
|
|
u32 *channel_hwirq)
|
|
{
|
|
u32 val = 0;
|
|
unsigned int idx;
|
|
const struct meson_gpio_irq_params *params;
|
|
|
|
params = ctl->params;
|
|
idx = meson_gpio_irq_get_channel_idx(ctl, channel_hwirq);
|
|
|
|
/*
|
|
* The controller has a filter block to operate in either LEVEL or
|
|
* EDGE mode, then signal is sent to the GIC. To enable LEVEL_LOW and
|
|
* EDGE_FALLING support (which the GIC does not support), the filter
|
|
* block is also able to invert the input signal it gets before
|
|
* providing it to the GIC.
|
|
*/
|
|
type &= IRQ_TYPE_SENSE_MASK;
|
|
|
|
/*
|
|
* New controller support EDGE_BOTH trigger. This setting takes
|
|
* precedence over the other edge/polarity settings
|
|
*/
|
|
if (type == IRQ_TYPE_EDGE_BOTH) {
|
|
if (!params->support_edge_both)
|
|
return -EINVAL;
|
|
|
|
val |= REG_BOTH_EDGE(params, idx);
|
|
} else {
|
|
if (type & (IRQ_TYPE_EDGE_RISING | IRQ_TYPE_EDGE_FALLING))
|
|
val |= REG_EDGE_POL_EDGE(params, idx);
|
|
|
|
if (type & (IRQ_TYPE_LEVEL_LOW | IRQ_TYPE_EDGE_FALLING))
|
|
val |= REG_EDGE_POL_LOW(params, idx);
|
|
}
|
|
|
|
meson_gpio_irq_update_bits(ctl, REG_EDGE_POL,
|
|
REG_EDGE_POL_MASK(params, idx), val);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static unsigned int meson_gpio_irq_type_output(unsigned int type)
|
|
{
|
|
unsigned int sense = type & IRQ_TYPE_SENSE_MASK;
|
|
|
|
type &= ~IRQ_TYPE_SENSE_MASK;
|
|
|
|
/*
|
|
* The polarity of the signal provided to the GIC should always
|
|
* be high.
|
|
*/
|
|
if (sense & (IRQ_TYPE_LEVEL_HIGH | IRQ_TYPE_LEVEL_LOW))
|
|
type |= IRQ_TYPE_LEVEL_HIGH;
|
|
else
|
|
type |= IRQ_TYPE_EDGE_RISING;
|
|
|
|
return type;
|
|
}
|
|
|
|
static int meson_gpio_irq_set_type(struct irq_data *data, unsigned int type)
|
|
{
|
|
struct meson_gpio_irq_controller *ctl = data->domain->host_data;
|
|
u32 *channel_hwirq = irq_data_get_irq_chip_data(data);
|
|
int ret;
|
|
|
|
ret = meson_gpio_irq_type_setup(ctl, type, channel_hwirq);
|
|
if (ret)
|
|
return ret;
|
|
|
|
return irq_chip_set_type_parent(data,
|
|
meson_gpio_irq_type_output(type));
|
|
}
|
|
|
|
static struct irq_chip meson_gpio_irq_chip = {
|
|
.name = "meson-gpio-irqchip",
|
|
.irq_mask = irq_chip_mask_parent,
|
|
.irq_unmask = irq_chip_unmask_parent,
|
|
.irq_eoi = irq_chip_eoi_parent,
|
|
.irq_set_type = meson_gpio_irq_set_type,
|
|
.irq_retrigger = irq_chip_retrigger_hierarchy,
|
|
#ifdef CONFIG_SMP
|
|
.irq_set_affinity = irq_chip_set_affinity_parent,
|
|
#endif
|
|
.flags = IRQCHIP_SET_TYPE_MASKED,
|
|
};
|
|
|
|
static int meson_gpio_irq_domain_translate(struct irq_domain *domain,
|
|
struct irq_fwspec *fwspec,
|
|
unsigned long *hwirq,
|
|
unsigned int *type)
|
|
{
|
|
if (is_of_node(fwspec->fwnode) && fwspec->param_count == 2) {
|
|
*hwirq = fwspec->param[0];
|
|
*type = fwspec->param[1];
|
|
return 0;
|
|
}
|
|
|
|
return -EINVAL;
|
|
}
|
|
|
|
static int meson_gpio_irq_allocate_gic_irq(struct irq_domain *domain,
|
|
unsigned int virq,
|
|
u32 hwirq,
|
|
unsigned int type)
|
|
{
|
|
struct irq_fwspec fwspec;
|
|
|
|
fwspec.fwnode = domain->parent->fwnode;
|
|
fwspec.param_count = 3;
|
|
fwspec.param[0] = 0; /* SPI */
|
|
fwspec.param[1] = hwirq;
|
|
fwspec.param[2] = meson_gpio_irq_type_output(type);
|
|
|
|
return irq_domain_alloc_irqs_parent(domain, virq, 1, &fwspec);
|
|
}
|
|
|
|
static int meson_gpio_irq_domain_alloc(struct irq_domain *domain,
|
|
unsigned int virq,
|
|
unsigned int nr_irqs,
|
|
void *data)
|
|
{
|
|
struct irq_fwspec *fwspec = data;
|
|
struct meson_gpio_irq_controller *ctl = domain->host_data;
|
|
unsigned long hwirq;
|
|
u32 *channel_hwirq;
|
|
unsigned int type;
|
|
int ret;
|
|
|
|
if (WARN_ON(nr_irqs != 1))
|
|
return -EINVAL;
|
|
|
|
ret = meson_gpio_irq_domain_translate(domain, fwspec, &hwirq, &type);
|
|
if (ret)
|
|
return ret;
|
|
|
|
ret = meson_gpio_irq_request_channel(ctl, hwirq, &channel_hwirq);
|
|
if (ret)
|
|
return ret;
|
|
|
|
ret = meson_gpio_irq_allocate_gic_irq(domain, virq,
|
|
*channel_hwirq, type);
|
|
if (ret < 0) {
|
|
pr_err("failed to allocate gic irq %u\n", *channel_hwirq);
|
|
meson_gpio_irq_release_channel(ctl, channel_hwirq);
|
|
return ret;
|
|
}
|
|
|
|
irq_domain_set_hwirq_and_chip(domain, virq, hwirq,
|
|
&meson_gpio_irq_chip, channel_hwirq);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void meson_gpio_irq_domain_free(struct irq_domain *domain,
|
|
unsigned int virq,
|
|
unsigned int nr_irqs)
|
|
{
|
|
struct meson_gpio_irq_controller *ctl = domain->host_data;
|
|
struct irq_data *irq_data;
|
|
u32 *channel_hwirq;
|
|
|
|
if (WARN_ON(nr_irqs != 1))
|
|
return;
|
|
|
|
irq_domain_free_irqs_parent(domain, virq, 1);
|
|
|
|
irq_data = irq_domain_get_irq_data(domain, virq);
|
|
channel_hwirq = irq_data_get_irq_chip_data(irq_data);
|
|
|
|
meson_gpio_irq_release_channel(ctl, channel_hwirq);
|
|
}
|
|
|
|
static const struct irq_domain_ops meson_gpio_irq_domain_ops = {
|
|
.alloc = meson_gpio_irq_domain_alloc,
|
|
.free = meson_gpio_irq_domain_free,
|
|
.translate = meson_gpio_irq_domain_translate,
|
|
};
|
|
|
|
static int __init meson_gpio_irq_parse_dt(struct device_node *node,
|
|
struct meson_gpio_irq_controller *ctl)
|
|
{
|
|
const struct of_device_id *match;
|
|
int ret;
|
|
|
|
match = of_match_node(meson_irq_gpio_matches, node);
|
|
if (!match)
|
|
return -ENODEV;
|
|
|
|
ctl->params = match->data;
|
|
|
|
ret = of_property_read_variable_u32_array(node,
|
|
"amlogic,channel-interrupts",
|
|
ctl->channel_irqs,
|
|
NUM_CHANNEL,
|
|
NUM_CHANNEL);
|
|
if (ret < 0) {
|
|
pr_err("can't get %d channel interrupts\n", NUM_CHANNEL);
|
|
return ret;
|
|
}
|
|
|
|
ctl->params->ops.gpio_irq_init(ctl);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int __init meson_gpio_irq_of_init(struct device_node *node,
|
|
struct device_node *parent)
|
|
{
|
|
struct irq_domain *domain, *parent_domain;
|
|
struct meson_gpio_irq_controller *ctl;
|
|
int ret;
|
|
|
|
if (!parent) {
|
|
pr_err("missing parent interrupt node\n");
|
|
return -ENODEV;
|
|
}
|
|
|
|
parent_domain = irq_find_host(parent);
|
|
if (!parent_domain) {
|
|
pr_err("unable to obtain parent domain\n");
|
|
return -ENXIO;
|
|
}
|
|
|
|
ctl = kzalloc(sizeof(*ctl), GFP_KERNEL);
|
|
if (!ctl)
|
|
return -ENOMEM;
|
|
|
|
spin_lock_init(&ctl->lock);
|
|
|
|
ctl->base = of_iomap(node, 0);
|
|
if (!ctl->base) {
|
|
ret = -ENOMEM;
|
|
goto free_ctl;
|
|
}
|
|
|
|
ret = meson_gpio_irq_parse_dt(node, ctl);
|
|
if (ret)
|
|
goto free_channel_irqs;
|
|
|
|
domain = irq_domain_create_hierarchy(parent_domain, 0,
|
|
ctl->params->nr_hwirq,
|
|
of_node_to_fwnode(node),
|
|
&meson_gpio_irq_domain_ops,
|
|
ctl);
|
|
if (!domain) {
|
|
pr_err("failed to add domain\n");
|
|
ret = -ENODEV;
|
|
goto free_channel_irqs;
|
|
}
|
|
|
|
pr_info("%d to %d gpio interrupt mux initialized\n",
|
|
ctl->params->nr_hwirq, NUM_CHANNEL);
|
|
|
|
return 0;
|
|
|
|
free_channel_irqs:
|
|
iounmap(ctl->base);
|
|
free_ctl:
|
|
kfree(ctl);
|
|
|
|
return ret;
|
|
}
|
|
|
|
IRQCHIP_DECLARE(meson_gpio_intc, "amlogic,meson-gpio-intc",
|
|
meson_gpio_irq_of_init);
|