mirror of
https://github.com/torvalds/linux.git
synced 2024-12-13 14:43:03 +00:00
27ac792ca0
On 32-bit architectures PAGE_ALIGN() truncates 64-bit values to the 32-bit boundary. For example: u64 val = PAGE_ALIGN(size); always returns a value < 4GB even if size is greater than 4GB. The problem resides in PAGE_MASK definition (from include/asm-x86/page.h for example): #define PAGE_SHIFT 12 #define PAGE_SIZE (_AC(1,UL) << PAGE_SHIFT) #define PAGE_MASK (~(PAGE_SIZE-1)) ... #define PAGE_ALIGN(addr) (((addr)+PAGE_SIZE-1)&PAGE_MASK) The "~" is performed on a 32-bit value, so everything in "and" with PAGE_MASK greater than 4GB will be truncated to the 32-bit boundary. Using the ALIGN() macro seems to be the right way, because it uses typeof(addr) for the mask. Also move the PAGE_ALIGN() definitions out of include/asm-*/page.h in include/linux/mm.h. See also lkml discussion: http://lkml.org/lkml/2008/6/11/237 [akpm@linux-foundation.org: fix drivers/media/video/uvc/uvc_queue.c] [akpm@linux-foundation.org: fix v850] [akpm@linux-foundation.org: fix powerpc] [akpm@linux-foundation.org: fix arm] [akpm@linux-foundation.org: fix mips] [akpm@linux-foundation.org: fix drivers/media/video/pvrusb2/pvrusb2-dvb.c] [akpm@linux-foundation.org: fix drivers/mtd/maps/uclinux.c] [akpm@linux-foundation.org: fix powerpc] Signed-off-by: Andrea Righi <righi.andrea@gmail.com> Cc: <linux-arch@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
||
|---|---|---|
| .. | ||
| at91_cf.c | ||
| au1000_db1x00.c | ||
| au1000_generic.c | ||
| au1000_generic.h | ||
| au1000_pb1x00.c | ||
| au1000_xxs1500.c | ||
| bfin_cf_pcmcia.c | ||
| cardbus.c | ||
| cirrus.h | ||
| cistpl.c | ||
| cs_internal.h | ||
| cs.c | ||
| ds_internal.h | ||
| ds.c | ||
| electra_cf.c | ||
| hd64465_ss.c | ||
| i82092.c | ||
| i82092aa.h | ||
| i82365.c | ||
| i82365.h | ||
| Kconfig | ||
| m8xx_pcmcia.c | ||
| m32r_cfc.c | ||
| m32r_cfc.h | ||
| m32r_pcc.c | ||
| m32r_pcc.h | ||
| Makefile | ||
| o2micro.h | ||
| omap_cf.c | ||
| pcmcia_ioctl.c | ||
| pcmcia_resource.c | ||
| pd6729.c | ||
| pd6729.h | ||
| pxa2xx_base.c | ||
| pxa2xx_base.h | ||
| pxa2xx_cm_x270.c | ||
| pxa2xx_lubbock.c | ||
| pxa2xx_mainstone.c | ||
| pxa2xx_palmtx.c | ||
| pxa2xx_sharpsl.c | ||
| ricoh.h | ||
| rsrc_mgr.c | ||
| rsrc_nonstatic.c | ||
| sa11xx_base.c | ||
| sa11xx_base.h | ||
| sa1100_assabet.c | ||
| sa1100_badge4.c | ||
| sa1100_cerf.c | ||
| sa1100_generic.c | ||
| sa1100_generic.h | ||
| sa1100_h3600.c | ||
| sa1100_jornada720.c | ||
| sa1100_neponset.c | ||
| sa1100_shannon.c | ||
| sa1100_simpad.c | ||
| sa1111_generic.c | ||
| sa1111_generic.h | ||
| soc_common.c | ||
| soc_common.h | ||
| socket_sysfs.c | ||
| tcic.c | ||
| tcic.h | ||
| ti113x.h | ||
| topic.h | ||
| vg468.h | ||
| vrc4171_card.c | ||
| vrc4173_cardu.c | ||
| vrc4173_cardu.h | ||
| yenta_socket.c | ||
| yenta_socket.h | ||