Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-05 19:41:54 +00:00
Code Issues Packages Projects Releases Wiki Activity
8838becdf5
linux/drivers/staging/vt6656
History
Ben Hutchings 1ee4c55fc9 staging: vt6656: Fix inconsistent structure packing 
vt6656 has several headers that use the #pragma pack(1) directive to
enable structure packing, but never disable it.  The layout of
structures defined in other headers can then depend on which order the
various headers are included in, breaking the One Definition Rule.

In practice this resulted in crashes on x86_64 until the order of header
inclusion was changed for some files in commit 11d404cb56 ('staging:
vt6656: fix headers and add cfg80211.').  But we need a proper fix that
won't be affected by future changes to the order of inclusion.

This removes the #pragma pack(1) directives and adds __packed to the
structure definitions for which packing appears to have been intended.

Reported-and-tested-by: Malcolm Priestley <tvboxspy@gmail.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2013-01-17 13:08:32 -08:00
..
80211hdr.h
80211mgr.c staging: vt6656: fix headers and add cfg80211. 2012-11-26 16:23:42 -08:00
80211mgr.h staging "vt6656" Fix typos in comments, and in a printk message. 2012-09-04 14:00:56 -07:00
aes_ccmp.c
aes_ccmp.h
baseband.c staging "vt6656" Typo rename Caculate to Calculate. 2012-09-04 14:00:56 -07:00
baseband.h staging "vt6656" Typo rename Caculate to Calculate. 2012-09-04 14:00:56 -07:00
bssdb.c staging: vt6656: remove redundant IWEVCUSTOM events. 2012-11-26 16:24:16 -08:00
bssdb.h staging: vt6656: Fix inconsistent structure packing 2013-01-17 13:08:32 -08:00
card.c staging "vt6656" Typo rename Caculate to Calculate. 2012-09-04 14:00:56 -07:00
card.h
channel.c
channel.h
control.c
control.h
country.h
datarate.c
datarate.h
desc.h staging: vt6656: 64bit fixes: desh.h fix size. replace DWORD with u32. 2012-11-13 12:51:30 -08:00
device_cfg.h
device.h staging: vt6656: dead code removal : wpactl.c/h 2012-11-26 16:24:16 -08:00
dpc.c staging: vt6656: remove wpahdr from driver. 2012-11-26 16:24:16 -08:00
dpc.h
firmware.c staging: vt6656: Keep firmware loading local and release firware. 2012-10-22 13:26:40 -07:00
firmware.h
hostap.c Staging: vt6655-6: shift wrap in hostap_set_encryption() 2012-10-22 13:26:40 -07:00
hostap.h
int.c staging "vt6656" Fix typos in comments, and in a printk message. 2012-09-04 14:00:56 -07:00
int.h staging: vt6656: Fix inconsistent structure packing 2013-01-17 13:08:32 -08:00
iocmd.h staging: vt6656: Fix inconsistent structure packing 2013-01-17 13:08:32 -08:00
iowpa.h staging: vt6656: Fix inconsistent structure packing 2013-01-17 13:08:32 -08:00
iwctl.c staging: vt6656: wpa_set_keys remove fcpfkernel 2012-11-26 16:24:16 -08:00
iwctl.h staging: vt6656: move move all commands to iw_handler. 2012-11-26 16:24:15 -08:00
Kconfig
key.c staging: vt6656: fix headers and add cfg80211. 2012-11-26 16:23:42 -08:00
key.h staging: vt6656: 64bit fixes: key.c/h change unsigned long to u32 2012-11-13 12:51:31 -08:00
mac.c staging: vt6656: 64 bit fixes: fix long warning messages. 2012-11-13 12:51:31 -08:00
mac.h
main_usb.c staging: vt6656: remove redundant IWEVCUSTOM events. 2012-11-26 16:24:16 -08:00
Makefile staging: vt6656: dead code remove ioctl.c/h 2012-11-26 16:24:16 -08:00
mib.c staging: vt6656: dead code remove upc.h 2012-11-13 12:45:43 -08:00
mib.h staging: vt6656: dead code byCntMeasure/TKIPCounterMeasuresInvoked 2012-11-13 12:45:43 -08:00
michael.c
michael.h
power.c staging "vt6656" Fix typos in comments, and in a printk message. 2012-09-04 14:00:56 -07:00
power.h
rc4.c
rc4.h
rf.c staging: vt6656: [BUG] out of bound array reference in RFbSetPower. 2012-10-22 13:26:40 -07:00
rf.h staging "vt6656" Typo rename Embeded to Embedded. 2012-09-04 14:00:56 -07:00
rndis.h
rxtx.c staging: vt6656: 64 bit fixes pdwIV is now u32 2012-11-13 12:51:31 -08:00
rxtx.h staging: vt6656: 64 bit fixes: rxtx.h Replace DWORD with u32. 2012-11-13 12:51:30 -08:00
srom.h
tcrc.c staging "vt6656" Fix typos in comments, and in a printk message. 2012-09-04 14:00:56 -07:00
tcrc.h staging "vt6656" Fix typos in comments, and in a printk message. 2012-09-04 14:00:56 -07:00
tether.c staging "vt6656" Fix typos in comments, and in a printk message. 2012-09-04 14:00:56 -07:00
tether.h
tkip.c staging: vt6656: 64 bit fixes TKIPvMixKey remove unsigned long 2012-11-13 12:51:31 -08:00
tkip.h
tmacro.h
TODO
ttype.h staging: vt6656: 64 bit fixes : correct all type sizes 2012-11-13 12:51:31 -08:00
usbpipe.c staging: vt6656: no need to bIndicateReceive when no bytes to read. 2012-11-13 12:45:43 -08:00
usbpipe.h
vntconfiguration.dat
wcmd.c staging: vt6656: send SIOCGIWSCAN at end of all scanning events. 2012-11-26 16:24:16 -08:00
wcmd.h
wctl.c staging "vt6656" Fix typos in comments, and in a printk message. 2012-09-04 14:00:56 -07:00
wctl.h
wmgr.c staging: vt6656: remove wpahdr from driver. 2012-11-26 16:24:16 -08:00
wmgr.h staging: vt6656: 64 bit fixes correct sizes of NDIS_802_11_ASSOCIATION_INFORMATION 2012-11-13 12:51:32 -08:00
wpa2.c staging: vt6656: fix headers and add cfg80211. 2012-11-26 16:23:42 -08:00
wpa2.h staging: vt6656: 64bit fixes: vCommandTimerWait change calculation of timer. 2012-11-13 12:51:32 -08:00
wpa.c staging "vt6656" Fix typos in comments, and in a printk message. 2012-09-04 14:00:56 -07:00
wpa.h
wpactl.c staging: vt6656: wpa_set_keys remove fcpfkernel 2012-11-26 16:24:16 -08:00
wpactl.h staging: vt6656: wpa_set_keys remove fcpfkernel 2012-11-26 16:24:16 -08:00