mirror of
https://github.com/torvalds/linux.git
synced 2024-11-05 11:32:04 +00:00
880b8ffd45
Add a call to of_node_put in the error handling code following a call to of_parse_phandle. This patch also moves the existing call to of_node_put tothe end of the error handling code, to make it possible to jump to of_node_put without doing the other cleanup operations. These appear to be disjoint operations, so the ordering doesn't matter. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> @r exists@ local idexpression x; expression E,E1,E2; statement S; @@ *x = (of_find_node_by_path |of_find_node_by_name |of_find_node_by_phandle |of_get_parent |of_get_next_parent |of_get_next_child |of_find_compatible_node |of_match_node |of_find_node_by_type |of_find_node_with_property |of_find_matching_node |of_parse_phandle )(...); ... if (x == NULL) S <... when != x = E *if (...) { ... when != of_node_put(x) when != if (...) { ... of_node_put(x); ... } ( return <+...x...+>; | * return ...; ) } ...> ( E2 = x; | of_node_put(x); ) // </smpl> Signed-off-by: Julia Lawall <julia@diku.dk> Acked-by: Timur Tabi <timur@freescale.com> Acked-by: Liam Girdwood <lrg@slimlogic.uo.uk> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com> |
||
---|---|---|
.. | ||
atmel | ||
au1x | ||
blackfin | ||
codecs | ||
davinci | ||
ep93xx | ||
fsl | ||
imx | ||
jz4740 | ||
kirkwood | ||
nuc900 | ||
omap | ||
pxa | ||
s3c24xx | ||
s6000 | ||
sh | ||
txx9 | ||
Kconfig | ||
Makefile | ||
soc-cache.c | ||
soc-core.c | ||
soc-dapm.c | ||
soc-jack.c | ||
soc-utils.c |