Dave Chinner 95179935be xfs: xfs_finobt_count_blocks() walks the wrong btree ... As a result of the factoring in commit 14dd46cf31 ("xfs: split xfs_inobt_init_cursor"), mount started taking a long time on a user's filesystem. For Anders, this made mount times regress from under a second to over 15 minutes for a filesystem with only 30 million inodes in it. Anders bisected it down to the above commit, but even then the bug was not obvious. In this commit, over 20 calls to xfs_inobt_init_cursor() were modified, and some we modified to call a new function named xfs_finobt_init_cursor(). If that takes you a moment to reread those function names to see what the rename was, then you have realised why this bug wasn't spotted during review. And it wasn't spotted on inspection even after the bisect pointed at this commit - a single missing "f" isn't the easiest thing for a human eye to notice.... The result is that xfs_finobt_count_blocks() now incorrectly calls xfs_inobt_init_cursor() so it is now walking the inobt instead of the finobt. Hence when there are lots of allocated inodes in a filesystem, mount takes a -long- time run because it now walks a massive allocated inode btrees instead of the small, nearly empty free inode btrees. It also means all the finobt space reservations are wrong, so mount could potentially given ENOSPC on kernel upgrade. In hindsight, commit 14dd46cf31 should have been two commits - the first to convert the finobt callers to the new API, the second to modify the xfs_inobt_init_cursor() API for the inobt callers. That would have made the bug very obvious during review. Fixes: 14dd46cf31 ("xfs: split xfs_inobt_init_cursor") Reported-by: Anders Blomdell <anders.blomdell@gmail.com> Signed-off-by: Dave Chinner <dchinner@redhat.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Darrick J. Wong <djwong@kernel.org> Signed-off-by: Darrick J. Wong <djwong@kernel.org> Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>		2024-08-26 09:52:00 +05:30
..
xfs_ag_resv.c	xfs: split xfs_mod_freecounter	2024-04-22 18:00:47 +05:30
xfs_ag_resv.h	xfs: get rid of xfs_ag_resv_rmapbt_alloc	2024-07-04 14:36:13 +05:30
xfs_ag.c	xfs: convert "skip_discard" to a proper flags bitset	2024-07-02 11:37:01 -07:00
xfs_ag.h	xfs: hook live rmap operations during a repair operation	2024-02-22 12:43:40 -08:00
xfs_alloc_btree.c	xfs: Avoid races with cnt_btree lastrec updates	2024-07-04 12:44:16 +05:30
xfs_alloc_btree.h	xfs: split xfs_allocbt_init_cursor	2024-02-22 12:40:12 -08:00
xfs_alloc.c	xfs: Avoid races with cnt_btree lastrec updates	2024-07-04 12:44:16 +05:30
xfs_alloc.h	xfs: move xfs_extent_free_defer_add to xfs_extfree_item.c	2024-07-02 11:37:03 -07:00
xfs_attr_leaf.c	xfs: don't remove the attr fork when parent pointers are enabled	2024-04-23 07:47:00 -07:00
xfs_attr_leaf.h	xfs: validate attr leaf buffer owners	2024-04-15 14:58:51 -07:00
xfs_attr_remote.c	xfs: minor cleanups of xfs_attr3_rmt_blocks	2024-05-02 07:48:37 -07:00
xfs_attr_remote.h	xfs: create a helper to compute the blockcount of a max sized remote value	2024-05-02 07:48:36 -07:00
xfs_attr_sf.h	xfs: pass the attr value to put_listent when possible	2024-04-23 07:47:00 -07:00
xfs_attr.c	xfs: fix xfs_init_attr_trans not handling explicit operation codes	2024-05-27 15:55:52 +05:30
xfs_attr.h	xfs: fix xfs_init_attr_trans not handling explicit operation codes	2024-05-27 15:55:52 +05:30
xfs_bit.c
xfs_bit.h
xfs_bmap_btree.c	xfs: convert "skip_discard" to a proper flags bitset	2024-07-02 11:37:01 -07:00
xfs_bmap_btree.h	xfs: remove xfs_bmbt_stage_cursor	2024-02-22 12:39:45 -08:00
xfs_bmap.c	xfs: convert "skip_discard" to a proper flags bitset	2024-07-02 11:37:01 -07:00
xfs_bmap.h	xfs: hoist extent size helpers to libxfs	2024-07-02 11:36:55 -07:00
xfs_btree_mem.c	xfs: launder in-memory btree buffers before transaction commit	2024-02-22 12:43:36 -08:00
xfs_btree_mem.h	xfs: launder in-memory btree buffers before transaction commit	2024-02-22 12:43:36 -08:00
xfs_btree_staging.c	xfs: xfs_btree_bload_prep_block() should use __GFP_NOFAIL	2024-02-28 14:04:30 +05:30
xfs_btree_staging.h	xfs: don't override bc_ops for staging btrees	2024-02-22 12:37:35 -08:00
xfs_btree.c	xfs: Avoid races with cnt_btree lastrec updates	2024-07-04 12:44:16 +05:30
xfs_btree.h	xfs: Avoid races with cnt_btree lastrec updates	2024-07-04 12:44:16 +05:30
xfs_cksum.h
xfs_da_btree.c	xfs: fix error returns from xfs_bmapi_write	2024-04-30 09:45:18 +05:30
xfs_da_btree.h	xfs: create attr log item opcodes and formats for parent pointers	2024-04-23 07:46:57 -07:00
xfs_da_format.h	xfs: turn XFS_ATTR3_RMT_BUF_SPACE into a function	2024-05-02 07:48:36 -07:00
xfs_defer.c	xfs: background AIL push should target physical space	2024-07-04 12:46:46 +05:30
xfs_defer.h	xfs: Increase XFS_DEFER_OPS_NR_INODES to 5	2024-04-15 14:59:01 -07:00
xfs_dir2_block.c	xfs: validate explicit directory block buffer owners	2024-04-15 14:58:52 -07:00
xfs_dir2_data.c	xfs: don't walk off the end of a directory data block	2024-07-01 09:32:29 +05:30
xfs_dir2_leaf.c	xfs: validate explicit directory free block owners	2024-04-15 14:58:52 -07:00
xfs_dir2_node.c	xfs: validate explicit directory free block owners	2024-04-15 14:58:52 -07:00
xfs_dir2_priv.h	xfs: don't walk off the end of a directory data block	2024-07-01 09:32:29 +05:30
xfs_dir2_sf.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_dir2.c	xfs: move dirent update hooks to xfs_dir2.c	2024-07-02 11:37:00 -07:00
xfs_dir2.h	xfs: move dirent update hooks to xfs_dir2.c	2024-07-02 11:37:00 -07:00
xfs_dquot_buf.c	xfs: remove the xfs_dqblk_t typedef	2021-10-14 09:19:33 -07:00
xfs_errortag.h	xfs: add error injection to test file mapping exchange recovery	2024-04-15 14:54:19 -07:00
xfs_exchmaps.c	xfs: refactor dir format helpers	2024-04-26 11:21:46 +05:30
xfs_exchmaps.h	xfs: use atomic extent swapping to fix user file fork data	2024-04-15 14:58:53 -07:00
xfs_format.h	xfs: don't use the incore struct xfs_sb for offsets into struct xfs_dsb	2024-07-02 11:37:00 -07:00
xfs_fs.h	xfs: fix direction in XFS_IOC_EXCHANGE_RANGE	2024-06-26 14:29:25 +05:30
xfs_health.h	xfs: report directory tree corruption in the health information	2024-04-23 16:55:17 -07:00
xfs_ialloc_btree.c	xfs: xfs_finobt_count_blocks() walks the wrong btree	2024-08-26 09:52:00 +05:30
xfs_ialloc_btree.h	xfs: split xfs_inobt_init_cursor	2024-02-22 12:40:49 -08:00
xfs_ialloc.c	xfs: convert "skip_discard" to a proper flags bitset	2024-07-02 11:37:01 -07:00
xfs_ialloc.h	xfs: pass xfs_buf lookup flags to xfs_*read_agi	2024-04-15 14:54:03 -07:00
xfs_iext_tree.c	xfs: use __GFP_NOLOCKDEP instead of GFP_NOFS	2024-02-13 18:07:34 +05:30
xfs_inode_buf.c	xfs: fix di_onlink checking for V1/V2 inodes	2024-08-26 09:50:41 +05:30
xfs_inode_buf.h	xfs: kill xfs_sb_version_has_v3inode()	2021-08-19 10:07:14 -07:00
xfs_inode_fork.c	xfs: simplify iext overflow checking and upgrade	2024-05-03 11:20:06 +05:30
xfs_inode_fork.h	xfs: simplify iext overflow checking and upgrade	2024-05-03 11:20:06 +05:30
xfs_inode_util.c	xfs: hoist inode free function to libxfs	2024-07-02 11:36:59 -07:00
xfs_inode_util.h	xfs: hoist inode free function to libxfs	2024-07-02 11:36:59 -07:00
xfs_log_format.h	xfs: record inode generation in xattr update log intent items	2024-04-23 07:46:57 -07:00
xfs_log_recover.h	xfs: capture inode generation numbers in the ondisk exchmaps log item	2024-04-15 14:54:24 -07:00
xfs_log_rlimit.c	xfs: drop compatibility minimum log size computations for reflink	2024-04-23 07:47:01 -07:00
xfs_ondisk.h	xfs: don't use the incore struct xfs_sb for offsets into struct xfs_dsb	2024-07-02 11:37:00 -07:00
xfs_parent.c	xfs: add raw parent pointer apis to support repair	2024-04-23 07:47:04 -07:00
xfs_parent.h	xfs: add raw parent pointer apis to support repair	2024-04-23 07:47:04 -07:00
xfs_quota_defs.h	xfs: remove unused parameter in macro XFS_DQUOT_LOGRES	2024-07-29 09:29:31 +05:30
xfs_refcount_btree.c	xfs: convert "skip_discard" to a proper flags bitset	2024-07-02 11:37:01 -07:00
xfs_refcount_btree.h	xfs: remove xfs_refcountbt_stage_cursor	2024-02-22 12:39:40 -08:00
xfs_refcount.c	xfs: move xfs_refcount_update_defer_add to xfs_refcount_item.c	2024-07-02 11:37:07 -07:00
xfs_refcount.h	xfs: move xfs_refcount_update_defer_add to xfs_refcount_item.c	2024-07-02 11:37:07 -07:00
xfs_rmap_btree.c	xfs: get rid of xfs_ag_resv_rmapbt_alloc	2024-07-04 14:36:13 +05:30
xfs_rmap_btree.h	xfs: create a shadow rmap btree during rmap repair	2024-02-22 12:43:39 -08:00
xfs_rmap.c	xfs: move xfs_rmap_update_defer_add to xfs_rmap_item.c	2024-07-02 11:37:05 -07:00
xfs_rmap.h	xfs: move xfs_rmap_update_defer_add to xfs_rmap_item.c	2024-07-02 11:37:05 -07:00
xfs_rtbitmap.c	xfs: refactor realtime inode locking	2024-04-22 18:00:47 +05:30
xfs_rtbitmap.h	xfs: refactor realtime inode locking	2024-04-22 18:00:47 +05:30
xfs_sb.c	xfs: make sure sb_fdblocks is non-negative	2024-06-10 11:38:12 +05:30
xfs_sb.h	xfs: allow sunit mount option to repair bad primary sb stripe values	2024-03-25 10:17:18 +05:30
xfs_shared.h	xfs: hoist new inode initialization functions to libxfs	2024-07-02 11:36:57 -07:00
xfs_symlink_remote.c	xfs: pass the owner to xfs_symlink_write_target	2024-04-15 14:58:57 -07:00
xfs_symlink_remote.h	xfs: pass the owner to xfs_symlink_write_target	2024-04-15 14:58:57 -07:00
xfs_trans_inode.c	xfs: implement atime updates in xfs_trans_ichgtime	2024-07-02 11:36:56 -07:00
xfs_trans_resv.c	xfs: remove unused parameter in macro XFS_DQUOT_LOGRES	2024-07-29 09:29:31 +05:30
xfs_trans_resv.h	xfs: rename xfs_*alloc*_log_count to _block_count	2022-04-28 10:25:59 -07:00
xfs_trans_space.c	xfs: Add parent pointers to rename	2024-04-23 07:46:59 -07:00
xfs_trans_space.h	xfs: Add parent pointers to rename	2024-04-23 07:46:59 -07:00
xfs_types.c	xfs: rename xfs_verify_rtext to xfs_verify_rtbext	2023-10-17 16:24:22 -07:00
xfs_types.h	xfs: remove xfs_btnum_t	2024-02-22 12:40:51 -08:00