Daniel Xu c34c338a40 libbpf: Do not close un-owned FD 0 on errors ... Before this patch, btf_new() was liable to close an arbitrary FD 0 if BTF parsing failed. This was because: * btf->fd was initialized to 0 through the calloc() * btf__free() (in the `done` label) closed any FDs >= 0 * btf->fd is left at 0 if parsing fails This issue was discovered on a system using libbpf v0.3 (without BTF_KIND_FLOAT support) but with a kernel that had BTF_KIND_FLOAT types in BTF. Thus, parsing fails. While this patch technically doesn't fix any issues b/c upstream libbpf has BTF_KIND_FLOAT support, it'll help prevent issues in the future if more BTF types are added. It also allow the fix to be backported to older libbpf's. Fixes: 3289959b97 ("libbpf: Support BTF loading and raw data output in both endianness") Signed-off-by: Daniel Xu <dxu@dxuuu.xyz> Signed-off-by: Andrii Nakryiko <andrii@kernel.org> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Acked-by: Yonghong Song <yhs@fb.com> Link: https://lore.kernel.org/bpf/5969bb991adedb03c6ae93e051fd2a00d293cf25.1627513670.git.dxu@dxuuu.xyz		2021-08-07 01:39:15 +02:00
..
api	tools api fs: Cache cgroupfs mount point	2021-02-17 15:09:08 -03:00
bpf	libbpf: Do not close un-owned FD 0 on errors	2021-08-07 01:39:15 +02:00
lockdep	.gitignore: add SPDX License Identifier	2020-03-25 11:50:48 +01:00
perf	libperf: Add tests for perf_evlist__set_leader()	2021-07-09 15:34:41 -03:00
subcmd	tools: Avoid comma separated statements	2020-10-02 10:36:36 -06:00
symbol	libsymbols kallsyms: Move hex2u64 out of header	2020-05-05 16:35:32 -03:00
traceevent	KVM: x86/mmu: Rename "nxe" role bit to "efer_nx" for macro shenanigans	2021-06-24 18:00:41 -04:00
argv_split.c	tools lib: Move argv_{split,free} from tools/perf/util/	2019-07-01 22:50:40 -03:00
bitmap.c	tools lib: Adopt bitmap_intersects() operation from the kernel sources	2021-06-30 15:28:00 -03:00
ctype.c	tools perf: Move from sane_ctype.h obtained from git to the Linux's original	2019-06-25 21:02:47 -03:00
find_bit.c	tools: sync lib/find_bit implementation	2021-05-06 19:24:12 -07:00
hweight.c
rbtree.c	tools/: replace HTTP links with HTTPS ones	2020-08-07 11:33:21 -07:00
str_error_r.c	objtool, perf: Fix GCC 8 -Wrestrict error	2018-03-19 13:51:54 -03:00
string.c	tools lib: Adopt memchr_inv() from kernel	2020-11-27 08:34:52 -03:00
vsprintf.c	perf script: Pad DSO name for --call-trace	2019-05-28 18:37:44 -03:00
zalloc.c	tools lib: Adopt zalloc()/zfree() from tools/perf	2019-07-09 10:13:26 -03:00