Ye Bin 83f99de1b7 ext2: fix race between setxattr and write back ... There's an issue when allocating xattrs as follows: Block Allocation Reservation Windows Map (ext2_try_to_allocate_with_rsv): reservation window 0x000000006f105382 start: 0, end: 0 reservation window 0x000000008fd1a555 start: 1044, end: 1059 Window map complete. kernel BUG at fs/ext2/balloc.c:1158! invalid opcode: 0000 [#1] PREEMPT SMP KASAN RIP: 0010:ext2_try_to_allocate_with_rsv.isra.0+0x15c4/0x1800 Call Trace: <TASK> ext2_new_blocks+0x935/0x1690 ext2_new_block+0x73/0xa0 ext2_xattr_set2+0x74f/0x1730 ext2_xattr_set+0x12b6/0x2260 ext2_xattr_user_set+0x9c/0x110 __vfs_setxattr+0x139/0x1d0 __vfs_setxattr_noperm+0xfc/0x370 __vfs_setxattr_locked+0x205/0x2c0 vfs_setxattr+0x19d/0x3b0 do_setxattr+0xff/0x220 setxattr+0x123/0x150 path_setxattr+0x193/0x1e0 __x64_sys_setxattr+0xc8/0x170 do_syscall_64+0x35/0x80 entry_SYSCALL_64_after_hwframe+0x63/0xcd Above issue may happens as follows: setxattr write back ext2_xattr_set ext2_xattr_set2 ext2_new_block ext2_new_blocks ext2_try_to_allocate_with_rsv alloc_new_reservation --> group=0 [0, 1023] rsv [1016, 1023] do_writepages mpage_writepages write_cache_pages __mpage_writepage ext2_get_block ext2_get_blocks ext2_alloc_branch ext2_new_blocks ext2_try_to_allocate_with_rsv alloc_new_reservation -->group=1 [1024, 2047] rsv [1044, 1059] if ((my_rsv->rsv_start > group_last_block) || (my_rsv->rsv_end < group_first_block) rsv_window_dump BUG(); Now ext2 mkwrite doesn't allocate new blocks so for these cases we may be allocating blocks during writeback. However, there is no protection between ext2_xattr_set() and do_writepages() so these two functions can conflict on handling the reservation window. To solve about issue don't use the reservation window when allocating block for xattr. Signed-off-by: Ye Bin <yebin10@huawei.com> Message-Id: <20230815112612.221145-4-yebin10@huawei.com> Signed-off-by: Jan Kara <jack@suse.cz>		2023-08-16 17:47:37 +02:00
..
acl.c	fs: port acl to mnt_idmap	2023-01-19 09:24:28 +01:00
acl.h	fs: port ->set_acl() to pass mnt_idmap	2023-01-19 09:24:27 +01:00
balloc.c	ext2: fix race between setxattr and write back	2023-08-16 17:47:37 +02:00
dir.c	ext2_find_entry()/ext2_dotdot(): callers don't need page_addr anymore	2023-05-29 11:03:31 +02:00
ext2.h	ext2: introduce new flags argument for ext2_new_blocks()	2023-08-16 17:42:42 +02:00
file.c	\n	2023-06-29 13:39:51 -07:00
ialloc.c	ext2: remove redundant assignment to variable desc and variable best_desc	2023-07-03 14:44:45 +02:00
inode.c	ext2: introduce new flags argument for ext2_new_blocks()	2023-08-16 17:42:42 +02:00
ioctl.c	fs: port inode_owner_or_capable() to mnt_idmap	2023-01-19 09:24:29 +01:00
Kconfig	fs: build the legacy direct I/O code conditionally	2023-01-26 10:30:56 -07:00
Makefile	ext2: Add direct-io trace points	2023-05-16 11:32:42 +02:00
namei.c	ext2_find_entry()/ext2_dotdot(): callers don't need page_addr anymore	2023-05-29 11:03:31 +02:00
super.c	ext2: Drop fragment support	2023-06-13 12:37:31 +02:00
symlink.c	ext2: code cleanup by removing ifdef macro surrounding	2020-05-22 15:11:00 +02:00
trace.c	ext2: Add direct-io trace points	2023-05-16 11:32:42 +02:00
trace.h	ext2: Add direct-io trace points	2023-05-16 11:32:42 +02:00
xattr_security.c	fs: port xattr to mnt_idmap	2023-01-19 09:24:28 +01:00
xattr_trusted.c	fs: port xattr to mnt_idmap	2023-01-19 09:24:28 +01:00
xattr_user.c	fs: port xattr to mnt_idmap	2023-01-19 09:24:28 +01:00
xattr.c	ext2: fix race between setxattr and write back	2023-08-16 17:47:37 +02:00
xattr.h	ext2: code cleanup by removing ifdef macro surrounding	2020-05-22 15:11:00 +02:00