mirror of
https://github.com/torvalds/linux.git
synced 2024-12-27 21:33:00 +00:00
d51a12c962
Smatch complains a lot about endiannes issues on as102: drivers/media/usb/as102/as10x_cmd_stream.c:41:47: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd_stream.c:41:47: expected unsigned short [unsigned] [usertype] proc_id drivers/media/usb/as102/as10x_cmd_stream.c:41:47: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd_stream.c:43:43: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd_stream.c:43:43: expected unsigned short [unsigned] [usertype] pid drivers/media/usb/as102/as10x_cmd_stream.c:43:43: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd_stream.c:98:47: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd_stream.c:98:47: expected unsigned short [unsigned] [usertype] proc_id drivers/media/usb/as102/as10x_cmd_stream.c:98:47: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd_stream.c💯43: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd_stream.c💯43: expected unsigned short [unsigned] [usertype] pid drivers/media/usb/as102/as10x_cmd_stream.c💯43: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd_stream.c:142:48: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd_stream.c:142:48: expected unsigned short [unsigned] [usertype] proc_id drivers/media/usb/as102/as10x_cmd_stream.c:142:48: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd_stream.c:185:47: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd_stream.c:185:47: expected unsigned short [unsigned] [usertype] proc_id drivers/media/usb/as102/as10x_cmd_stream.c:185:47: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd_cfg.c:46:40: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd_cfg.c:46:40: expected unsigned short [unsigned] [usertype] proc_id drivers/media/usb/as102/as10x_cmd_cfg.c:46:40: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd_cfg.c:47:36: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd_cfg.c:47:36: expected unsigned short [unsigned] [usertype] tag drivers/media/usb/as102/as10x_cmd_cfg.c:47:36: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd_cfg.c:48:37: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd_cfg.c:48:37: expected unsigned short [unsigned] [usertype] type drivers/media/usb/as102/as10x_cmd_cfg.c:48:37: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd_cfg.c:72:27: warning: cast to restricted __le32 drivers/media/usb/as102/as10x_cmd_cfg.c:102:40: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd_cfg.c:102:40: expected unsigned short [unsigned] [usertype] proc_id drivers/media/usb/as102/as10x_cmd_cfg.c:102:40: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd_cfg.c:104:50: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd_cfg.c:104:50: expected unsigned int [unsigned] [usertype] value32 drivers/media/usb/as102/as10x_cmd_cfg.c:104:50: got restricted __le32 [usertype] <noident> drivers/media/usb/as102/as10x_cmd_cfg.c:105:36: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd_cfg.c:105:36: expected unsigned short [unsigned] [usertype] tag drivers/media/usb/as102/as10x_cmd_cfg.c:105:36: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd_cfg.c:106:37: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd_cfg.c:106:37: expected unsigned short [unsigned] [usertype] type drivers/media/usb/as102/as10x_cmd_cfg.c:106:37: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd_cfg.c:156:48: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd_cfg.c:156:48: expected unsigned short [unsigned] [usertype] proc_id drivers/media/usb/as102/as10x_cmd_cfg.c:156:48: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd_cfg.c:197:14: warning: cast to restricted __le16 drivers/media/usb/as102/as10x_cmd.c:40:40: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd.c:40:40: expected unsigned short [unsigned] [usertype] proc_id drivers/media/usb/as102/as10x_cmd.c:40:40: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd.c:81:41: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd.c:81:41: expected unsigned short [unsigned] [usertype] proc_id drivers/media/usb/as102/as10x_cmd.c:81:41: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd.c:123:41: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd.c:123:41: expected unsigned short [unsigned] [usertype] proc_id drivers/media/usb/as102/as10x_cmd.c:123:41: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd.c:124:43: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd.c:124:43: expected unsigned int [unsigned] [usertype] freq drivers/media/usb/as102/as10x_cmd.c:124:43: got restricted __le32 [usertype] <noident> drivers/media/usb/as102/as10x_cmd.c:178:48: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd.c:178:48: expected unsigned short [unsigned] [usertype] proc_id drivers/media/usb/as102/as10x_cmd.c:178:48: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd.c:202:17: warning: cast to restricted __le16 drivers/media/usb/as102/as10x_cmd.c:203:24: warning: cast to restricted __le16 drivers/media/usb/as102/as10x_cmd.c:204:24: warning: cast to restricted __le16 drivers/media/usb/as102/as10x_cmd.c:230:48: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd.c:230:48: expected unsigned short [unsigned] [usertype] proc_id drivers/media/usb/as102/as10x_cmd.c:230:48: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd.c:262:25: warning: cast to restricted __le16 drivers/media/usb/as102/as10x_cmd.c:289:48: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd.c:289:48: expected unsigned short [unsigned] [usertype] proc_id drivers/media/usb/as102/as10x_cmd.c:289:48: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd.c:313:17: warning: cast to restricted __le32 drivers/media/usb/as102/as10x_cmd.c:315:17: warning: cast to restricted __le32 drivers/media/usb/as102/as10x_cmd.c:317:17: warning: cast to restricted __le32 drivers/media/usb/as102/as10x_cmd.c:319:17: warning: cast to restricted __le16 drivers/media/usb/as102/as10x_cmd.c:349:48: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd.c:349:48: expected unsigned short [unsigned] [usertype] proc_id drivers/media/usb/as102/as10x_cmd.c:349:48: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd.c:387:29: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd.c:387:29: expected unsigned short [unsigned] [usertype] req_id drivers/media/usb/as102/as10x_cmd.c:387:29: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd.c:388:27: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd.c:388:27: expected unsigned short [unsigned] [usertype] prog drivers/media/usb/as102/as10x_cmd.c:388:27: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd.c:389:30: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd.c:389:30: expected unsigned short [unsigned] [usertype] version drivers/media/usb/as102/as10x_cmd.c:389:30: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd.c:390:31: warning: incorrect type in assignment (different base types) drivers/media/usb/as102/as10x_cmd.c:390:31: expected unsigned short [unsigned] [usertype] data_len drivers/media/usb/as102/as10x_cmd.c:390:31: got restricted __le16 [usertype] <noident> drivers/media/usb/as102/as10x_cmd.c:408:14: warning: cast to restricted __le16 This happens because of the command endiannes that are sent/received to the firmware. So, add the correct endiannes tags to the command fields. Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
202 lines
5.5 KiB
C
202 lines
5.5 KiB
C
/*
|
|
* Abilis Systems Single DVB-T Receiver
|
|
* Copyright (C) 2008 Pierrick Hascoet <pierrick.hascoet@abilis.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2, or (at your option)
|
|
* any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include "as102_drv.h"
|
|
#include "as10x_cmd.h"
|
|
|
|
/***************************/
|
|
/* FUNCTION DEFINITION */
|
|
/***************************/
|
|
|
|
/**
|
|
* as10x_cmd_get_context - Send get context command to AS10x
|
|
* @adap: pointer to AS10x bus adapter
|
|
* @tag: context tag
|
|
* @pvalue: pointer where to store context value read
|
|
*
|
|
* Return 0 on success or negative value in case of error.
|
|
*/
|
|
int as10x_cmd_get_context(struct as10x_bus_adapter_t *adap, uint16_t tag,
|
|
uint32_t *pvalue)
|
|
{
|
|
int error;
|
|
struct as10x_cmd_t *pcmd, *prsp;
|
|
|
|
pcmd = adap->cmd;
|
|
prsp = adap->rsp;
|
|
|
|
/* prepare command */
|
|
as10x_cmd_build(pcmd, (++adap->cmd_xid),
|
|
sizeof(pcmd->body.context.req));
|
|
|
|
/* fill command */
|
|
pcmd->body.context.req.proc_id = cpu_to_le16(CONTROL_PROC_CONTEXT);
|
|
pcmd->body.context.req.tag = cpu_to_le16(tag);
|
|
pcmd->body.context.req.type = cpu_to_le16(GET_CONTEXT_DATA);
|
|
|
|
/* send command */
|
|
if (adap->ops->xfer_cmd) {
|
|
error = adap->ops->xfer_cmd(adap,
|
|
(uint8_t *) pcmd,
|
|
sizeof(pcmd->body.context.req)
|
|
+ HEADER_SIZE,
|
|
(uint8_t *) prsp,
|
|
sizeof(prsp->body.context.rsp)
|
|
+ HEADER_SIZE);
|
|
} else {
|
|
error = AS10X_CMD_ERROR;
|
|
}
|
|
|
|
if (error < 0)
|
|
goto out;
|
|
|
|
/* parse response: context command do not follow the common response */
|
|
/* structure -> specific handling response parse required */
|
|
error = as10x_context_rsp_parse(prsp, CONTROL_PROC_CONTEXT_RSP);
|
|
|
|
if (error == 0) {
|
|
/* Response OK -> get response data */
|
|
*pvalue = le32_to_cpu((__force __le32)prsp->body.context.rsp.reg_val.u.value32);
|
|
/* value returned is always a 32-bit value */
|
|
}
|
|
|
|
out:
|
|
return error;
|
|
}
|
|
|
|
/**
|
|
* as10x_cmd_set_context - send set context command to AS10x
|
|
* @adap: pointer to AS10x bus adapter
|
|
* @tag: context tag
|
|
* @value: value to set in context
|
|
*
|
|
* Return 0 on success or negative value in case of error.
|
|
*/
|
|
int as10x_cmd_set_context(struct as10x_bus_adapter_t *adap, uint16_t tag,
|
|
uint32_t value)
|
|
{
|
|
int error;
|
|
struct as10x_cmd_t *pcmd, *prsp;
|
|
|
|
pcmd = adap->cmd;
|
|
prsp = adap->rsp;
|
|
|
|
/* prepare command */
|
|
as10x_cmd_build(pcmd, (++adap->cmd_xid),
|
|
sizeof(pcmd->body.context.req));
|
|
|
|
/* fill command */
|
|
pcmd->body.context.req.proc_id = cpu_to_le16(CONTROL_PROC_CONTEXT);
|
|
/* pcmd->body.context.req.reg_val.mode initialization is not required */
|
|
pcmd->body.context.req.reg_val.u.value32 = (__force u32)cpu_to_le32(value);
|
|
pcmd->body.context.req.tag = cpu_to_le16(tag);
|
|
pcmd->body.context.req.type = cpu_to_le16(SET_CONTEXT_DATA);
|
|
|
|
/* send command */
|
|
if (adap->ops->xfer_cmd) {
|
|
error = adap->ops->xfer_cmd(adap,
|
|
(uint8_t *) pcmd,
|
|
sizeof(pcmd->body.context.req)
|
|
+ HEADER_SIZE,
|
|
(uint8_t *) prsp,
|
|
sizeof(prsp->body.context.rsp)
|
|
+ HEADER_SIZE);
|
|
} else {
|
|
error = AS10X_CMD_ERROR;
|
|
}
|
|
|
|
if (error < 0)
|
|
goto out;
|
|
|
|
/* parse response: context command do not follow the common response */
|
|
/* structure -> specific handling response parse required */
|
|
error = as10x_context_rsp_parse(prsp, CONTROL_PROC_CONTEXT_RSP);
|
|
|
|
out:
|
|
return error;
|
|
}
|
|
|
|
/**
|
|
* as10x_cmd_eLNA_change_mode - send eLNA change mode command to AS10x
|
|
* @adap: pointer to AS10x bus adapter
|
|
* @mode: mode selected:
|
|
* - ON : 0x0 => eLNA always ON
|
|
* - OFF : 0x1 => eLNA always OFF
|
|
* - AUTO : 0x2 => eLNA follow hysteresis parameters
|
|
* to be ON or OFF
|
|
*
|
|
* Return 0 on success or negative value in case of error.
|
|
*/
|
|
int as10x_cmd_eLNA_change_mode(struct as10x_bus_adapter_t *adap, uint8_t mode)
|
|
{
|
|
int error;
|
|
struct as10x_cmd_t *pcmd, *prsp;
|
|
|
|
pcmd = adap->cmd;
|
|
prsp = adap->rsp;
|
|
|
|
/* prepare command */
|
|
as10x_cmd_build(pcmd, (++adap->cmd_xid),
|
|
sizeof(pcmd->body.cfg_change_mode.req));
|
|
|
|
/* fill command */
|
|
pcmd->body.cfg_change_mode.req.proc_id =
|
|
cpu_to_le16(CONTROL_PROC_ELNA_CHANGE_MODE);
|
|
pcmd->body.cfg_change_mode.req.mode = mode;
|
|
|
|
/* send command */
|
|
if (adap->ops->xfer_cmd) {
|
|
error = adap->ops->xfer_cmd(adap, (uint8_t *) pcmd,
|
|
sizeof(pcmd->body.cfg_change_mode.req)
|
|
+ HEADER_SIZE, (uint8_t *) prsp,
|
|
sizeof(prsp->body.cfg_change_mode.rsp)
|
|
+ HEADER_SIZE);
|
|
} else {
|
|
error = AS10X_CMD_ERROR;
|
|
}
|
|
|
|
if (error < 0)
|
|
goto out;
|
|
|
|
/* parse response */
|
|
error = as10x_rsp_parse(prsp, CONTROL_PROC_ELNA_CHANGE_MODE_RSP);
|
|
|
|
out:
|
|
return error;
|
|
}
|
|
|
|
/**
|
|
* as10x_context_rsp_parse - Parse context command response
|
|
* @prsp: pointer to AS10x command response buffer
|
|
* @proc_id: id of the command
|
|
*
|
|
* Since the contex command response does not follow the common
|
|
* response, a specific parse function is required.
|
|
* Return 0 on success or negative value in case of error.
|
|
*/
|
|
int as10x_context_rsp_parse(struct as10x_cmd_t *prsp, uint16_t proc_id)
|
|
{
|
|
int err;
|
|
|
|
err = prsp->body.context.rsp.error;
|
|
|
|
if ((err == 0) &&
|
|
(le16_to_cpu(prsp->body.context.rsp.proc_id) == proc_id)) {
|
|
return 0;
|
|
}
|
|
return AS10X_CMD_ERROR;
|
|
}
|