mirror of
https://github.com/torvalds/linux.git
synced 2024-11-29 23:51:37 +00:00
21b89120be
Fix following coccicheck warning: ./drivers/phy/hisilicon/phy-hisi-inno-usb2.c:138:1-23: WARNING: Function for_each_child_of_node should have of_node_put() before break Early exits from for_each_child_of_node should decrement the node reference counter. Signed-off-by: Wan Jiabing <wanjiabing@vivo.com> Link: https://lore.kernel.org/r/20211015080154.16016-1-wanjiabing@vivo.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
190 lines
4.5 KiB
C
190 lines
4.5 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* HiSilicon INNO USB2 PHY Driver.
|
|
*
|
|
* Copyright (c) 2016-2017 HiSilicon Technologies Co., Ltd.
|
|
*/
|
|
|
|
#include <linux/clk.h>
|
|
#include <linux/delay.h>
|
|
#include <linux/io.h>
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/phy/phy.h>
|
|
#include <linux/reset.h>
|
|
|
|
#define INNO_PHY_PORT_NUM 2
|
|
#define REF_CLK_STABLE_TIME 100 /* unit:us */
|
|
#define UTMI_CLK_STABLE_TIME 200 /* unit:us */
|
|
#define TEST_CLK_STABLE_TIME 2 /* unit:ms */
|
|
#define PHY_CLK_STABLE_TIME 2 /* unit:ms */
|
|
#define UTMI_RST_COMPLETE_TIME 2 /* unit:ms */
|
|
#define POR_RST_COMPLETE_TIME 300 /* unit:us */
|
|
#define PHY_TEST_DATA GENMASK(7, 0)
|
|
#define PHY_TEST_ADDR GENMASK(15, 8)
|
|
#define PHY_TEST_PORT GENMASK(18, 16)
|
|
#define PHY_TEST_WREN BIT(21)
|
|
#define PHY_TEST_CLK BIT(22) /* rising edge active */
|
|
#define PHY_TEST_RST BIT(23) /* low active */
|
|
#define PHY_CLK_ENABLE BIT(2)
|
|
|
|
struct hisi_inno_phy_port {
|
|
struct reset_control *utmi_rst;
|
|
struct hisi_inno_phy_priv *priv;
|
|
};
|
|
|
|
struct hisi_inno_phy_priv {
|
|
void __iomem *mmio;
|
|
struct clk *ref_clk;
|
|
struct reset_control *por_rst;
|
|
struct hisi_inno_phy_port ports[INNO_PHY_PORT_NUM];
|
|
};
|
|
|
|
static void hisi_inno_phy_write_reg(struct hisi_inno_phy_priv *priv,
|
|
u8 port, u32 addr, u32 data)
|
|
{
|
|
void __iomem *reg = priv->mmio;
|
|
u32 val;
|
|
|
|
val = (data & PHY_TEST_DATA) |
|
|
((addr << 8) & PHY_TEST_ADDR) |
|
|
((port << 16) & PHY_TEST_PORT) |
|
|
PHY_TEST_WREN | PHY_TEST_RST;
|
|
writel(val, reg);
|
|
|
|
val |= PHY_TEST_CLK;
|
|
writel(val, reg);
|
|
|
|
val &= ~PHY_TEST_CLK;
|
|
writel(val, reg);
|
|
}
|
|
|
|
static void hisi_inno_phy_setup(struct hisi_inno_phy_priv *priv)
|
|
{
|
|
/* The phy clk is controlled by the port0 register 0x06. */
|
|
hisi_inno_phy_write_reg(priv, 0, 0x06, PHY_CLK_ENABLE);
|
|
msleep(PHY_CLK_STABLE_TIME);
|
|
}
|
|
|
|
static int hisi_inno_phy_init(struct phy *phy)
|
|
{
|
|
struct hisi_inno_phy_port *port = phy_get_drvdata(phy);
|
|
struct hisi_inno_phy_priv *priv = port->priv;
|
|
int ret;
|
|
|
|
ret = clk_prepare_enable(priv->ref_clk);
|
|
if (ret)
|
|
return ret;
|
|
udelay(REF_CLK_STABLE_TIME);
|
|
|
|
reset_control_deassert(priv->por_rst);
|
|
udelay(POR_RST_COMPLETE_TIME);
|
|
|
|
/* Set up phy registers */
|
|
hisi_inno_phy_setup(priv);
|
|
|
|
reset_control_deassert(port->utmi_rst);
|
|
udelay(UTMI_RST_COMPLETE_TIME);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int hisi_inno_phy_exit(struct phy *phy)
|
|
{
|
|
struct hisi_inno_phy_port *port = phy_get_drvdata(phy);
|
|
struct hisi_inno_phy_priv *priv = port->priv;
|
|
|
|
reset_control_assert(port->utmi_rst);
|
|
reset_control_assert(priv->por_rst);
|
|
clk_disable_unprepare(priv->ref_clk);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct phy_ops hisi_inno_phy_ops = {
|
|
.init = hisi_inno_phy_init,
|
|
.exit = hisi_inno_phy_exit,
|
|
.owner = THIS_MODULE,
|
|
};
|
|
|
|
static int hisi_inno_phy_probe(struct platform_device *pdev)
|
|
{
|
|
struct device *dev = &pdev->dev;
|
|
struct device_node *np = dev->of_node;
|
|
struct hisi_inno_phy_priv *priv;
|
|
struct phy_provider *provider;
|
|
struct device_node *child;
|
|
int i = 0;
|
|
int ret;
|
|
|
|
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
|
|
if (!priv)
|
|
return -ENOMEM;
|
|
|
|
priv->mmio = devm_platform_ioremap_resource(pdev, 0);
|
|
if (IS_ERR(priv->mmio)) {
|
|
ret = PTR_ERR(priv->mmio);
|
|
return ret;
|
|
}
|
|
|
|
priv->ref_clk = devm_clk_get(dev, NULL);
|
|
if (IS_ERR(priv->ref_clk))
|
|
return PTR_ERR(priv->ref_clk);
|
|
|
|
priv->por_rst = devm_reset_control_get_exclusive(dev, NULL);
|
|
if (IS_ERR(priv->por_rst))
|
|
return PTR_ERR(priv->por_rst);
|
|
|
|
for_each_child_of_node(np, child) {
|
|
struct reset_control *rst;
|
|
struct phy *phy;
|
|
|
|
rst = of_reset_control_get_exclusive(child, NULL);
|
|
if (IS_ERR(rst)) {
|
|
of_node_put(child);
|
|
return PTR_ERR(rst);
|
|
}
|
|
|
|
priv->ports[i].utmi_rst = rst;
|
|
priv->ports[i].priv = priv;
|
|
|
|
phy = devm_phy_create(dev, child, &hisi_inno_phy_ops);
|
|
if (IS_ERR(phy)) {
|
|
of_node_put(child);
|
|
return PTR_ERR(phy);
|
|
}
|
|
|
|
phy_set_bus_width(phy, 8);
|
|
phy_set_drvdata(phy, &priv->ports[i]);
|
|
i++;
|
|
|
|
if (i > INNO_PHY_PORT_NUM) {
|
|
dev_warn(dev, "Support %d ports in maximum\n", i);
|
|
of_node_put(child);
|
|
break;
|
|
}
|
|
}
|
|
|
|
provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
|
|
return PTR_ERR_OR_ZERO(provider);
|
|
}
|
|
|
|
static const struct of_device_id hisi_inno_phy_of_match[] = {
|
|
{ .compatible = "hisilicon,inno-usb2-phy", },
|
|
{ .compatible = "hisilicon,hi3798cv200-usb2-phy", },
|
|
{ },
|
|
};
|
|
MODULE_DEVICE_TABLE(of, hisi_inno_phy_of_match);
|
|
|
|
static struct platform_driver hisi_inno_phy_driver = {
|
|
.probe = hisi_inno_phy_probe,
|
|
.driver = {
|
|
.name = "hisi-inno-phy",
|
|
.of_match_table = hisi_inno_phy_of_match,
|
|
}
|
|
};
|
|
module_platform_driver(hisi_inno_phy_driver);
|
|
|
|
MODULE_DESCRIPTION("HiSilicon INNO USB2 PHY Driver");
|
|
MODULE_LICENSE("GPL v2");
|