mirror of
https://github.com/torvalds/linux.git
synced 2024-11-22 20:22:09 +00:00
82887c0beb
The HD-audio i915 binding code contains a single pointer, hdac_acomp, for allowing the access to audio component from the master bind/unbind callbacks. This was needed because the callbacks pass only the device pointer and we can't guarantee the object type assigned to the drvdata (which is free for each controller driver implementation). And this implementation will be a problem if we support multiple components for different DRM drivers, not only i915. As a solution, allocate the audio component object via devres and associate it with the given device, so that the component callbacks can refer to it via devres_find(). The removal of the object is still done half-manually via devres_destroy() to make the code consistent (although it may work without the explicit call). Also, the snd_hda_i915_register_notifier() had the reference to hdac_acomp as well. In this patch, the corresponding code is removed by passing hdac_bus object to the function, too. Signed-off-by: Takashi Iwai <tiwai@suse.de>
61 lines
1.7 KiB
C
61 lines
1.7 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* HD-Audio helpers to sync with i915 driver
|
|
*/
|
|
#ifndef __SOUND_HDA_I915_H
|
|
#define __SOUND_HDA_I915_H
|
|
|
|
#include <drm/drm_audio_component.h>
|
|
|
|
#ifdef CONFIG_SND_HDA_I915
|
|
int snd_hdac_set_codec_wakeup(struct hdac_bus *bus, bool enable);
|
|
int snd_hdac_display_power(struct hdac_bus *bus, bool enable);
|
|
void snd_hdac_i915_set_bclk(struct hdac_bus *bus);
|
|
int snd_hdac_sync_audio_rate(struct hdac_device *codec, hda_nid_t nid,
|
|
int dev_id, int rate);
|
|
int snd_hdac_acomp_get_eld(struct hdac_device *codec, hda_nid_t nid, int dev_id,
|
|
bool *audio_enabled, char *buffer, int max_bytes);
|
|
int snd_hdac_i915_init(struct hdac_bus *bus);
|
|
int snd_hdac_i915_exit(struct hdac_bus *bus);
|
|
int snd_hdac_i915_register_notifier(struct hdac_bus *bus,
|
|
const struct drm_audio_component_audio_ops *ops);
|
|
#else
|
|
static inline int snd_hdac_set_codec_wakeup(struct hdac_bus *bus, bool enable)
|
|
{
|
|
return 0;
|
|
}
|
|
static inline int snd_hdac_display_power(struct hdac_bus *bus, bool enable)
|
|
{
|
|
return 0;
|
|
}
|
|
static inline void snd_hdac_i915_set_bclk(struct hdac_bus *bus)
|
|
{
|
|
}
|
|
static inline int snd_hdac_sync_audio_rate(struct hdac_device *codec,
|
|
hda_nid_t nid, int dev_id, int rate)
|
|
{
|
|
return 0;
|
|
}
|
|
static inline int snd_hdac_acomp_get_eld(struct hdac_device *codec, hda_nid_t nid,
|
|
int dev_id, bool *audio_enabled,
|
|
char *buffer, int max_bytes)
|
|
{
|
|
return -ENODEV;
|
|
}
|
|
static inline int snd_hdac_i915_init(struct hdac_bus *bus)
|
|
{
|
|
return -ENODEV;
|
|
}
|
|
static inline int snd_hdac_i915_exit(struct hdac_bus *bus)
|
|
{
|
|
return 0;
|
|
}
|
|
static inline int snd_hdac_i915_register_notifier(struct hdac_bus *bus,
|
|
const struct drm_audio_component_audio_ops *ops)
|
|
{
|
|
return -ENODEV;
|
|
}
|
|
#endif
|
|
|
|
#endif /* __SOUND_HDA_I915_H */
|