mirror of
https://github.com/torvalds/linux.git
synced 2024-11-14 16:12:02 +00:00
b1b3f49ce4
As suggested by Andrew Morton:
This is a pet peeve of mine. Any time there's a long list of items
(header file inclusions, kconfig entries, array initalisers, etc) and
someone wants to add a new item, they *always* go and stick it at the
end of the list.
Guys, don't do this. Either put the new item into a randomly-chosen
position or, probably better, alphanumerically sort the list.
lets sort all our select statements alphanumerically. This commit was
created by the following perl:
while (<>) {
while (/\\\s*$/) {
$_ .= <>;
}
undef %selects if /^\s*config\s+/;
if (/^\s+select\s+(\w+).*/) {
if (defined($selects{$1})) {
if ($selects{$1} eq $_) {
print STDERR "Warning: removing duplicated $1 entry\n";
} else {
print STDERR "Error: $1 differently selected\n".
"\tOld: $selects{$1}\n".
"\tNew: $_\n";
exit 1;
}
}
$selects{$1} = $_;
next;
}
if (%selects and (/^\s*$/ or /^\s+help/ or /^\s+---help---/ or
/^endif/ or /^endchoice/)) {
foreach $k (sort (keys %selects)) {
print "$selects{$k}";
}
undef %selects;
}
print;
}
if (%selects) {
foreach $k (sort (keys %selects)) {
print "$selects{$k}";
}
}
It found two duplicates:
Warning: removing duplicated S5P_SETUP_MIPIPHY entry
Warning: removing duplicated HARDIRQS_SW_RESEND entry
and they are identical duplicates, hence the shrinkage in the diffstat
of two lines.
We have four testers reporting success of this change (Tony, Stephen,
Linus and Sekhar.)
Acked-by: Jason Cooper <jason@lakedaemon.net>
Acked-by: Tony Lindgren <tony@atomide.com>
Acked-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
81 lines
1.5 KiB
Plaintext
81 lines
1.5 KiB
Plaintext
# Copyright 2009 Samsung Electronics Co.
|
|
# Byungho Min <bhmin@samsung.com>
|
|
#
|
|
# Licensed under GPLv2
|
|
|
|
# Configuration options for the S5PC100 CPU
|
|
|
|
if ARCH_S5PC100
|
|
|
|
config CPU_S5PC100
|
|
bool
|
|
select S5P_EXT_INT
|
|
select SAMSUNG_DMADEV
|
|
help
|
|
Enable S5PC100 CPU support
|
|
|
|
config S5PC100_SETUP_FB_24BPP
|
|
bool
|
|
help
|
|
Common setup code for S5PC1XX with an 24bpp RGB display helper.
|
|
|
|
config S5PC100_SETUP_I2C1
|
|
bool
|
|
help
|
|
Common setup code for i2c bus 1.
|
|
|
|
config S5PC100_SETUP_IDE
|
|
bool
|
|
help
|
|
Common setup code for S5PC100 IDE GPIO configurations
|
|
|
|
config S5PC100_SETUP_KEYPAD
|
|
bool
|
|
help
|
|
Common setup code for KEYPAD GPIO configurations.
|
|
|
|
config S5PC100_SETUP_SDHCI
|
|
bool
|
|
select S5PC100_SETUP_SDHCI_GPIO
|
|
help
|
|
Internal helper functions for S5PC100 based SDHCI systems
|
|
|
|
config S5PC100_SETUP_SDHCI_GPIO
|
|
bool
|
|
help
|
|
Common setup code for SDHCI gpio.
|
|
|
|
config S5PC100_SETUP_SPI
|
|
bool
|
|
help
|
|
Common setup code for SPI GPIO configurations.
|
|
|
|
config MACH_SMDKC100
|
|
bool "SMDKC100"
|
|
select CPU_S5PC100
|
|
select S3C_DEV_FB
|
|
select S3C_DEV_HSMMC
|
|
select S3C_DEV_HSMMC1
|
|
select S3C_DEV_HSMMC2
|
|
select S3C_DEV_I2C1
|
|
select S3C_DEV_RTC
|
|
select S3C_DEV_WDT
|
|
select S5PC100_SETUP_FB_24BPP
|
|
select S5PC100_SETUP_I2C1
|
|
select S5PC100_SETUP_IDE
|
|
select S5PC100_SETUP_KEYPAD
|
|
select S5PC100_SETUP_SDHCI
|
|
select S5P_DEV_FIMC0
|
|
select S5P_DEV_FIMC1
|
|
select S5P_DEV_FIMC2
|
|
select SAMSUNG_DEV_ADC
|
|
select SAMSUNG_DEV_BACKLIGHT
|
|
select SAMSUNG_DEV_IDE
|
|
select SAMSUNG_DEV_KEYPAD
|
|
select SAMSUNG_DEV_PWM
|
|
select SAMSUNG_DEV_TS
|
|
help
|
|
Machine support for the Samsung SMDKC100
|
|
|
|
endif
|