Eric Dumazet 80f8a66ded Revert "wifi: mac80211: fix memory leak in ieee80211_if_add()" ... This reverts commit 13e5afd3d7. ieee80211_if_free() is already called from free_netdev(ndev) because ndev->priv_destructor == ieee80211_if_free syzbot reported: general protection fault, probably for non-canonical address 0xdffffc0000000004: 0000 [#1] PREEMPT SMP KASAN KASAN: null-ptr-deref in range [0x0000000000000020-0x0000000000000027] CPU: 0 PID: 10041 Comm: syz-executor.0 Not tainted 6.2.0-rc2-syzkaller-00388-g55b98837e37d #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022 RIP: 0010:pcpu_get_page_chunk mm/percpu.c:262 [inline] RIP: 0010:pcpu_chunk_addr_search mm/percpu.c:1619 [inline] RIP: 0010:free_percpu mm/percpu.c:2271 [inline] RIP: 0010:free_percpu+0x186/0x10f0 mm/percpu.c:2254 Code: 80 3c 02 00 0f 85 f5 0e 00 00 48 8b 3b 48 01 ef e8 cf b3 0b 00 48 ba 00 00 00 00 00 fc ff df 48 8d 78 20 48 89 f9 48 c1 e9 03 <80> 3c 11 00 0f 85 3b 0e 00 00 48 8b 58 20 48 b8 00 00 00 00 00 fc RSP: 0018:ffffc90004ba7068 EFLAGS: 00010002 RAX: 0000000000000000 RBX: ffff88823ffe2b80 RCX: 0000000000000004 RDX: dffffc0000000000 RSI: ffffffff81c1f4e7 RDI: 0000000000000020 RBP: ffffe8fffe8fc220 R08: 0000000000000005 R09: 0000000000000000 R10: 0000000000000000 R11: 1ffffffff2179ab2 R12: ffff8880b983d000 R13: 0000000000000003 R14: 0000607f450fc220 R15: ffff88823ffe2988 FS: 00007fcb349de700(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 0000001b32220000 CR3: 000000004914f000 CR4: 00000000003506f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: <TASK> netdev_run_todo+0x6bf/0x1100 net/core/dev.c:10352 ieee80211_register_hw+0x2663/0x4040 net/mac80211/main.c:1411 mac80211_hwsim_new_radio+0x2537/0x4d80 drivers/net/wireless/mac80211_hwsim.c:4583 hwsim_new_radio_nl+0xa09/0x10f0 drivers/net/wireless/mac80211_hwsim.c:5176 genl_family_rcv_msg_doit.isra.0+0x1e6/0x2d0 net/netlink/genetlink.c:968 genl_family_rcv_msg net/netlink/genetlink.c:1048 [inline] genl_rcv_msg+0x4ff/0x7e0 net/netlink/genetlink.c:1065 netlink_rcv_skb+0x165/0x440 net/netlink/af_netlink.c:2564 genl_rcv+0x28/0x40 net/netlink/genetlink.c:1076 netlink_unicast_kernel net/netlink/af_netlink.c:1330 [inline] netlink_unicast+0x547/0x7f0 net/netlink/af_netlink.c:1356 netlink_sendmsg+0x91b/0xe10 net/netlink/af_netlink.c:1932 sock_sendmsg_nosec net/socket.c:714 [inline] sock_sendmsg+0xd3/0x120 net/socket.c:734 ____sys_sendmsg+0x712/0x8c0 net/socket.c:2476 ___sys_sendmsg+0x110/0x1b0 net/socket.c:2530 __sys_sendmsg+0xf7/0x1c0 net/socket.c:2559 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd Reported-by: syzbot <syzkaller@googlegroups.com> Fixes: 13e5afd3d7 ("wifi: mac80211: fix memory leak in ieee80211_if_add()") Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Zhengchao Shao <shaozhengchao@huawei.com> Cc: Johannes Berg <johannes.berg@intel.com> Signed-off-by: Kalle Valo <kvalo@kernel.org> Link: https://lore.kernel.org/r/20230113124326.3533978-1-edumazet@google.com		2023-01-16 17:28:52 +02:00
..
6lowpan
9p	9p-for-6.2-rc1	2022-12-23 11:39:18 -08:00
802	treewide: Convert del_timer*() to timer_shutdown*()	2022-12-25 13:38:09 -08:00
8021q	net: Remove the obsolte u64_stats_fetch_*_irq() users (net).	2022-10-28 20:13:54 -07:00
appletalk
atm	driver core: make struct class.dev_uevent() take a const *	2022-11-24 17:12:15 +01:00
ax25	ax25: af_ax25: Remove unnecessary (void*) conversions	2022-11-16 13:31:03 +00:00
batman-adv	Networking changes for 6.2.	2022-12-13 15:47:48 -08:00
bluetooth	Networking changes for 6.2.	2022-12-13 15:47:48 -08:00
bpf	New Feature:	2022-12-17 14:06:53 -06:00
bpfilter
bridge	treewide: Convert del_timer*() to timer_shutdown*()	2022-12-25 13:38:09 -08:00
caif	caif: fix memory leak in cfctrl_linkup_request()	2023-01-05 10:19:36 +01:00
can	Networking changes for 6.2.	2022-12-13 15:47:48 -08:00
ceph	Treewide: Stop corrupting socket's task_frag	2022-12-19 17:28:49 -08:00
core	gro: take care of DODGY packets	2023-01-09 07:37:07 +00:00
dcb	net: dcb: move getapptrust to separate function	2022-11-15 15:27:43 +01:00
dccp	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-11-29 13:04:52 -08:00
dns_resolver	cred: Do not default to init_cred in prepare_kernel_cred()	2022-11-01 10:04:52 -07:00
dsa	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-12-13 09:49:29 +01:00
ethernet	net: ethernet: use sysfs_emit() to instead of scnprintf()	2022-12-07 20:02:44 -08:00
ethtool	net/ethtool/ioctl: split ethtool_get_phy_stats into multiple helpers	2022-12-28 11:55:24 +00:00
hsr	hsr: Use a single struct for self_node.	2022-12-01 20:26:22 -08:00
ieee802154	Merge tag 'ieee802154-for-net-next-2022-12-05' of git://git.kernel.org/pub/scm/linux/kernel/git/sschmidt/wpan-next	2022-12-07 17:33:26 -08:00
ife
ipv4	Including fixes from bpf, wifi, and netfilter.	2023-01-05 12:40:50 -08:00
ipv6	treewide: Convert del_timer*() to timer_shutdown*()	2022-12-25 13:38:09 -08:00
iucv
kcm	kcm: close race conditions on sk_receive_queue	2022-11-15 12:42:26 +01:00
key	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next	2022-11-29 20:50:51 -08:00
l2tp	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-11-29 13:04:52 -08:00
l3mdev
lapb
llc
mac80211	Revert "wifi: mac80211: fix memory leak in ieee80211_if_add()"	2023-01-16 17:28:52 +02:00
mac802154	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-12-08 18:19:59 -08:00
mctp	mctp: Remove device type check at unregister	2022-12-19 17:20:22 -08:00
mpls	net: Remove the obsolte u64_stats_fetch_*_irq() users (net).	2022-10-28 20:13:54 -07:00
mptcp	mptcp: fix lockdep false positive	2022-12-21 18:05:47 -08:00
ncsi	net/ncsi: Silence runtime memcpy() false positive warning	2022-12-06 17:29:14 -08:00
netfilter	Including fixes from bpf, wifi, and netfilter.	2023-01-05 12:40:50 -08:00
netlabel
netlink	Networking changes for 6.2.	2022-12-13 15:47:48 -08:00
netrom
nfc	nfc: Fix potential resource leaks	2022-12-26 09:09:23 +00:00
nsh
openvswitch	net: openvswitch: release vport resources on failure	2022-12-21 17:48:12 -08:00
packet	Networking changes for 6.2.	2022-12-13 15:47:48 -08:00
phonet
psample
qrtr
rds	rds: remove redundant variable total_payload_len	2022-11-04 10:09:50 +00:00
rfkill	driver core: make struct class.dev_uevent() take a const *	2022-11-24 17:12:15 +01:00
rose	rose: Fix NULL pointer dereference in rose_send_frame()	2022-11-02 11:57:30 +00:00
rxrpc	rxrpc: Fix incoming call setup race	2023-01-07 09:30:26 +00:00
sched	Including fixes from bpf, wifi, and netfilter.	2023-01-05 12:40:50 -08:00
sctp	Networking changes for 6.2.	2022-12-13 15:47:48 -08:00
smc	use less confusing names for iov_iter direction initializers	2022-11-25 13:01:55 -05:00
strparser
sunrpc	treewide: Convert del_timer*() to timer_shutdown*()	2022-12-25 13:38:09 -08:00
switchdev
tipc	tipc: fix unexpected link reset due to discovery messages	2023-01-06 12:53:10 +00:00
tls	Networking changes for 6.2.	2022-12-13 15:47:48 -08:00
unix	unix: Fix race in SOCK_SEQPACKET's unix_dgram_sendmsg()	2022-12-15 11:35:18 +01:00
vmw_vsock	Networking changes for 6.2.	2022-12-13 15:47:48 -08:00
wireless	Driver Core changes for 6.2-rc1	2022-12-16 03:54:54 -08:00
x25	net/x25: Fix skb leak in x25_lapb_receive_frame()	2022-11-15 20:22:19 -08:00
xdp	bpf: Expand map key argument of bpf_redirect_map to u64	2022-11-15 09:00:27 -08:00
xfrm	Treewide: Stop corrupting socket's task_frag	2022-12-19 17:28:49 -08:00
compat.c	use less confusing names for iov_iter direction initializers	2022-11-25 13:01:55 -05:00
devres.c
Kconfig
Kconfig.debug
Makefile
socket.c	Networking changes for 6.2.	2022-12-13 15:47:48 -08:00
sysctl_net.c