1
0
mirror of https://github.com/torvalds/linux.git synced 2024-12-14 07:02:23 +00:00
linux/drivers/media/usb
Colin Ian King 801e3659bf media: em28xx: calculate left volume level correctly
The calculation of the left volume looks suspect, the value of
0x1f - ((val << 8) & 0x1f) is always 0x1f. The debug prior to the
assignment of value[1] prints the left volume setting using the
calculation 0x1f - (val >> 8) & 0x1f which looks correct to me.
Fix the left volume by using the correct expression as used in
the debug.

Detected by CoverityScan, CID#146140 ("Wrong operator used")

Fixes: 850d24a5a8 ("[media] em28xx-alsa: add mixer support for AC97 volume controls")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans Verkuil <hansverk@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2017-08-26 14:31:49 -04:00
..
airspy media: usb: constify usb_device_id 2017-08-20 08:04:51 -04:00
as102 media: usb: constify usb_device_id 2017-08-20 08:04:51 -04:00
au0828 media: usb: make i2c_adapter const 2017-08-26 08:41:58 -04:00
b2c2 media: usb: constify usb_device_id 2017-08-20 08:04:51 -04:00
cpia2 media: usb: constify usb_device_id 2017-08-20 08:04:51 -04:00
cx231xx media: usb: make i2c_adapter const 2017-08-26 08:41:58 -04:00
dvb-usb media: rc: rename RC_TYPE_* to RC_PROTO_* and RC_BIT_* to RC_PROTO_BIT_* 2017-08-20 10:02:48 -04:00
dvb-usb-v2 media: rc: rename RC_TYPE_* to RC_PROTO_* and RC_BIT_* to RC_PROTO_BIT_* 2017-08-20 10:02:48 -04:00
em28xx media: em28xx: calculate left volume level correctly 2017-08-26 14:31:49 -04:00
go7007 media: usb: make snd_pcm_hardware const 2017-08-20 08:05:10 -04:00
gspca media: : usb: add const to v4l2_file_operations structures 2017-07-20 16:45:25 -04:00
hackrf media: usb: constify usb_device_id 2017-08-20 08:04:51 -04:00
hdpvr media: usb: make i2c_adapter const 2017-08-26 08:41:58 -04:00
msi2500 media: usb: constify usb_device_id 2017-08-20 08:04:51 -04:00
pulse8-cec media: usb: pulse8-cec: constify serio_device_id 2017-08-20 08:27:13 -04:00
pvrusb2 media: usb: make i2c_adapter const 2017-08-26 08:41:58 -04:00
pwc [media] media drivers: annotate fall-through 2017-05-19 07:10:03 -03:00
rainshadow-cec media: usb: rainshadow-cec: constify serio_device_id 2017-08-20 08:27:29 -04:00
s2255 media: usb: constify usb_device_id 2017-08-20 08:04:51 -04:00
siano [media] siano: make it work again with CONFIG_VMAP_STACK 2017-02-14 18:13:49 -02:00
stk1160 media: usb: make i2c_adapter const 2017-08-26 08:41:58 -04:00
stkwebcam media: usb: constify usb_device_id 2017-08-20 08:04:51 -04:00
tm6000 media: rc: rename RC_TYPE_* to RC_PROTO_* and RC_BIT_* to RC_PROTO_BIT_* 2017-08-20 10:02:48 -04:00
ttusb-budget media: usb: constify usb_device_id 2017-08-20 08:04:51 -04:00
ttusb-dec media: usb: constify usb_device_id 2017-08-20 08:04:51 -04:00
usbtv media: usb: make snd_pcm_hardware const 2017-08-20 08:05:10 -04:00
usbvision media: usb: make i2c_adapter const 2017-08-26 08:41:58 -04:00
uvc media: uvcvideo: Constify video_subdev structures 2017-08-20 08:10:24 -04:00
zr364xx media: zr364xx: constify videobuf_queue_ops structures 2017-08-20 08:07:45 -04:00
Kconfig [media] rainshadow-cec: new RainShadow Tech HDMI CEC driver 2017-04-10 12:42:10 -03:00
Makefile [media] rainshadow-cec: new RainShadow Tech HDMI CEC driver 2017-04-10 12:42:10 -03:00