mirror of
https://github.com/torvalds/linux.git
synced 2024-10-26 06:54:41 +00:00
7f554a3d05
Because there are no memory barriers between the srcu_flip() ->completed increment and the summation of the read-side ->unlock_count[] counters, both the compiler and the CPU can reorder the summation with the ->completed increment. If the updater is preempted long enough during this process, the read-side counters could overflow, resulting in a too-short grace period. This commit therefore adds a memory barrier just after the ->completed increment, ensuring that if the summation misses an increment of ->unlock_count[] from __srcu_read_unlock(), the next __srcu_read_lock() will see the new value of ->completed, thus bounding the number of ->unlock_count[] increments that can be missed to NR_CPUS. The actual overflow computation is more complex due to the possibility of nesting of __srcu_read_lock(). Reported-by: Lance Roy <ldr709@gmail.com> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> |
||
|---|---|---|
| .. | ||
| Makefile | ||
| rcu.h | ||
| rcuperf.c | ||
| rcutorture.c | ||
| srcu.c | ||
| sync.c | ||
| tiny_plugin.h | ||
| tiny.c | ||
| tree_exp.h | ||
| tree_plugin.h | ||
| tree_trace.c | ||
| tree.c | ||
| tree.h | ||
| update.c | ||