mirror of
https://github.com/torvalds/linux.git
synced 2024-11-24 05:02:12 +00:00
7de0869093
We have seen many crashes on powerpc hosts while loading bpf programs.
The problem here is that bpf_int_jit_compile() does a first pass
to compute the program length.
Then it allocates memory to store the generated program and
calls bpf_jit_build_body() a second time (and a third time
later)
What I have observed is that the second bpf_jit_build_body()
could end up using few more words than expected.
If bpf_jit_binary_alloc() put the space for the program
at the end of the allocated page, we then write on
a non mapped memory.
It appears that bpf_jit_emit_tail_call() calls
bpf_jit_emit_common_epilogue() while ctx->seen might not
be stable.
Only after the second pass we can be sure ctx->seen wont be changed.
Trying to avoid a second pass seems quite complex and probably
not worth it.
Fixes:
|
||
|---|---|---|
| .. | ||
| bpf_jit32.h | ||
| bpf_jit64.h | ||
| bpf_jit_asm.S | ||
| bpf_jit_comp64.c | ||
| bpf_jit_comp.c | ||
| bpf_jit.h | ||
| Makefile | ||