linux/sound/soc/sh
Kuninori Morimoto cc64c390b2
ASoC: rsnd: adg: clearly handle clock error / NULL case
This driver is assuming that all adg->clk[i] is not NULL.
Because of this prerequisites, for_each_rsnd_clk() is possible to work
for all clk without checking NULL. In other words, all adg->clk[i]
should not NULL.

Some SoC might doesn't have clk_a/b/c/i. devm_clk_get() returns error in
such case. This driver calls rsnd_adg_null_clk_get() and use null_clk
instead of NULL in such cases.

But devm_clk_get() might returns NULL even though such clocks exist, but
it doesn't mean error (user deliberately chose to disable the feature).
NULL clk itself is not error from clk point of view, but is error from
this driver point of view because it is not assuming such case.

But current code is using IS_ERR() which doesn't care NULL.
This driver uses IS_ERR_OR_NULL() instead of IS_ERR() for clk check.
And it uses ERR_CAST() to clarify null_clk error.

One concern here is that it unconditionally uses null_clk if clk_a/b/c/i
was error. It is correct if it doesn't exist, but is not correct if it
returns error even though it exist.
It needs to check "clock-names" from DT before calling devm_clk_get() to
handling such case. But let's assume it is overkill so far.

Link: https://lore.kernel.org/r/YMCmhfQUimHCSH/n@mwanda
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/87v940wyf9.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
2021-08-20 13:07:26 +01:00
..
rcar ASoC: rsnd: adg: clearly handle clock error / NULL case 2021-08-20 13:07:26 +01:00
dma-sh7760.c ASoC: sh: dma-sh7760: remove unused variable 2021-03-10 13:06:59 +00:00
fsi.c ASoC: fsi: fix spelling mistake 2021-06-18 12:55:19 +01:00
hac.c ASoC: soc-core: remove bus_control 2020-01-21 17:07:08 +00:00
Kconfig ASoC: sh: Add RZ/G2L SSIF-2 driver 2021-08-13 13:17:16 +01:00
Makefile ASoC: sh: Add RZ/G2L SSIF-2 driver 2021-08-13 13:17:16 +01:00
migor.c ASoC: sh: use asoc_substream_to_rtd() 2020-07-23 19:07:25 +01:00
rz-ssi.c ASoC: sh: rz-ssi: Improve error handling in rz_ssi_dma_request function 2021-08-19 18:21:22 +01:00
sh7760-ac97.c ASoC: sh: sh7760-ac97: use modern dai_link style 2019-06-06 21:37:35 +01:00
siu_dai.c ASoC: siu: convert to SPDX identifiers 2018-06-18 12:16:42 +01:00
siu_pcm.c ASoC: sh: siu_pcm: remove unused variable 2021-03-10 13:07:04 +00:00
siu.h ASoC: siu: Fix build error by a wrong const prefix 2021-01-27 12:35:18 +00:00
ssi.c ASoC: ssi: don't use discriminatory terms for debug log 2020-07-14 16:38:24 +01:00