mirror of
https://github.com/torvalds/linux.git
synced 2024-11-25 13:41:51 +00:00
de055e6116
`strncpy` is deprecated for use on NUL-terminated destination strings [1]. We need to prefer more robust and less ambiguous string interfaces. `obj_desc->(type|label)` are expected to be NUL-terminated strings as per "include/linux/fsl/mc.h +143" | ... | * struct fsl_mc_obj_desc - Object descriptor | * @type: Type of object: NULL terminated string | ... It seems `cmd_params->obj_type` is also expected to be a NUL-terminated string. A suitable replacement is `strscpy_pad` due to the fact that it guarantees NUL-termination on the destination buffer whilst keeping the NUL-padding behavior that `strncpy` provides. Padding may not strictly be necessary but let's opt to keep it as this ensures no functional change. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] Link: https://github.com/KSPP/linux/issues/90 Cc: linux-hardening@vger.kernel.org Cc: Kees Cook <keescook@chromium.org> Signed-off-by: Justin Stitt <justinstitt@google.com> Reviewed-by: Kees Cook <keescook@chromium.org> Link: https://lore.kernel.org/r/20230912-strncpy-drivers-bus-fsl-mc-dprc-c-v1-1-cdb56aa3f4f4@google.com Signed-off-by: Kees Cook <keescook@chromium.org> |
||
|---|---|---|
| .. | ||
| dpbp.c | ||
| dpcon.c | ||
| dpmcp.c | ||
| dprc-driver.c | ||
| dprc.c | ||
| fsl-mc-allocator.c | ||
| fsl-mc-bus.c | ||
| fsl-mc-msi.c | ||
| fsl-mc-private.h | ||
| fsl-mc-uapi.c | ||
| Kconfig | ||
| Makefile | ||
| mc-io.c | ||
| mc-sys.c | ||
| obj-api.c | ||