Eric Dumazet 757efd32d5 sctp: fix possible seqlock seadlock in sctp_packet_transmit() ... Dave reported following splat, caused by improper use of IP_INC_STATS_BH() in process context. BUG: using __this_cpu_add() in preemptible [00000000] code: trinity-c117/14551 caller is __this_cpu_preempt_check+0x13/0x20 CPU: 3 PID: 14551 Comm: trinity-c117 Not tainted 3.16.0+ #33 ffffffff9ec898f0 0000000047ea7e23 ffff88022d32f7f0 ffffffff9e7ee207 0000000000000003 ffff88022d32f818 ffffffff9e397eaa ffff88023ee70b40 ffff88022d32f970 ffff8801c026d580 ffff88022d32f828 ffffffff9e397ee3 Call Trace: [<ffffffff9e7ee207>] dump_stack+0x4e/0x7a [<ffffffff9e397eaa>] check_preemption_disabled+0xfa/0x100 [<ffffffff9e397ee3>] __this_cpu_preempt_check+0x13/0x20 [<ffffffffc0839872>] sctp_packet_transmit+0x692/0x710 [sctp] [<ffffffffc082a7f2>] sctp_outq_flush+0x2a2/0xc30 [sctp] [<ffffffff9e0d985c>] ? mark_held_locks+0x7c/0xb0 [<ffffffff9e7f8c6d>] ? _raw_spin_unlock_irqrestore+0x5d/0x80 [<ffffffffc082b99a>] sctp_outq_uncork+0x1a/0x20 [sctp] [<ffffffffc081e112>] sctp_cmd_interpreter.isra.23+0x1142/0x13f0 [sctp] [<ffffffffc081c86b>] sctp_do_sm+0xdb/0x330 [sctp] [<ffffffff9e0b8f1b>] ? preempt_count_sub+0xab/0x100 [<ffffffffc083b350>] ? sctp_cname+0x70/0x70 [sctp] [<ffffffffc08389ca>] sctp_primitive_ASSOCIATE+0x3a/0x50 [sctp] [<ffffffffc083358f>] sctp_sendmsg+0x88f/0xe30 [sctp] [<ffffffff9e0d673a>] ? lock_release_holdtime.part.28+0x9a/0x160 [<ffffffff9e0d62ce>] ? put_lock_stats.isra.27+0xe/0x30 [<ffffffff9e73b624>] inet_sendmsg+0x104/0x220 [<ffffffff9e73b525>] ? inet_sendmsg+0x5/0x220 [<ffffffff9e68ac4e>] sock_sendmsg+0x9e/0xe0 [<ffffffff9e1c0c09>] ? might_fault+0xb9/0xc0 [<ffffffff9e1c0bae>] ? might_fault+0x5e/0xc0 [<ffffffff9e68b234>] SYSC_sendto+0x124/0x1c0 [<ffffffff9e0136b0>] ? syscall_trace_enter+0x250/0x330 [<ffffffff9e68c3ce>] SyS_sendto+0xe/0x10 [<ffffffff9e7f9be4>] tracesys+0xdd/0xe2 This is a followup of commits f1d8cba61c ("inet: fix possible seqlock deadlocks") and 7f88c6b23a ("ipv6: fix possible seqlock deadlock in ip6_finish_output2") Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Hannes Frederic Sowa <hannes@stressinduktion.org> Reported-by: Dave Jones <davej@redhat.com> Acked-by: Neil Horman <nhorman@tuxdriver.com> Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org> Signed-off-by: David S. Miller <davem@davemloft.net>		2014-08-05 16:42:55 -07:00
..
associola.c	net: sctp: inherit auth_capable on INIT collisions	2014-07-22 19:56:58 -07:00
auth.c	net: sctp: cache auth_enable per endpoint	2014-04-18 18:32:00 -04:00
bind_addr.c	sctp: Fix FSF address in file headers	2013-12-06 12:37:56 -05:00
chunk.c	sctp: fix checkpatch errors with space required or prohibited	2013-12-26 13:47:47 -05:00
command.c	sctp: Fix FSF address in file headers	2013-12-06 12:37:56 -05:00
debug.c	sctp: Fix FSF address in file headers	2013-12-06 12:37:56 -05:00
endpointola.c	net: sctp: migrate most recently used transport to ktime	2014-06-11 12:23:17 -07:00
input.c	sctp: remove macros sctp_bh_[un]lock_sock	2014-01-21 18:41:36 -08:00
inqueue.c	sctp: Fix FSF address in file headers	2013-12-06 12:37:56 -05:00
ipv6.c	net: Eliminate no_check from protosw	2014-05-23 16:28:53 -04:00
Kconfig	net: sctp: get rid of SCTP_DBG_TSNS entirely	2013-07-02 00:08:03 -07:00
Makefile
objcnt.c	sctp: fix checkpatch errors with (foo*)|foo * bar|foo* bar	2013-12-26 13:47:47 -05:00
output.c	sctp: fix possible seqlock seadlock in sctp_packet_transmit()	2014-08-05 16:42:55 -07:00
outqueue.c	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2014-01-06 17:37:45 -05:00
primitive.c	sctp: Fix FSF address in file headers	2013-12-06 12:37:56 -05:00
probe.c	sctp: loading sctp when load sctp_probe	2013-12-16 20:04:27 -05:00
proc.c	snmp: fix some left over of snmp stats	2014-05-14 15:33:47 -04:00
protocol.c	net: Eliminate no_check from protosw	2014-05-23 16:28:53 -04:00
sm_make_chunk.c	ktime: add ktime_after and ktime_before helper	2014-06-11 12:23:17 -07:00
sm_sideeffect.c	net: sctp: Don't transition to PF state when transport has exhausted 'Path.Max.Retrans'.	2014-04-27 23:41:14 -04:00
sm_statefuns.c	net: sctp: cache auth_enable per endpoint	2014-04-18 18:32:00 -04:00
sm_statetable.c	sctp: fix checkpatch errors with indent	2013-12-26 13:47:48 -05:00
socket.c	net: Split sk_no_check into sk_no_check_{rx,tx}	2014-05-23 16:28:53 -04:00
ssnmap.c	sctp: Fix FSF address in file headers	2013-12-06 12:37:56 -05:00
sysctl.c	net: sctp: check proc_dointvec result in proc_sctp_do_auth	2014-06-19 21:30:19 -07:00
transport.c	net: sctp: migrate most recently used transport to ktime	2014-06-11 12:23:17 -07:00
tsnmap.c	sctp: Fix FSF address in file headers	2013-12-06 12:37:56 -05:00
ulpevent.c	net: sctp: fix information leaks in ulpevent layer	2014-07-14 14:18:56 -07:00
ulpqueue.c	sctp: add support for busy polling to sctp protocol	2014-04-20 18:18:55 -04:00