Eric Dumazet c3f9b01849 tcp: tcp_release_cb() should release socket ownership ... Lars Persson reported following deadlock : -000 |M:0x0:0x802B6AF8(asm) <-- arch_spin_lock -001 |tcp_v4_rcv(skb = 0x8BD527A0) <-- sk = 0x8BE6B2A0 -002 |ip_local_deliver_finish(skb = 0x8BD527A0) -003 |__netif_receive_skb_core(skb = 0x8BD527A0, ?) -004 |netif_receive_skb(skb = 0x8BD527A0) -005 |elk_poll(napi = 0x8C770500, budget = 64) -006 |net_rx_action(?) -007 |__do_softirq() -008 |do_softirq() -009 |local_bh_enable() -010 |tcp_rcv_established(sk = 0x8BE6B2A0, skb = 0x87D3A9E0, th = 0x814EBE14, ?) -011 |tcp_v4_do_rcv(sk = 0x8BE6B2A0, skb = 0x87D3A9E0) -012 |tcp_delack_timer_handler(sk = 0x8BE6B2A0) -013 |tcp_release_cb(sk = 0x8BE6B2A0) -014 |release_sock(sk = 0x8BE6B2A0) -015 |tcp_sendmsg(?, sk = 0x8BE6B2A0, ?, ?) -016 |sock_sendmsg(sock = 0x8518C4C0, msg = 0x87D8DAA8, size = 4096) -017 |kernel_sendmsg(?, ?, ?, ?, size = 4096) -018 |smb_send_kvec() -019 |smb_send_rqst(server = 0x87C4D400, rqst = 0x87D8DBA0) -020 |cifs_call_async() -021 |cifs_async_writev(wdata = 0x87FD6580) -022 |cifs_writepages(mapping = 0x852096E4, wbc = 0x87D8DC88) -023 |__writeback_single_inode(inode = 0x852095D0, wbc = 0x87D8DC88) -024 |writeback_sb_inodes(sb = 0x87D6D800, wb = 0x87E4A9C0, work = 0x87D8DD88) -025 |__writeback_inodes_wb(wb = 0x87E4A9C0, work = 0x87D8DD88) -026 |wb_writeback(wb = 0x87E4A9C0, work = 0x87D8DD88) -027 |wb_do_writeback(wb = 0x87E4A9C0, force_wait = 0) -028 |bdi_writeback_workfn(work = 0x87E4A9CC) -029 |process_one_work(worker = 0x8B045880, work = 0x87E4A9CC) -030 |worker_thread(__worker = 0x8B045880) -031 |kthread(_create = 0x87CADD90) -032 |ret_from_kernel_thread(asm) Bug occurs because __tcp_checksum_complete_user() enables BH, assuming it is running from softirq context. Lars trace involved a NIC without RX checksum support but other points are problematic as well, like the prequeue stuff. Problem is triggered by a timer, that found socket being owned by user. tcp_release_cb() should call tcp_write_timer_handler() or tcp_delack_timer_handler() in the appropriate context : BH disabled and socket lock held, but 'owned' field cleared, as if they were running from timer handlers. Fixes: 6f458dfb40 ("tcp: improve latencies of timer triggered events") Reported-by: Lars Persson <lars.persson@axis.com> Tested-by: Lars Persson <lars.persson@axis.com> Signed-off-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2014-03-11 16:45:59 -04:00
..
9p
bluetooth	Bluetooth: Add quirk for disabling Delete Stored Link Key command	2014-01-04 20:10:40 +02:00
caif
irda	include/net/: Fix FSF address in file headers	2013-12-06 12:37:56 -05:00
iucv
netfilter	netfilter: nf_tables: fix racy rule deletion	2014-02-06 11:46:06 +01:00
netns	ipv6: add flowlabel_consistency sysctl	2014-01-19 17:12:31 -08:00
nfc	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next into for-davem	2014-01-17 14:43:17 -05:00
phonet
sctp	net: sctp: Fix a_rwnd/rwnd management to reflect real state of the receiver's buffer	2014-02-17 00:16:56 -05:00
tc_act	include/net/: Fix FSF address in file headers	2013-12-06 12:37:56 -05:00
act_api.h	net_sched: act: export tcf_hash_search() instead of tcf_hash_lookup()	2014-01-21 14:43:16 -08:00
addrconf.h	ipv6: enable anycast addresses as source addresses for datagrams	2014-01-22 21:57:05 -08:00
af_ieee802154.h
af_rxrpc.h
af_unix.h
af_vsock.h
ah.h
arp.h	arp: make arp_invalidate static	2013-12-28 17:02:46 -05:00
atmclip.h
ax25.h
ax88796.h
busy_poll.h	sched, net: Fixup busy_loop_us_clock()	2014-01-13 17:39:11 +01:00
cfg80211-wext.h
cfg80211.h	cfg80211: Add a function to get the number of supported channels	2014-01-09 14:24:24 +01:00
checksum.h	net: checksum: fix warning in skb_checksum	2013-11-04 15:27:08 -05:00
cipso_ipv4.h	cipso: cleanup cipso_v4_translate() when !CONFIG_NETLABEL	2013-12-10 17:56:54 -05:00
cls_cgroup.h	net: net_cls: move cgroupfs classid handling into core	2014-01-03 23:41:41 +01:00
codel.h	net: introduce reciprocal_scale helper and convert users	2014-01-21 23:17:20 -08:00
compat.h
datalink.h	net: Move prototype declaration to header file include/net/datalink.h from net/ipx/af_ipx.c	2014-02-09 17:32:50 -08:00
dcbevent.h	include/net/: Fix FSF address in file headers	2013-12-06 12:37:56 -05:00
dcbnl.h	include/net/: Fix FSF address in file headers	2013-12-06 12:37:56 -05:00
dn_dev.h	dn_dev: add support for IFA_FLAGS nl attribute	2013-12-10 21:50:00 -05:00
dn_fib.h
dn_neigh.h
dn_nsp.h
dn_route.h	net: Move prototype declaration to appropriate header file from decnet/af_decnet.c	2014-02-09 17:32:49 -08:00
dn.h	net: Move prototype declaration to header file include/net/dn.h from net/decnet/af_decnet.c	2014-02-09 17:32:49 -08:00
dsa.h
dsfield.h
dst_ops.h
dst.h	net: Add utility functions to clear rxhash	2013-12-17 16:36:21 -05:00
esp.h	net: move pskb_put() to core code	2013-11-07 19:28:58 -05:00
ethoc.h	net: ethoc: set up MII management bus clock	2014-02-04 20:19:51 -08:00
fib_rules.h
firewire.h
flow_keys.h	flow_dissector: factor out the ports extraction in skb_flow_get_ports	2013-10-03 15:36:37 -04:00
flow.h	net: Remove FLOWI_FLAG_CAN_SLEEP	2013-12-06 07:24:39 +01:00
garp.h
gen_stats.h
genetlink.h	genl: Add genlmsg_new_unicast() for unicast message allocation	2014-01-06 15:51:53 -08:00
gre.h	gre_offload: statically build GRE offloading support	2014-01-06 20:28:34 -05:00
gro_cells.h
icmp.h
ieee80211_radiotap.h
ieee802154_netdev.h
ieee802154.h
if_inet6.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2014-01-18 00:55:41 -08:00
inet6_connection_sock.h
inet6_hashtables.h	ipv6: split inet6_ehashfn to hash functions per compilation unit	2013-10-19 19:45:34 -04:00
inet_common.h
inet_connection_sock.h
inet_ecn.h
inet_frag.h	inet: remove old fragmentation hash initializing	2013-10-23 17:01:41 -04:00
inet_hashtables.h	tcp/dccp: remove twchain	2013-10-08 23:19:24 -04:00
inet_sock.h	inet: convert inet_ehash_secret and ipv6_hash_secret to net_get_random_once	2013-10-19 19:45:35 -04:00
inet_timewait_sock.h	ipv6: tcp: fix flowlabel value in ACK messages send from TIME_WAIT	2014-01-17 17:56:33 -08:00
inetpeer.h	ipv4: remove unused function	2013-12-28 17:03:20 -05:00
ip6_checksum.h	net: fix build errors if ipv6 is disabled	2013-10-09 13:04:03 -04:00
ip6_fib.h	ipv6: remove prune parameter for fib6_clean_all	2014-01-02 03:30:35 -05:00
ip6_route.h	IPv6: add the option to use anycast addresses as source addresses in echo reply	2014-01-07 15:51:39 -05:00
ip6_tunnel.h	net: unify the pcpu_tstats and br_cpu_netstats as one	2014-01-04 20:10:24 -05:00
ip_fib.h
ip_tunnels.h	sit: fix panic with route cache in ip tunnels	2014-02-20 13:13:50 -05:00
ip_vs.h	netfilter: push reasm skb through instead of original frag skbs	2013-11-11 00:19:35 -05:00
ip.h	ipv6: make IPV6_RECVPKTINFO work for ipv4 datagrams	2014-01-19 19:53:18 -08:00
ipcomp.h
ipconfig.h
ipv6.h	ipv6: protect protocols not handling ipv4 from v4 connection/bind attempts	2014-01-21 16:59:19 -08:00
ipx.h	net: Move prototype declaration to header file include/net/ipx.h from net/ipx/af_ipx.c	2014-02-09 17:32:50 -08:00
iw_handler.h
lapb.h
lib80211.h
llc_c_ac.h
llc_c_ev.h
llc_c_st.h
llc_conn.h
llc_if.h
llc_pdu.h	net: llc: fix order of evaluation in llc_conn_ac_inc_vr_by_1	2014-01-01 22:22:43 -05:00
llc_s_ac.h
llc_s_ev.h
llc_s_st.h
llc_sap.h
llc.h	llc: make lock static	2014-01-03 20:56:48 -05:00
mac80211.h	mac80211: handle MMPDUs at EOSP correctly	2014-01-10 09:50:02 +01:00
mac802154.h	mac802154: correct a typo in ieee802154_alloc_device() prototype	2013-10-21 18:56:23 -04:00
mip6.h	include/net/: Fix FSF address in file headers	2013-12-06 12:37:56 -05:00
mld.h
mrp.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2013-10-01 17:06:14 -04:00
ndisc.h
neighbour.h	neigh: use NEIGH_VAR_INIT in ndo_neigh_setup functions.	2014-01-16 11:31:58 -08:00
net_namespace.h	net: Move prototype declaration to header file include/net/net_namespace.h from net/ipx/af_ipx.c	2014-02-09 17:32:50 -08:00
net_ratelimit.h
netdma.h
netevent.h
netlabel.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next	2014-01-25 11:17:34 -08:00
netlink.h
netprio_cgroup.h	net: netprio: rename config to be more consistent with cgroup configs	2014-01-03 23:41:42 +01:00
netrom.h
nexthop.h
nl802154.h
p8022.h
ping.h	ipv6: make IPV6_RECVPKTINFO work for ipv4 datagrams	2014-01-19 19:53:18 -08:00
pkt_cls.h	net_sched: optimize tcf_match_indev()	2014-01-13 11:50:15 -08:00
pkt_sched.h	pkt_sched: give visibility to mq slave qdiscs	2013-12-09 19:54:47 -05:00
protocol.h	net: Add GRO support for UDP encapsulating protocols	2014-01-21 18:05:04 -08:00
psnap.h
raw.h
rawv6.h
red.h	reciprocal_divide: update/correction of the algorithm	2014-01-21 23:17:20 -08:00
regulatory.h	cfg80211: make regulatory_hint() remove REGULATORY_CUSTOM_REG	2014-01-13 14:46:58 -05:00
request_sock.h	inet: includes a sock_common in request_sock	2013-10-10 00:08:07 -04:00
rose.h
route.h	ipv4: introduce ip_dst_mtu_maybe_forward and protect forwarding path against pmtu spoofing	2014-01-13 11:22:54 -08:00
rtnetlink.h	rtnetlink: provide api for getting and setting slave info	2014-01-22 21:57:05 -08:00
sch_generic.h	net_sched: add struct net pointer to tcf_proto_ops->dump	2014-01-13 11:50:14 -08:00
scm.h
secure_seq.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2013-10-01 17:06:14 -04:00
slhc_vj.h
snmp.h
sock.h	tcp: tcp_release_cb() should release socket ownership	2014-03-11 16:45:59 -04:00
Space.h	drivers: net: Include new header file in sbni.c	2013-12-19 18:51:20 -05:00
stp.h
tcp_memcontrol.h	tcp_memcontrol: Kill struct tcp_memcontrol	2013-10-21 18:43:02 -04:00
tcp_states.h
tcp.h	net-tcp: fastopen: fix high order allocations	2014-02-22 00:05:21 -05:00
timewait_sock.h
transp_v6.h	ipv6: make IPV6_RECVPKTINFO work for ipv4 datagrams	2014-01-19 19:53:18 -08:00
udp.h	udp: Remove unnecessary semicolon from do{}while (0) macro	2013-11-07 02:14:33 -05:00
udplite.h
vsock_addr.h
vxlan.h	net: Add GRO support for vxlan traffic	2014-01-21 18:05:04 -08:00
wext.h
wimax.h
wpan-phy.h
x25.h
x25device.h
xfrm.h	xfrm: Clone states properly on migration	2014-02-20 14:30:10 +01:00