mirror of
https://github.com/torvalds/linux.git
synced 2024-12-04 18:13:04 +00:00
4f2673b3a2
I have a system with DSA ports, and udhcpcd is configured to bring
interfaces up as soon as they are created.
I create a bridge as follows:
ip link add br0 type bridge
As soon as I create the bridge and udhcpcd brings it up, I also have
avahi which automatically starts sending IPv6 packets to advertise some
local services, and because of that, the br0 bridge joins the following
IPv6 groups due to the code path detailed below:
33:33:ff:6d:c1:9c vid 0
33:33:00:00:00:6a vid 0
33:33:00:00:00:fb vid 0
br_dev_xmit
-> br_multicast_rcv
-> br_ip6_multicast_add_group
-> __br_multicast_add_group
-> br_multicast_host_join
-> br_mdb_notify
This is all fine, but inside br_mdb_notify we have br_mdb_switchdev_host
hooked up, and switchdev will attempt to offload the host joined groups
to an empty list of ports. Of course nobody offloads them.
Then when we add a port to br0:
ip link set swp0 master br0
the bridge doesn't replay the host-joined MDB entries from br_add_if,
and eventually the host joined addresses expire, and a switchdev
notification for deleting it is emitted, but surprise, the original
addition was already completely missed.
The strategy to address this problem is to replay the MDB entries (both
the port ones and the host joined ones) when the new port joins the
bridge, similar to what vxlan_fdb_replay does (in that case, its FDB can
be populated and only then attached to a bridge that you offload).
However there are 2 possibilities: the addresses can be 'pushed' by the
bridge into the port, or the port can 'pull' them from the bridge.
Considering that in the general case, the new port can be really late to
the party, and there may have been many other switchdev ports that
already received the initial notification, we would like to avoid
delivering duplicate events to them, since they might misbehave. And
currently, the bridge calls the entire switchdev notifier chain, whereas
for replaying it should just call the notifier block of the new guy.
But the bridge doesn't know what is the new guy's notifier block, it
just knows where the switchdev notifier chain is. So for simplification,
we make this a driver-initiated pull for now, and the notifier block is
passed as an argument.
To emulate the calling context for mdb objects (deferred and put on the
blocking notifier chain), we must iterate under RCU protection through
the bridge's mdb entries, queue them, and only call them once we're out
of the RCU read-side critical section.
There was some opportunity for reuse between br_mdb_switchdev_host_port,
br_mdb_notify and the newly added br_mdb_queue_one in how the switchdev
mdb object is created, so a helper was created.
Suggested-by: Ido Schimmel <idosch@idosch.org>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
384 lines
10 KiB
C
384 lines
10 KiB
C
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* include/net/switchdev.h - Switch device API
|
|
* Copyright (c) 2014-2015 Jiri Pirko <jiri@resnulli.us>
|
|
* Copyright (c) 2014-2015 Scott Feldman <sfeldma@gmail.com>
|
|
*/
|
|
#ifndef _LINUX_SWITCHDEV_H_
|
|
#define _LINUX_SWITCHDEV_H_
|
|
|
|
#include <linux/netdevice.h>
|
|
#include <linux/notifier.h>
|
|
#include <linux/list.h>
|
|
#include <net/ip_fib.h>
|
|
|
|
#define SWITCHDEV_F_NO_RECURSE BIT(0)
|
|
#define SWITCHDEV_F_SKIP_EOPNOTSUPP BIT(1)
|
|
#define SWITCHDEV_F_DEFER BIT(2)
|
|
|
|
enum switchdev_attr_id {
|
|
SWITCHDEV_ATTR_ID_UNDEFINED,
|
|
SWITCHDEV_ATTR_ID_PORT_STP_STATE,
|
|
SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS,
|
|
SWITCHDEV_ATTR_ID_PORT_PRE_BRIDGE_FLAGS,
|
|
SWITCHDEV_ATTR_ID_PORT_MROUTER,
|
|
SWITCHDEV_ATTR_ID_BRIDGE_AGEING_TIME,
|
|
SWITCHDEV_ATTR_ID_BRIDGE_VLAN_FILTERING,
|
|
SWITCHDEV_ATTR_ID_BRIDGE_VLAN_PROTOCOL,
|
|
SWITCHDEV_ATTR_ID_BRIDGE_MC_DISABLED,
|
|
SWITCHDEV_ATTR_ID_BRIDGE_MROUTER,
|
|
SWITCHDEV_ATTR_ID_MRP_PORT_ROLE,
|
|
};
|
|
|
|
struct switchdev_brport_flags {
|
|
unsigned long val;
|
|
unsigned long mask;
|
|
};
|
|
|
|
struct switchdev_attr {
|
|
struct net_device *orig_dev;
|
|
enum switchdev_attr_id id;
|
|
u32 flags;
|
|
void *complete_priv;
|
|
void (*complete)(struct net_device *dev, int err, void *priv);
|
|
union {
|
|
u8 stp_state; /* PORT_STP_STATE */
|
|
struct switchdev_brport_flags brport_flags; /* PORT_BRIDGE_FLAGS */
|
|
bool mrouter; /* PORT_MROUTER */
|
|
clock_t ageing_time; /* BRIDGE_AGEING_TIME */
|
|
bool vlan_filtering; /* BRIDGE_VLAN_FILTERING */
|
|
u16 vlan_protocol; /* BRIDGE_VLAN_PROTOCOL */
|
|
bool mc_disabled; /* MC_DISABLED */
|
|
u8 mrp_port_role; /* MRP_PORT_ROLE */
|
|
} u;
|
|
};
|
|
|
|
enum switchdev_obj_id {
|
|
SWITCHDEV_OBJ_ID_UNDEFINED,
|
|
SWITCHDEV_OBJ_ID_PORT_VLAN,
|
|
SWITCHDEV_OBJ_ID_PORT_MDB,
|
|
SWITCHDEV_OBJ_ID_HOST_MDB,
|
|
SWITCHDEV_OBJ_ID_MRP,
|
|
SWITCHDEV_OBJ_ID_RING_TEST_MRP,
|
|
SWITCHDEV_OBJ_ID_RING_ROLE_MRP,
|
|
SWITCHDEV_OBJ_ID_RING_STATE_MRP,
|
|
SWITCHDEV_OBJ_ID_IN_TEST_MRP,
|
|
SWITCHDEV_OBJ_ID_IN_ROLE_MRP,
|
|
SWITCHDEV_OBJ_ID_IN_STATE_MRP,
|
|
};
|
|
|
|
struct switchdev_obj {
|
|
struct list_head list;
|
|
struct net_device *orig_dev;
|
|
enum switchdev_obj_id id;
|
|
u32 flags;
|
|
void *complete_priv;
|
|
void (*complete)(struct net_device *dev, int err, void *priv);
|
|
};
|
|
|
|
/* SWITCHDEV_OBJ_ID_PORT_VLAN */
|
|
struct switchdev_obj_port_vlan {
|
|
struct switchdev_obj obj;
|
|
u16 flags;
|
|
u16 vid;
|
|
};
|
|
|
|
#define SWITCHDEV_OBJ_PORT_VLAN(OBJ) \
|
|
container_of((OBJ), struct switchdev_obj_port_vlan, obj)
|
|
|
|
/* SWITCHDEV_OBJ_ID_PORT_MDB */
|
|
struct switchdev_obj_port_mdb {
|
|
struct switchdev_obj obj;
|
|
unsigned char addr[ETH_ALEN];
|
|
u16 vid;
|
|
};
|
|
|
|
#define SWITCHDEV_OBJ_PORT_MDB(OBJ) \
|
|
container_of((OBJ), struct switchdev_obj_port_mdb, obj)
|
|
|
|
|
|
/* SWITCHDEV_OBJ_ID_MRP */
|
|
struct switchdev_obj_mrp {
|
|
struct switchdev_obj obj;
|
|
struct net_device *p_port;
|
|
struct net_device *s_port;
|
|
u32 ring_id;
|
|
u16 prio;
|
|
};
|
|
|
|
#define SWITCHDEV_OBJ_MRP(OBJ) \
|
|
container_of((OBJ), struct switchdev_obj_mrp, obj)
|
|
|
|
/* SWITCHDEV_OBJ_ID_RING_TEST_MRP */
|
|
struct switchdev_obj_ring_test_mrp {
|
|
struct switchdev_obj obj;
|
|
/* The value is in us and a value of 0 represents to stop */
|
|
u32 interval;
|
|
u8 max_miss;
|
|
u32 ring_id;
|
|
u32 period;
|
|
bool monitor;
|
|
};
|
|
|
|
#define SWITCHDEV_OBJ_RING_TEST_MRP(OBJ) \
|
|
container_of((OBJ), struct switchdev_obj_ring_test_mrp, obj)
|
|
|
|
/* SWICHDEV_OBJ_ID_RING_ROLE_MRP */
|
|
struct switchdev_obj_ring_role_mrp {
|
|
struct switchdev_obj obj;
|
|
u8 ring_role;
|
|
u32 ring_id;
|
|
u8 sw_backup;
|
|
};
|
|
|
|
#define SWITCHDEV_OBJ_RING_ROLE_MRP(OBJ) \
|
|
container_of((OBJ), struct switchdev_obj_ring_role_mrp, obj)
|
|
|
|
struct switchdev_obj_ring_state_mrp {
|
|
struct switchdev_obj obj;
|
|
u8 ring_state;
|
|
u32 ring_id;
|
|
};
|
|
|
|
#define SWITCHDEV_OBJ_RING_STATE_MRP(OBJ) \
|
|
container_of((OBJ), struct switchdev_obj_ring_state_mrp, obj)
|
|
|
|
/* SWITCHDEV_OBJ_ID_IN_TEST_MRP */
|
|
struct switchdev_obj_in_test_mrp {
|
|
struct switchdev_obj obj;
|
|
/* The value is in us and a value of 0 represents to stop */
|
|
u32 interval;
|
|
u32 in_id;
|
|
u32 period;
|
|
u8 max_miss;
|
|
};
|
|
|
|
#define SWITCHDEV_OBJ_IN_TEST_MRP(OBJ) \
|
|
container_of((OBJ), struct switchdev_obj_in_test_mrp, obj)
|
|
|
|
/* SWICHDEV_OBJ_ID_IN_ROLE_MRP */
|
|
struct switchdev_obj_in_role_mrp {
|
|
struct switchdev_obj obj;
|
|
struct net_device *i_port;
|
|
u32 ring_id;
|
|
u16 in_id;
|
|
u8 in_role;
|
|
u8 sw_backup;
|
|
};
|
|
|
|
#define SWITCHDEV_OBJ_IN_ROLE_MRP(OBJ) \
|
|
container_of((OBJ), struct switchdev_obj_in_role_mrp, obj)
|
|
|
|
struct switchdev_obj_in_state_mrp {
|
|
struct switchdev_obj obj;
|
|
u32 in_id;
|
|
u8 in_state;
|
|
};
|
|
|
|
#define SWITCHDEV_OBJ_IN_STATE_MRP(OBJ) \
|
|
container_of((OBJ), struct switchdev_obj_in_state_mrp, obj)
|
|
|
|
typedef int switchdev_obj_dump_cb_t(struct switchdev_obj *obj);
|
|
|
|
enum switchdev_notifier_type {
|
|
SWITCHDEV_FDB_ADD_TO_BRIDGE = 1,
|
|
SWITCHDEV_FDB_DEL_TO_BRIDGE,
|
|
SWITCHDEV_FDB_ADD_TO_DEVICE,
|
|
SWITCHDEV_FDB_DEL_TO_DEVICE,
|
|
SWITCHDEV_FDB_OFFLOADED,
|
|
SWITCHDEV_FDB_FLUSH_TO_BRIDGE,
|
|
|
|
SWITCHDEV_PORT_OBJ_ADD, /* Blocking. */
|
|
SWITCHDEV_PORT_OBJ_DEL, /* Blocking. */
|
|
SWITCHDEV_PORT_ATTR_SET, /* May be blocking . */
|
|
|
|
SWITCHDEV_VXLAN_FDB_ADD_TO_BRIDGE,
|
|
SWITCHDEV_VXLAN_FDB_DEL_TO_BRIDGE,
|
|
SWITCHDEV_VXLAN_FDB_ADD_TO_DEVICE,
|
|
SWITCHDEV_VXLAN_FDB_DEL_TO_DEVICE,
|
|
SWITCHDEV_VXLAN_FDB_OFFLOADED,
|
|
};
|
|
|
|
struct switchdev_notifier_info {
|
|
struct net_device *dev;
|
|
struct netlink_ext_ack *extack;
|
|
};
|
|
|
|
struct switchdev_notifier_fdb_info {
|
|
struct switchdev_notifier_info info; /* must be first */
|
|
const unsigned char *addr;
|
|
u16 vid;
|
|
u8 added_by_user:1,
|
|
offloaded:1;
|
|
};
|
|
|
|
struct switchdev_notifier_port_obj_info {
|
|
struct switchdev_notifier_info info; /* must be first */
|
|
const struct switchdev_obj *obj;
|
|
bool handled;
|
|
};
|
|
|
|
struct switchdev_notifier_port_attr_info {
|
|
struct switchdev_notifier_info info; /* must be first */
|
|
const struct switchdev_attr *attr;
|
|
bool handled;
|
|
};
|
|
|
|
static inline struct net_device *
|
|
switchdev_notifier_info_to_dev(const struct switchdev_notifier_info *info)
|
|
{
|
|
return info->dev;
|
|
}
|
|
|
|
static inline struct netlink_ext_ack *
|
|
switchdev_notifier_info_to_extack(const struct switchdev_notifier_info *info)
|
|
{
|
|
return info->extack;
|
|
}
|
|
|
|
#ifdef CONFIG_NET_SWITCHDEV
|
|
|
|
void switchdev_deferred_process(void);
|
|
int switchdev_port_attr_set(struct net_device *dev,
|
|
const struct switchdev_attr *attr,
|
|
struct netlink_ext_ack *extack);
|
|
int switchdev_port_obj_add(struct net_device *dev,
|
|
const struct switchdev_obj *obj,
|
|
struct netlink_ext_ack *extack);
|
|
int switchdev_port_obj_del(struct net_device *dev,
|
|
const struct switchdev_obj *obj);
|
|
|
|
int register_switchdev_notifier(struct notifier_block *nb);
|
|
int unregister_switchdev_notifier(struct notifier_block *nb);
|
|
int call_switchdev_notifiers(unsigned long val, struct net_device *dev,
|
|
struct switchdev_notifier_info *info,
|
|
struct netlink_ext_ack *extack);
|
|
|
|
int register_switchdev_blocking_notifier(struct notifier_block *nb);
|
|
int unregister_switchdev_blocking_notifier(struct notifier_block *nb);
|
|
int call_switchdev_blocking_notifiers(unsigned long val, struct net_device *dev,
|
|
struct switchdev_notifier_info *info,
|
|
struct netlink_ext_ack *extack);
|
|
|
|
void switchdev_port_fwd_mark_set(struct net_device *dev,
|
|
struct net_device *group_dev,
|
|
bool joining);
|
|
|
|
int switchdev_handle_port_obj_add(struct net_device *dev,
|
|
struct switchdev_notifier_port_obj_info *port_obj_info,
|
|
bool (*check_cb)(const struct net_device *dev),
|
|
int (*add_cb)(struct net_device *dev,
|
|
const struct switchdev_obj *obj,
|
|
struct netlink_ext_ack *extack));
|
|
int switchdev_handle_port_obj_del(struct net_device *dev,
|
|
struct switchdev_notifier_port_obj_info *port_obj_info,
|
|
bool (*check_cb)(const struct net_device *dev),
|
|
int (*del_cb)(struct net_device *dev,
|
|
const struct switchdev_obj *obj));
|
|
|
|
int switchdev_handle_port_attr_set(struct net_device *dev,
|
|
struct switchdev_notifier_port_attr_info *port_attr_info,
|
|
bool (*check_cb)(const struct net_device *dev),
|
|
int (*set_cb)(struct net_device *dev,
|
|
const struct switchdev_attr *attr,
|
|
struct netlink_ext_ack *extack));
|
|
#else
|
|
|
|
static inline void switchdev_deferred_process(void)
|
|
{
|
|
}
|
|
|
|
static inline int switchdev_port_attr_set(struct net_device *dev,
|
|
const struct switchdev_attr *attr,
|
|
struct netlink_ext_ack *extack)
|
|
{
|
|
return -EOPNOTSUPP;
|
|
}
|
|
|
|
static inline int switchdev_port_obj_add(struct net_device *dev,
|
|
const struct switchdev_obj *obj,
|
|
struct netlink_ext_ack *extack)
|
|
{
|
|
return -EOPNOTSUPP;
|
|
}
|
|
|
|
static inline int switchdev_port_obj_del(struct net_device *dev,
|
|
const struct switchdev_obj *obj)
|
|
{
|
|
return -EOPNOTSUPP;
|
|
}
|
|
|
|
static inline int register_switchdev_notifier(struct notifier_block *nb)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline int unregister_switchdev_notifier(struct notifier_block *nb)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline int call_switchdev_notifiers(unsigned long val,
|
|
struct net_device *dev,
|
|
struct switchdev_notifier_info *info,
|
|
struct netlink_ext_ack *extack)
|
|
{
|
|
return NOTIFY_DONE;
|
|
}
|
|
|
|
static inline int
|
|
register_switchdev_blocking_notifier(struct notifier_block *nb)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline int
|
|
unregister_switchdev_blocking_notifier(struct notifier_block *nb)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline int
|
|
call_switchdev_blocking_notifiers(unsigned long val,
|
|
struct net_device *dev,
|
|
struct switchdev_notifier_info *info,
|
|
struct netlink_ext_ack *extack)
|
|
{
|
|
return NOTIFY_DONE;
|
|
}
|
|
|
|
static inline int
|
|
switchdev_handle_port_obj_add(struct net_device *dev,
|
|
struct switchdev_notifier_port_obj_info *port_obj_info,
|
|
bool (*check_cb)(const struct net_device *dev),
|
|
int (*add_cb)(struct net_device *dev,
|
|
const struct switchdev_obj *obj,
|
|
struct netlink_ext_ack *extack))
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline int
|
|
switchdev_handle_port_obj_del(struct net_device *dev,
|
|
struct switchdev_notifier_port_obj_info *port_obj_info,
|
|
bool (*check_cb)(const struct net_device *dev),
|
|
int (*del_cb)(struct net_device *dev,
|
|
const struct switchdev_obj *obj))
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static inline int
|
|
switchdev_handle_port_attr_set(struct net_device *dev,
|
|
struct switchdev_notifier_port_attr_info *port_attr_info,
|
|
bool (*check_cb)(const struct net_device *dev),
|
|
int (*set_cb)(struct net_device *dev,
|
|
const struct switchdev_attr *attr,
|
|
struct netlink_ext_ack *extack))
|
|
{
|
|
return 0;
|
|
}
|
|
#endif
|
|
|
|
#endif /* _LINUX_SWITCHDEV_H_ */
|