mirror of
https://github.com/torvalds/linux.git
synced 2024-12-28 13:51:44 +00:00
7371400431
The libertas driver calls wiphy_unregister() without a prior wiphy_register() when a devices fails initialization. Fix this by introducing a private flag. [ 9.310000] Unable to handle kernel NULL pointer dereference at virtual address 00000000 [...] [ 9.330000] [<c0311310>] (wiphy_unregister+0xfc/0x19c) from [<bf00c9ec>] (lbs_cfg_free+0x70/0x9c [libertas]) [ 9.330000] [<bf00c9ec>] (lbs_cfg_free+0x70/0x9c [libertas]) from [<bf014fdc>] (lbs_remove_card+0x180/0x210 [libertas]) [ 9.330000] [<bf014fdc>] (lbs_remove_card+0x180/0x210 [libertas]) from [<bf035394>] (if_sdio_probe+0xdc4/0xef4 [libertas_sdio]) [ 9.330000] [<bf035394>] (if_sdio_probe+0xdc4/0xef4 [libertas_sdio]) from [<c0230d14>] (sdio_bus_probe+0xd4/0xf0) [ 9.330000] [<c0230d14>] (sdio_bus_probe+0xd4/0xf0) from [<c01a6034>] (driver_probe_device+0xa4/0x174) [ 9.330000] [<c01a6034>] (driver_probe_device+0xa4/0x174) from [<c01a6164>] (__driver_attach+0x60/0x84) [ 9.330000] [<c01a6164>] (__driver_attach+0x60/0x84) from [<c01a5854>] (bus_for_each_dev+0x4c/0x8c) [ 9.330000] [<c01a5854>] (bus_for_each_dev+0x4c/0x8c) from [<c01a50e4>] (bus_add_driver+0xa0/0x228) [ 9.330000] [<c01a50e4>] (bus_add_driver+0xa0/0x228) from [<c01a6470>] (driver_register+0xc0/0x150) [ 9.330000] [<c01a6470>] (driver_register+0xc0/0x150) from [<bf03a06c>] (if_sdio_init_module+0x6c/0x108 [libertas_sdio]) [ 9.330000] [<bf03a06c>] (if_sdio_init_module+0x6c/0x108 [libertas_sdio]) from [<c00263ac>] (do_one_initcall+0x5c/0x1bc) [ 9.330000] [<c00263ac>] (do_one_initcall+0x5c/0x1bc) from [<c0069f80>] (sys_init_module+0xc0/0x1f0) [ 9.330000] [<c0069f80>] (sys_init_module+0xc0/0x1f0) from [<c0026f00>] (ret_fast_syscall+0x0/0x30) Signed-off-by: Daniel Mack <daniel@caiaq.de> Cc: Dan Williams <dcbw@redhat.com> Cc: John W. Linville <linville@tuxdriver.com> Cc: Holger Schurig <hs4233@mail.mn-solutions.de> Cc: Bing Zhao <bzhao@marvell.com> Cc: libertas-dev@lists.infradead.org Cc: linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org Signed-off-by: John W. Linville <linville@tuxdriver.com>
206 lines
4.8 KiB
C
206 lines
4.8 KiB
C
/**
|
|
* This file contains definitions and data structures specific
|
|
* to Marvell 802.11 NIC. It contains the Device Information
|
|
* structure struct lbs_private..
|
|
*/
|
|
#ifndef _LBS_DEV_H_
|
|
#define _LBS_DEV_H_
|
|
|
|
#include "mesh.h"
|
|
#include "scan.h"
|
|
#include "assoc.h"
|
|
|
|
#include <linux/kfifo.h>
|
|
|
|
/** sleep_params */
|
|
struct sleep_params {
|
|
uint16_t sp_error;
|
|
uint16_t sp_offset;
|
|
uint16_t sp_stabletime;
|
|
uint8_t sp_calcontrol;
|
|
uint8_t sp_extsleepclk;
|
|
uint16_t sp_reserved;
|
|
};
|
|
|
|
|
|
/** Private structure for the MV device */
|
|
struct lbs_private {
|
|
|
|
/* Basic networking */
|
|
struct net_device *dev;
|
|
u32 connect_status;
|
|
int infra_open;
|
|
struct work_struct mcast_work;
|
|
u32 nr_of_multicastmacaddr;
|
|
u8 multicastlist[MRVDRV_MAX_MULTICAST_LIST_SIZE][ETH_ALEN];
|
|
|
|
/* CFG80211 */
|
|
struct wireless_dev *wdev;
|
|
bool wiphy_registered;
|
|
|
|
/* Mesh */
|
|
struct net_device *mesh_dev; /* Virtual device */
|
|
#ifdef CONFIG_LIBERTAS_MESH
|
|
u32 mesh_connect_status;
|
|
struct lbs_mesh_stats mstats;
|
|
int mesh_open;
|
|
uint16_t mesh_tlv;
|
|
u8 mesh_ssid[IEEE80211_MAX_SSID_LEN + 1];
|
|
u8 mesh_ssid_len;
|
|
#endif
|
|
|
|
/* Monitor mode */
|
|
struct net_device *rtap_net_dev;
|
|
u32 monitormode;
|
|
|
|
/* Debugfs */
|
|
struct dentry *debugfs_dir;
|
|
struct dentry *debugfs_debug;
|
|
struct dentry *debugfs_files[6];
|
|
struct dentry *events_dir;
|
|
struct dentry *debugfs_events_files[6];
|
|
struct dentry *regs_dir;
|
|
struct dentry *debugfs_regs_files[6];
|
|
|
|
/* Hardware debugging */
|
|
u32 mac_offset;
|
|
u32 bbp_offset;
|
|
u32 rf_offset;
|
|
struct lbs_offset_value offsetvalue;
|
|
|
|
/* Power management */
|
|
u16 psmode;
|
|
u32 psstate;
|
|
u8 needtowakeup;
|
|
|
|
/* Deep sleep */
|
|
int is_deep_sleep;
|
|
int is_auto_deep_sleep_enabled;
|
|
int wakeup_dev_required;
|
|
int is_activity_detected;
|
|
int auto_deep_sleep_timeout; /* in ms */
|
|
wait_queue_head_t ds_awake_q;
|
|
struct timer_list auto_deepsleep_timer;
|
|
|
|
/* Hardware access */
|
|
void *card;
|
|
u8 fw_ready;
|
|
u8 surpriseremoved;
|
|
int (*hw_host_to_card) (struct lbs_private *priv, u8 type, u8 *payload, u16 nb);
|
|
void (*reset_card) (struct lbs_private *priv);
|
|
int (*enter_deep_sleep) (struct lbs_private *priv);
|
|
int (*exit_deep_sleep) (struct lbs_private *priv);
|
|
int (*reset_deep_sleep_wakeup) (struct lbs_private *priv);
|
|
|
|
/* Adapter info (from EEPROM) */
|
|
u32 fwrelease;
|
|
u32 fwcapinfo;
|
|
u16 regioncode;
|
|
u8 current_addr[ETH_ALEN];
|
|
|
|
/* Command download */
|
|
u8 dnld_sent;
|
|
/* bit0 1/0=data_sent/data_tx_done,
|
|
bit1 1/0=cmd_sent/cmd_tx_done,
|
|
all other bits reserved 0 */
|
|
u16 seqnum;
|
|
struct cmd_ctrl_node *cmd_array;
|
|
struct cmd_ctrl_node *cur_cmd;
|
|
struct list_head cmdfreeq; /* free command buffers */
|
|
struct list_head cmdpendingq; /* pending command buffers */
|
|
wait_queue_head_t cmd_pending;
|
|
struct timer_list command_timer;
|
|
int cmd_timed_out;
|
|
|
|
/* Command responses sent from the hardware to the driver */
|
|
int cur_cmd_retcode;
|
|
u8 resp_idx;
|
|
u8 resp_buf[2][LBS_UPLD_SIZE];
|
|
u32 resp_len[2];
|
|
|
|
/* Events sent from hardware to driver */
|
|
struct kfifo event_fifo;
|
|
|
|
/** thread to service interrupts */
|
|
struct task_struct *main_thread;
|
|
wait_queue_head_t waitq;
|
|
struct workqueue_struct *work_thread;
|
|
|
|
/** Encryption stuff */
|
|
struct lbs_802_11_security secinfo;
|
|
struct enc_key wpa_mcast_key;
|
|
struct enc_key wpa_unicast_key;
|
|
u8 wpa_ie[MAX_WPA_IE_LEN];
|
|
u8 wpa_ie_len;
|
|
u16 wep_tx_keyidx;
|
|
struct enc_key wep_keys[4];
|
|
|
|
/* Wake On LAN */
|
|
uint32_t wol_criteria;
|
|
uint8_t wol_gpio;
|
|
uint8_t wol_gap;
|
|
|
|
/* Transmitting */
|
|
int tx_pending_len; /* -1 while building packet */
|
|
u8 tx_pending_buf[LBS_UPLD_SIZE];
|
|
/* protected by hard_start_xmit serialization */
|
|
u8 txretrycount;
|
|
struct sk_buff *currenttxskb;
|
|
|
|
/* Locks */
|
|
struct mutex lock;
|
|
spinlock_t driver_lock;
|
|
|
|
/* NIC/link operation characteristics */
|
|
u16 mac_control;
|
|
u8 radio_on;
|
|
u8 channel;
|
|
s16 txpower_cur;
|
|
s16 txpower_min;
|
|
s16 txpower_max;
|
|
|
|
/** Scanning */
|
|
struct delayed_work scan_work;
|
|
int scan_channel;
|
|
/* remember which channel was scanned last, != 0 if currently scanning */
|
|
u8 scan_ssid[IEEE80211_MAX_SSID_LEN + 1];
|
|
u8 scan_ssid_len;
|
|
|
|
/* Associating */
|
|
struct delayed_work assoc_work;
|
|
struct current_bss_params curbssparams;
|
|
u8 mode;
|
|
struct list_head network_list;
|
|
struct list_head network_free_list;
|
|
struct bss_descriptor *networks;
|
|
struct assoc_request * pending_assoc_req;
|
|
struct assoc_request * in_progress_assoc_req;
|
|
uint16_t enablehwauto;
|
|
|
|
/* ADHOC */
|
|
u16 beacon_period;
|
|
u8 beacon_enable;
|
|
u8 adhoccreate;
|
|
|
|
/* WEXT */
|
|
char name[DEV_NAME_LEN];
|
|
u8 nodename[16];
|
|
struct iw_statistics wstats;
|
|
u8 cur_rate;
|
|
#define MAX_REGION_CHANNEL_NUM 2
|
|
struct region_channel region_channel[MAX_REGION_CHANNEL_NUM];
|
|
|
|
/** Requested Signal Strength*/
|
|
u16 SNR[MAX_TYPE_B][MAX_TYPE_AVG];
|
|
u16 NF[MAX_TYPE_B][MAX_TYPE_AVG];
|
|
u8 RSSI[MAX_TYPE_B][MAX_TYPE_AVG];
|
|
u8 rawSNR[DEFAULT_DATA_AVG_FACTOR];
|
|
u8 rawNF[DEFAULT_DATA_AVG_FACTOR];
|
|
u16 nextSNRNF;
|
|
u16 numSNRNF;
|
|
};
|
|
|
|
extern struct cmd_confirm_sleep confirm_sleep;
|
|
|
|
#endif
|