mirror of
https://github.com/torvalds/linux.git
synced 2024-11-22 20:22:09 +00:00
0e6255fa3f
The VRTC alarm register can be programmed with an amount of seconds
after which the SoC will be woken up by the VRTC timer again. We are
already converting the alarm time from meson_vrtc_set_alarm() to
"seconds since 1970". This means we also need to use "seconds since
1970" for the current time.
This fixes a problem where setting the alarm to one minute in the future
results in the firmware (which handles wakeup) to output (on the serial
console) that the system will be woken up in billions of seconds.
ktime_get_raw_ts64() returns the time since boot, not since 1970. Switch
to ktime_get_real_ts64() to fix the calculation of the alarm time and to
make the SoC wake up at the specified date/time. Also the firmware
(which manages suspend) now prints either 59 or 60 seconds until wakeup
(depending on how long it takes for the system to enter suspend).
Fixes: 6ef35398e8 ("rtc: Add Amlogic Virtual Wake RTC")
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Link: https://lore.kernel.org/r/20230320212142.2355062-1-martin.blumenstingl@googlemail.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
151 lines
3.5 KiB
C
151 lines
3.5 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Copyright (C) 2019 BayLibre, SAS
|
|
* Author: Neil Armstrong <narmstrong@baylibre.com>
|
|
* Copyright (C) 2015 Amlogic, Inc. All rights reserved.
|
|
*/
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/rtc.h>
|
|
#include <linux/io.h>
|
|
#include <linux/of.h>
|
|
#include <linux/time64.h>
|
|
|
|
struct meson_vrtc_data {
|
|
void __iomem *io_alarm;
|
|
struct rtc_device *rtc;
|
|
unsigned long alarm_time;
|
|
bool enabled;
|
|
};
|
|
|
|
static int meson_vrtc_read_time(struct device *dev, struct rtc_time *tm)
|
|
{
|
|
struct timespec64 time;
|
|
|
|
dev_dbg(dev, "%s\n", __func__);
|
|
ktime_get_real_ts64(&time);
|
|
rtc_time64_to_tm(time.tv_sec, tm);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void meson_vrtc_set_wakeup_time(struct meson_vrtc_data *vrtc,
|
|
unsigned long time)
|
|
{
|
|
writel_relaxed(time, vrtc->io_alarm);
|
|
}
|
|
|
|
static int meson_vrtc_set_alarm(struct device *dev, struct rtc_wkalrm *alarm)
|
|
{
|
|
struct meson_vrtc_data *vrtc = dev_get_drvdata(dev);
|
|
|
|
dev_dbg(dev, "%s: alarm->enabled=%d\n", __func__, alarm->enabled);
|
|
if (alarm->enabled)
|
|
vrtc->alarm_time = rtc_tm_to_time64(&alarm->time);
|
|
else
|
|
vrtc->alarm_time = 0;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int meson_vrtc_alarm_irq_enable(struct device *dev, unsigned int enabled)
|
|
{
|
|
struct meson_vrtc_data *vrtc = dev_get_drvdata(dev);
|
|
|
|
vrtc->enabled = enabled;
|
|
return 0;
|
|
}
|
|
|
|
static const struct rtc_class_ops meson_vrtc_ops = {
|
|
.read_time = meson_vrtc_read_time,
|
|
.set_alarm = meson_vrtc_set_alarm,
|
|
.alarm_irq_enable = meson_vrtc_alarm_irq_enable,
|
|
};
|
|
|
|
static int meson_vrtc_probe(struct platform_device *pdev)
|
|
{
|
|
struct meson_vrtc_data *vrtc;
|
|
|
|
vrtc = devm_kzalloc(&pdev->dev, sizeof(*vrtc), GFP_KERNEL);
|
|
if (!vrtc)
|
|
return -ENOMEM;
|
|
|
|
vrtc->io_alarm = devm_platform_ioremap_resource(pdev, 0);
|
|
if (IS_ERR(vrtc->io_alarm))
|
|
return PTR_ERR(vrtc->io_alarm);
|
|
|
|
device_init_wakeup(&pdev->dev, 1);
|
|
|
|
platform_set_drvdata(pdev, vrtc);
|
|
|
|
vrtc->rtc = devm_rtc_allocate_device(&pdev->dev);
|
|
if (IS_ERR(vrtc->rtc))
|
|
return PTR_ERR(vrtc->rtc);
|
|
|
|
vrtc->rtc->ops = &meson_vrtc_ops;
|
|
return devm_rtc_register_device(vrtc->rtc);
|
|
}
|
|
|
|
static int __maybe_unused meson_vrtc_suspend(struct device *dev)
|
|
{
|
|
struct meson_vrtc_data *vrtc = dev_get_drvdata(dev);
|
|
|
|
dev_dbg(dev, "%s\n", __func__);
|
|
if (vrtc->alarm_time) {
|
|
unsigned long local_time;
|
|
long alarm_secs;
|
|
struct timespec64 time;
|
|
|
|
ktime_get_real_ts64(&time);
|
|
local_time = time.tv_sec;
|
|
|
|
dev_dbg(dev, "alarm_time = %lus, local_time=%lus\n",
|
|
vrtc->alarm_time, local_time);
|
|
alarm_secs = vrtc->alarm_time - local_time;
|
|
if (alarm_secs > 0) {
|
|
meson_vrtc_set_wakeup_time(vrtc, alarm_secs);
|
|
dev_dbg(dev, "system will wakeup in %lds.\n",
|
|
alarm_secs);
|
|
} else {
|
|
dev_err(dev, "alarm time already passed: %lds.\n",
|
|
alarm_secs);
|
|
}
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int __maybe_unused meson_vrtc_resume(struct device *dev)
|
|
{
|
|
struct meson_vrtc_data *vrtc = dev_get_drvdata(dev);
|
|
|
|
dev_dbg(dev, "%s\n", __func__);
|
|
|
|
vrtc->alarm_time = 0;
|
|
meson_vrtc_set_wakeup_time(vrtc, 0);
|
|
return 0;
|
|
}
|
|
|
|
static SIMPLE_DEV_PM_OPS(meson_vrtc_pm_ops,
|
|
meson_vrtc_suspend, meson_vrtc_resume);
|
|
|
|
static const struct of_device_id meson_vrtc_dt_match[] = {
|
|
{ .compatible = "amlogic,meson-vrtc"},
|
|
{},
|
|
};
|
|
MODULE_DEVICE_TABLE(of, meson_vrtc_dt_match);
|
|
|
|
static struct platform_driver meson_vrtc_driver = {
|
|
.probe = meson_vrtc_probe,
|
|
.driver = {
|
|
.name = "meson-vrtc",
|
|
.of_match_table = meson_vrtc_dt_match,
|
|
.pm = &meson_vrtc_pm_ops,
|
|
},
|
|
};
|
|
|
|
module_platform_driver(meson_vrtc_driver);
|
|
|
|
MODULE_DESCRIPTION("Amlogic Virtual Wakeup RTC Timer driver");
|
|
MODULE_LICENSE("GPL");
|