Kemeng Shi 6ee858a3d3 blk-mq: avoid sleep in blk_mq_alloc_request_hctx ... Commit 1f5bd336b9 ("blk-mq: add blk_mq_alloc_request_hctx") add blk_mq_alloc_request_hctx to send commands to a specific queue. If BLK_MQ_REQ_NOWAIT is not set in tag allocation, we may change to different hctx after sleep and get tag from unexpected hctx. So BLK_MQ_REQ_NOWAIT must be set in flags for blk_mq_alloc_request_hctx. After commit 600c3b0cea ("blk-mq: open code __blk_mq_alloc_request in blk_mq_alloc_request_hctx"), blk_mq_alloc_request_hctx return -EINVAL if both BLK_MQ_REQ_NOWAIT and BLK_MQ_REQ_RESERVED are not set instead of if BLK_MQ_REQ_NOWAIT is not set. So if BLK_MQ_REQ_NOWAIT is not set and BLK_MQ_REQ_RESERVED is set, blk_mq_alloc_request_hctx could alloc tag from unexpected hctx. I guess what we need here is that return -EINVAL if either BLK_MQ_REQ_NOWAIT or BLK_MQ_REQ_RESERVED is not set. Currently both BLK_MQ_REQ_NOWAIT and BLK_MQ_REQ_RESERVED will be set if specific hctx is needed in nvme_auth_submit, nvmf_connect_io_queue and nvmf_connect_admin_queue. Fix the potential BLK_MQ_REQ_NOWAIT missed case in future. Fixes: 600c3b0cea ("blk-mq: open code __blk_mq_alloc_request in blk_mq_alloc_request_hctx") Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>		2023-02-06 09:22:28 -07:00
..
partitions	block: don't add partitions if GD_SUPPRESS_PART_SCAN is set	2022-09-03 11:29:03 -06:00
badblocks.c	block/badblocks: Remove redundant assignments	2022-04-23 07:15:26 -06:00
bdev.c	block: bdev & blktrace: use consistent function doc. notation	2022-12-01 09:16:46 -07:00
bfq-cgroup.c	blk-cgroup: move the cgroup information to struct gendisk	2023-02-03 08:20:05 -07:00
bfq-iosched.c	blk-cgroup: pass a gendisk to blkcg_{de,}activate_policy	2023-02-03 08:20:05 -07:00
bfq-iosched.h	block, bfq: remove unused bfq_wr_max_time in struct bfq_data	2023-01-29 20:03:49 -07:00
bfq-wf2q.c	block, bfq: inject I/O to underutilized actuators	2023-01-29 15:18:33 -07:00
bio-integrity.c	block: factor out a bvec_set_page helper	2023-02-03 08:20:54 -07:00
bio.c	block: factor out a bvec_set_page helper	2023-02-03 08:20:54 -07:00
blk-cgroup-fc-appid.c	cgroup: Homogenize cgroup_get_from_id() return value	2022-08-26 10:57:41 -10:00
blk-cgroup-rwstat.c	blk-cgroup: pin the gendisk in struct blkcg_gq	2023-02-03 08:20:05 -07:00
blk-cgroup-rwstat.h	block: Use the new blk_opf_t type	2022-07-14 12:14:30 -06:00
blk-cgroup.c	blk-cgroup: fix freeing NULL blkg in blkg_create	2023-02-06 08:43:23 -07:00
blk-cgroup.h	blk-cgroup: move the cgroup information to struct gendisk	2023-02-03 08:20:05 -07:00
blk-core.c	block: treat poll queue enter similarly to timeouts	2023-01-29 15:18:34 -07:00
blk-crypto-fallback.c	treewide: use get_random_bytes() when possible	2022-10-11 17:42:58 -06:00
blk-crypto-internal.h	blk-crypto: pass a gendisk to blk_crypto_sysfs_{,un}register	2022-11-30 11:09:00 -07:00
blk-crypto-profile.c	blk-crypto: Add a missing include directive	2022-11-23 10:38:54 -07:00
blk-crypto-sysfs.c	block: untangle request_queue refcounting from sysfs	2022-11-30 11:09:00 -07:00
blk-crypto.c	for-6.2/block-2022-12-08	2022-12-13 10:43:59 -08:00
blk-flush.c	block: change request end_io handler to pass back a return value	2022-09-30 07:49:09 -06:00
blk-ia-ranges.c	block: untangle request_queue refcounting from sysfs	2022-11-30 11:09:00 -07:00
blk-integrity.c
blk-ioc.c	block: fix default IO priority handling again	2022-06-27 06:29:12 -06:00
blk-iocost.c	blk-cgroup: pass a gendisk to pd_alloc_fn	2023-02-03 08:20:05 -07:00
blk-iolatency.c	blk-cgroup: move the cgroup information to struct gendisk	2023-02-03 08:20:05 -07:00
blk-ioprio.c	blk-cgroup: pass a gendisk to pd_alloc_fn	2023-02-03 08:20:05 -07:00
blk-ioprio.h	blk-ioprio: pass a gendisk to blk_ioprio_init and blk_ioprio_exit	2022-09-26 19:09:31 -06:00
blk-lib.c	blk-lib: fix blkdev_issue_secure_erase	2022-09-15 00:25:17 -06:00
blk-map.c	block: extend bio-cache for non-polled requests	2023-01-29 15:18:34 -07:00
blk-merge.c	block: don't allow splitting of a REQ_NOWAIT bio	2023-01-04 13:24:44 -07:00
blk-mq-cpumap.c	block: Change the return type of blk_mq_map_queues() into void	2022-08-22 10:07:53 -06:00
blk-mq-debugfs-zoned.c	block: move zone related fields to struct gendisk	2022-07-06 06:46:26 -06:00
blk-mq-debugfs.c	blk-rq-qos: store a gendisk instead of request_queue in struct rq_qos	2023-02-03 08:20:05 -07:00
blk-mq-debugfs.h	block: remove per-disk debugfs files in blk_unregister_queue	2022-06-17 07:31:05 -06:00
blk-mq-pci.c	block: Change the return type of blk_mq_map_queues() into void	2022-08-22 10:07:53 -06:00
blk-mq-rdma.c	block: Change the return type of blk_mq_map_queues() into void	2022-08-22 10:07:53 -06:00
blk-mq-sched.c	block: split elevator_switch	2022-11-01 09:12:24 -06:00
blk-mq-sched.h
blk-mq-sysfs.c	blk-mq: cleanup unused methods: blk_mq_hw_sysfs_store	2023-01-29 15:18:35 -07:00
blk-mq-tag.c	sbitmap: fix batched wait_cnt accounting	2022-09-12 00:10:34 -06:00
blk-mq-tag.h	blk-mq: blk_mq_tag_busy is no need to return a value	2022-06-27 06:29:12 -06:00
blk-mq-virtio.c	block: Change the return type of blk_mq_map_queues() into void	2022-08-22 10:07:53 -06:00
blk-mq.c	blk-mq: avoid sleep in blk_mq_alloc_request_hctx	2023-02-06 09:22:28 -07:00
blk-mq.h	blk-mq: move the srcu_struct used for quiescing to the tagset	2022-11-02 08:35:34 -06:00
blk-pm.c
blk-pm.h
blk-rq-qos.c	blk-rq-qos: store a gendisk instead of request_queue in struct rq_qos	2023-02-03 08:20:05 -07:00
blk-rq-qos.h	blk-rq-qos: store a gendisk instead of request_queue in struct rq_qos	2023-02-03 08:20:05 -07:00
blk-settings.c	blk-wbt: move private information from blk-wbt.h to blk-wbt.c	2023-02-03 08:20:05 -07:00
blk-stat.c	block: don't call blk_throtl_stat_add for non-READ/WRITE commands	2023-02-03 08:20:04 -07:00
blk-stat.h
blk-sysfs.c	blk-wbt: move private information from blk-wbt.h to blk-wbt.c	2023-02-03 08:20:05 -07:00
blk-throttle.c	blk-cgroup: move the cgroup information to struct gendisk	2023-02-03 08:20:05 -07:00
blk-throttle.h	blk-throttle: pass a gendisk to blk_throtl_cancel_bios	2022-09-26 19:17:28 -06:00
blk-timeout.c
blk-wbt.c	blk-rq-qos: store a gendisk instead of request_queue in struct rq_qos	2023-02-03 08:20:05 -07:00
blk-wbt.h	blk-wbt: move private information from blk-wbt.h to blk-wbt.c	2023-02-03 08:20:05 -07:00
blk-zoned.c	block: add a new helper bdev_{is_zone_start, offset_from_zone_start}	2023-01-29 15:18:34 -07:00
blk.h	for-6.2/block-2022-12-08	2022-12-13 10:43:59 -08:00
bounce.c	block: change the blk_queue_bounce calling convention	2022-08-02 17:22:54 -06:00
bsg-lib.c	blk-mq: move the call to blk_put_queue out of blk_mq_destroy_queue	2022-10-25 08:25:10 -06:00
bsg.c	Driver Core changes for 6.2-rc1	2022-12-16 03:54:54 -08:00
disk-events.c
elevator.c	block: untangle request_queue refcounting from sysfs	2022-11-30 11:09:00 -07:00
elevator.h	block: add proper helpers for elevator_type module refcount management	2022-10-23 18:59:17 -06:00
fops.c	block: don't allow multiple bios for IOCB_NOWAIT issue	2023-01-29 15:18:34 -07:00
genhd.c	block: stub out and deprecated the capability attribute on the gendisk	2023-02-06 08:44:55 -07:00
holder.c	block: don't allow a disk link holder to itself	2022-11-16 15:19:56 -07:00
ioctl.c	block: Do not reread partition table on exclusively open device	2022-12-01 07:44:03 -07:00
ioprio.c	block: Fix handling of tasks without ioprio in ioprio_get(2)	2022-06-27 06:29:12 -06:00
Kconfig	block: Remove "select SRCU"	2023-01-05 08:50:10 -07:00
Kconfig.iosched	block: Default to use cgroup support for BFQ	2023-01-30 09:42:42 -07:00
kyber-iosched.c	treewide: Convert del_timer*() to timer_shutdown*()	2022-12-25 13:38:09 -08:00
Makefile	blk-cgroup: move blkcg_{get,set}_fc_appid out of line	2022-05-02 14:06:20 -06:00
mq-deadline.c	block: mq-deadline: Rename deadline_is_seq_writes()	2022-11-28 19:27:45 -07:00
opal_proto.h	block: sed-opal: Add ioctl to return device status	2022-08-22 07:52:51 -06:00
sed-opal.c	for-6.2/block-2022-12-08	2022-12-13 10:43:59 -08:00
t10-pi.c	block: add pi for extended integrity	2022-03-07 12:48:35 -07:00