mirror of
https://github.com/torvalds/linux.git
synced 2024-11-25 13:41:51 +00:00
e97c089d7a
The syzkaller reported an issue: KASAN: null-ptr-deref in range [0x0000000000000380-0x0000000000000387] CPU: 0 PID: 4069 Comm: kworker/0:15 Not tainted 6.0.0-syzkaller-02734-g0326074ff465 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/22/2022 Workqueue: rcu_gp srcu_invoke_callbacks RIP: 0010:rose_send_frame+0x1dd/0x2f0 net/rose/rose_link.c:101 Call Trace: <IRQ> rose_transmit_clear_request+0x1d5/0x290 net/rose/rose_link.c:255 rose_rx_call_request+0x4c0/0x1bc0 net/rose/af_rose.c:1009 rose_loopback_timer+0x19e/0x590 net/rose/rose_loopback.c:111 call_timer_fn+0x1a0/0x6b0 kernel/time/timer.c:1474 expire_timers kernel/time/timer.c:1519 [inline] __run_timers.part.0+0x674/0xa80 kernel/time/timer.c:1790 __run_timers kernel/time/timer.c:1768 [inline] run_timer_softirq+0xb3/0x1d0 kernel/time/timer.c:1803 __do_softirq+0x1d0/0x9c8 kernel/softirq.c:571 [...] </IRQ> It triggers NULL pointer dereference when 'neigh->dev->dev_addr' is called in the rose_send_frame(). It's the first occurrence of the `neigh` is in rose_loopback_timer() as `rose_loopback_neigh', and the 'dev' in 'rose_loopback_neigh' is initialized sa nullptr. It had been fixed by commit3b3fd068c5
("rose: Fix Null pointer dereference in rose_send_frame()") ever. But it's introduced by commit3c53cd65de
("rose: check NULL rose_loopback_neigh->loopback") again. We fix it by add NULL check in rose_transmit_clear_request(). When the 'dev' in 'neigh' is NULL, we don't reply the request and just clear it. syzkaller don't provide repro, and I provide a syz repro like: r0 = syz_init_net_socket$bt_sco(0x1f, 0x5, 0x2) ioctl$sock_inet_SIOCSIFFLAGS(r0, 0x8914, &(0x7f0000000180)={'rose0\x00', 0x201}) r1 = syz_init_net_socket$rose(0xb, 0x5, 0x0) bind$rose(r1, &(0x7f00000000c0)=@full={0xb, @dev, @null, 0x0, [@null, @null, @netrom, @netrom, @default, @null]}, 0x40) connect$rose(r1, &(0x7f0000000240)=@short={0xb, @dev={0xbb, 0xbb, 0xbb, 0x1, 0x0}, @remote={0xcc, 0xcc, 0xcc, 0xcc, 0xcc, 0xcc, 0x1}, 0x1, @netrom={0xbb, 0xbb, 0xbb, 0xbb, 0xbb, 0x0, 0x0}}, 0x1c) Fixes:3c53cd65de
("rose: check NULL rose_loopback_neigh->loopback") Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>
290 lines
6.5 KiB
C
290 lines
6.5 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
*
|
|
* Copyright (C) Jonathan Naylor G4KLX (g4klx@g4klx.demon.co.uk)
|
|
*/
|
|
#include <linux/errno.h>
|
|
#include <linux/types.h>
|
|
#include <linux/socket.h>
|
|
#include <linux/in.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/jiffies.h>
|
|
#include <linux/timer.h>
|
|
#include <linux/string.h>
|
|
#include <linux/sockios.h>
|
|
#include <linux/net.h>
|
|
#include <linux/slab.h>
|
|
#include <net/ax25.h>
|
|
#include <linux/inet.h>
|
|
#include <linux/netdevice.h>
|
|
#include <linux/skbuff.h>
|
|
#include <net/sock.h>
|
|
#include <linux/fcntl.h>
|
|
#include <linux/mm.h>
|
|
#include <linux/interrupt.h>
|
|
#include <net/rose.h>
|
|
|
|
static void rose_ftimer_expiry(struct timer_list *);
|
|
static void rose_t0timer_expiry(struct timer_list *);
|
|
|
|
static void rose_transmit_restart_confirmation(struct rose_neigh *neigh);
|
|
static void rose_transmit_restart_request(struct rose_neigh *neigh);
|
|
|
|
void rose_start_ftimer(struct rose_neigh *neigh)
|
|
{
|
|
del_timer(&neigh->ftimer);
|
|
|
|
neigh->ftimer.function = rose_ftimer_expiry;
|
|
neigh->ftimer.expires =
|
|
jiffies + msecs_to_jiffies(sysctl_rose_link_fail_timeout);
|
|
|
|
add_timer(&neigh->ftimer);
|
|
}
|
|
|
|
static void rose_start_t0timer(struct rose_neigh *neigh)
|
|
{
|
|
del_timer(&neigh->t0timer);
|
|
|
|
neigh->t0timer.function = rose_t0timer_expiry;
|
|
neigh->t0timer.expires =
|
|
jiffies + msecs_to_jiffies(sysctl_rose_restart_request_timeout);
|
|
|
|
add_timer(&neigh->t0timer);
|
|
}
|
|
|
|
void rose_stop_ftimer(struct rose_neigh *neigh)
|
|
{
|
|
del_timer(&neigh->ftimer);
|
|
}
|
|
|
|
void rose_stop_t0timer(struct rose_neigh *neigh)
|
|
{
|
|
del_timer(&neigh->t0timer);
|
|
}
|
|
|
|
int rose_ftimer_running(struct rose_neigh *neigh)
|
|
{
|
|
return timer_pending(&neigh->ftimer);
|
|
}
|
|
|
|
static int rose_t0timer_running(struct rose_neigh *neigh)
|
|
{
|
|
return timer_pending(&neigh->t0timer);
|
|
}
|
|
|
|
static void rose_ftimer_expiry(struct timer_list *t)
|
|
{
|
|
}
|
|
|
|
static void rose_t0timer_expiry(struct timer_list *t)
|
|
{
|
|
struct rose_neigh *neigh = from_timer(neigh, t, t0timer);
|
|
|
|
rose_transmit_restart_request(neigh);
|
|
|
|
neigh->dce_mode = 0;
|
|
|
|
rose_start_t0timer(neigh);
|
|
}
|
|
|
|
/*
|
|
* Interface to ax25_send_frame. Changes my level 2 callsign depending
|
|
* on whether we have a global ROSE callsign or use the default port
|
|
* callsign.
|
|
*/
|
|
static int rose_send_frame(struct sk_buff *skb, struct rose_neigh *neigh)
|
|
{
|
|
const ax25_address *rose_call;
|
|
ax25_cb *ax25s;
|
|
|
|
if (ax25cmp(&rose_callsign, &null_ax25_address) == 0)
|
|
rose_call = (const ax25_address *)neigh->dev->dev_addr;
|
|
else
|
|
rose_call = &rose_callsign;
|
|
|
|
ax25s = neigh->ax25;
|
|
neigh->ax25 = ax25_send_frame(skb, 260, rose_call, &neigh->callsign, neigh->digipeat, neigh->dev);
|
|
if (ax25s)
|
|
ax25_cb_put(ax25s);
|
|
|
|
return neigh->ax25 != NULL;
|
|
}
|
|
|
|
/*
|
|
* Interface to ax25_link_up. Changes my level 2 callsign depending
|
|
* on whether we have a global ROSE callsign or use the default port
|
|
* callsign.
|
|
*/
|
|
static int rose_link_up(struct rose_neigh *neigh)
|
|
{
|
|
const ax25_address *rose_call;
|
|
ax25_cb *ax25s;
|
|
|
|
if (ax25cmp(&rose_callsign, &null_ax25_address) == 0)
|
|
rose_call = (const ax25_address *)neigh->dev->dev_addr;
|
|
else
|
|
rose_call = &rose_callsign;
|
|
|
|
ax25s = neigh->ax25;
|
|
neigh->ax25 = ax25_find_cb(rose_call, &neigh->callsign, neigh->digipeat, neigh->dev);
|
|
if (ax25s)
|
|
ax25_cb_put(ax25s);
|
|
|
|
return neigh->ax25 != NULL;
|
|
}
|
|
|
|
/*
|
|
* This handles all restart and diagnostic frames.
|
|
*/
|
|
void rose_link_rx_restart(struct sk_buff *skb, struct rose_neigh *neigh, unsigned short frametype)
|
|
{
|
|
struct sk_buff *skbn;
|
|
|
|
switch (frametype) {
|
|
case ROSE_RESTART_REQUEST:
|
|
rose_stop_t0timer(neigh);
|
|
neigh->restarted = 1;
|
|
neigh->dce_mode = (skb->data[3] == ROSE_DTE_ORIGINATED);
|
|
rose_transmit_restart_confirmation(neigh);
|
|
break;
|
|
|
|
case ROSE_RESTART_CONFIRMATION:
|
|
rose_stop_t0timer(neigh);
|
|
neigh->restarted = 1;
|
|
break;
|
|
|
|
case ROSE_DIAGNOSTIC:
|
|
pr_warn("ROSE: received diagnostic #%d - %3ph\n", skb->data[3],
|
|
skb->data + 4);
|
|
break;
|
|
|
|
default:
|
|
printk(KERN_WARNING "ROSE: received unknown %02X with LCI 000\n", frametype);
|
|
break;
|
|
}
|
|
|
|
if (neigh->restarted) {
|
|
while ((skbn = skb_dequeue(&neigh->queue)) != NULL)
|
|
if (!rose_send_frame(skbn, neigh))
|
|
kfree_skb(skbn);
|
|
}
|
|
}
|
|
|
|
/*
|
|
* This routine is called when a Restart Request is needed
|
|
*/
|
|
static void rose_transmit_restart_request(struct rose_neigh *neigh)
|
|
{
|
|
struct sk_buff *skb;
|
|
unsigned char *dptr;
|
|
int len;
|
|
|
|
len = AX25_BPQ_HEADER_LEN + AX25_MAX_HEADER_LEN + ROSE_MIN_LEN + 3;
|
|
|
|
if ((skb = alloc_skb(len, GFP_ATOMIC)) == NULL)
|
|
return;
|
|
|
|
skb_reserve(skb, AX25_BPQ_HEADER_LEN + AX25_MAX_HEADER_LEN);
|
|
|
|
dptr = skb_put(skb, ROSE_MIN_LEN + 3);
|
|
|
|
*dptr++ = AX25_P_ROSE;
|
|
*dptr++ = ROSE_GFI;
|
|
*dptr++ = 0x00;
|
|
*dptr++ = ROSE_RESTART_REQUEST;
|
|
*dptr++ = ROSE_DTE_ORIGINATED;
|
|
*dptr++ = 0;
|
|
|
|
if (!rose_send_frame(skb, neigh))
|
|
kfree_skb(skb);
|
|
}
|
|
|
|
/*
|
|
* This routine is called when a Restart Confirmation is needed
|
|
*/
|
|
static void rose_transmit_restart_confirmation(struct rose_neigh *neigh)
|
|
{
|
|
struct sk_buff *skb;
|
|
unsigned char *dptr;
|
|
int len;
|
|
|
|
len = AX25_BPQ_HEADER_LEN + AX25_MAX_HEADER_LEN + ROSE_MIN_LEN + 1;
|
|
|
|
if ((skb = alloc_skb(len, GFP_ATOMIC)) == NULL)
|
|
return;
|
|
|
|
skb_reserve(skb, AX25_BPQ_HEADER_LEN + AX25_MAX_HEADER_LEN);
|
|
|
|
dptr = skb_put(skb, ROSE_MIN_LEN + 1);
|
|
|
|
*dptr++ = AX25_P_ROSE;
|
|
*dptr++ = ROSE_GFI;
|
|
*dptr++ = 0x00;
|
|
*dptr++ = ROSE_RESTART_CONFIRMATION;
|
|
|
|
if (!rose_send_frame(skb, neigh))
|
|
kfree_skb(skb);
|
|
}
|
|
|
|
/*
|
|
* This routine is called when a Clear Request is needed outside of the context
|
|
* of a connected socket.
|
|
*/
|
|
void rose_transmit_clear_request(struct rose_neigh *neigh, unsigned int lci, unsigned char cause, unsigned char diagnostic)
|
|
{
|
|
struct sk_buff *skb;
|
|
unsigned char *dptr;
|
|
int len;
|
|
|
|
if (!neigh->dev)
|
|
return;
|
|
|
|
len = AX25_BPQ_HEADER_LEN + AX25_MAX_HEADER_LEN + ROSE_MIN_LEN + 3;
|
|
|
|
if ((skb = alloc_skb(len, GFP_ATOMIC)) == NULL)
|
|
return;
|
|
|
|
skb_reserve(skb, AX25_BPQ_HEADER_LEN + AX25_MAX_HEADER_LEN);
|
|
|
|
dptr = skb_put(skb, ROSE_MIN_LEN + 3);
|
|
|
|
*dptr++ = AX25_P_ROSE;
|
|
*dptr++ = ((lci >> 8) & 0x0F) | ROSE_GFI;
|
|
*dptr++ = ((lci >> 0) & 0xFF);
|
|
*dptr++ = ROSE_CLEAR_REQUEST;
|
|
*dptr++ = cause;
|
|
*dptr++ = diagnostic;
|
|
|
|
if (!rose_send_frame(skb, neigh))
|
|
kfree_skb(skb);
|
|
}
|
|
|
|
void rose_transmit_link(struct sk_buff *skb, struct rose_neigh *neigh)
|
|
{
|
|
unsigned char *dptr;
|
|
|
|
if (neigh->loopback) {
|
|
rose_loopback_queue(skb, neigh);
|
|
return;
|
|
}
|
|
|
|
if (!rose_link_up(neigh))
|
|
neigh->restarted = 0;
|
|
|
|
dptr = skb_push(skb, 1);
|
|
*dptr++ = AX25_P_ROSE;
|
|
|
|
if (neigh->restarted) {
|
|
if (!rose_send_frame(skb, neigh))
|
|
kfree_skb(skb);
|
|
} else {
|
|
skb_queue_tail(&neigh->queue, skb);
|
|
|
|
if (!rose_t0timer_running(neigh)) {
|
|
rose_transmit_restart_request(neigh);
|
|
neigh->dce_mode = 0;
|
|
rose_start_t0timer(neigh);
|
|
}
|
|
}
|
|
}
|