mirror of
https://github.com/torvalds/linux.git
synced 2024-11-06 03:51:48 +00:00
8356f3113d
A SET_LINE_CODING control request should return a zero length packet as an ACK to the host, during the status phase of a USB transaction. The return value of gs_setup_class() is treated as the number of bytes to write in the status phase of the control request, by gs_setup(). For this case, the value returned by gs_setup_class should be zero for SET_LINE_CODING but, right now, appears to be sizeof(struct usb_cdc_line_coding). However, if after doing the memcpy of the line coding descriptor we set the variable "ret" to be zero, we should return the appropiate ZLP to the host as an ACK in the status phase of the control request. I've tested this out using Linux as both host and slave and confirmed that the following small change fixes the spurious return of sizeof(struct usb_cdc_line_coding)/wLength bytes in the status phase of a USB_CDC_REQ_SET_LINE_CODING request. It's not a huge bug but, it is worth fixing. Signed-off-by: Bryan O'Donoghue <bodonoghue@codehermit.ie> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de> |
||
|---|---|---|
| .. | ||
| at91_udc.c | ||
| at91_udc.h | ||
| config.c | ||
| dummy_hcd.c | ||
| epautoconf.c | ||
| ether.c | ||
| file_storage.c | ||
| gadget_chips.h | ||
| gmidi.c | ||
| goku_udc.c | ||
| goku_udc.h | ||
| inode.c | ||
| Kconfig | ||
| lh7a40x_udc.c | ||
| lh7a40x_udc.h | ||
| Makefile | ||
| ndis.h | ||
| net2280.c | ||
| net2280.h | ||
| omap_udc.c | ||
| omap_udc.h | ||
| pxa2xx_udc.c | ||
| pxa2xx_udc.h | ||
| rndis.c | ||
| rndis.h | ||
| serial.c | ||
| usbstring.c | ||
| zero.c | ||