Eric Dumazet 35d9b0c906 llc: fix a device refcount imbalance ... Le dimanche 05 décembre 2010 à 12:23 +0100, Eric Dumazet a écrit : > Le dimanche 05 décembre 2010 à 09:19 +0100, Eric Dumazet a écrit : > > > Hmm.. > > > > If somebody can explain why RTNL is held in arp_ioctl() (and therefore > > in arp_req_delete()), we might first remove RTNL use in arp_ioctl() so > > that your patch can be applied. > > > > Right now it is not good, because RTNL wont be necessarly held when you > > are going to call arp_invalidate() ? > > While doing this analysis, I found a refcount bug in llc, I'll send a > patch for net-2.6 Oh well, of course I must first fix the bug in net-2.6, and wait David pull the fix in net-next-2.6 before sending this rcu conversion. Note: this patch should be sent to stable teams (2.6.34 and up) [PATCH net-2.6] llc: fix a device refcount imbalance commit abf9d537fe (llc: add support for SO_BINDTODEVICE) added one refcount imbalance in llc_ui_bind(), because dev_getbyhwaddr() doesnt take a reference on device, while dev_get_by_index() does. Fix this using RCU locking. And since an RCU conversion will be done for 2.6.38 for dev_getbyhwaddr(), put the rcu_read_lock/unlock exactly at their final place. Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com> Cc: stable@kernel.org Cc: Octavian Purdila <opurdila@ixiacom.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2010-12-08 09:58:44 -08:00
..
af_llc.c	llc: fix a device refcount imbalance	2010-12-08 09:58:44 -08:00
Kconfig
llc_c_ac.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	2010-03-30 22:02:32 +09:00
llc_c_ev.c	net: replace remaining __FUNCTION__ occurrences	2008-03-05 20:47:47 -08:00
llc_c_st.c
llc_conn.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	2010-03-30 22:02:32 +09:00
llc_core.c	llc: cleanup: remove dead code from llc_init()	2010-03-24 13:34:08 -07:00
llc_if.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	2010-03-30 22:02:32 +09:00
llc_input.c	include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h	2010-03-30 22:02:32 +09:00
llc_output.c	llc: use dev_hard_header	2009-12-26 20:38:23 -08:00
llc_pdu.c	[LLC]: skb allocation size for responses	2008-03-31 21:02:47 -07:00
llc_proc.c	llc: convert llc_sap_list to RCU	2009-12-26 20:46:28 -08:00
llc_s_ac.c	[LLC]: skb allocation size for responses	2008-03-31 21:02:47 -07:00
llc_s_ev.c
llc_s_st.c
llc_sap.c	net: Fix FDDI and TR config checks in ipv4 arp and LLC.	2010-05-10 04:59:07 -07:00
llc_station.c	net/llc: storing negative error codes in unsigned short	2010-09-16 22:38:23 -07:00
Makefile
sysctl_net_llc.c	sysctl net: Remove unused binary sysctl code	2009-11-12 02:05:06 -08:00