Stefan Berger 95f567f81e fs: Simplify getattr interface function checking AT_GETATTR_NOSEC flag ... Commit 8a924db2d7 ("fs: Pass AT_GETATTR_NOSEC flag to getattr interface function")' introduced the AT_GETATTR_NOSEC flag to ensure that the call paths only call vfs_getattr_nosec if it is set instead of vfs_getattr. Now, simplify the getattr interface functions of filesystems where the flag AT_GETATTR_NOSEC is checked. There is only a single caller of inode_operations getattr function and it is located in fs/stat.c in vfs_getattr_nosec. The caller there is the only one from which the AT_GETATTR_NOSEC flag is passed from. Two filesystems are checking this flag in .getattr and the flag is always passed to them unconditionally from only vfs_getattr_nosec: - ecryptfs: Simplify by always calling vfs_getattr_nosec in ecryptfs_getattr. From there the flag is passed to no other function and this function is not called otherwise. - overlayfs: Simplify by always calling vfs_getattr_nosec in ovl_getattr. From there the flag is passed to no other function and this function is not called otherwise. The query_flags in vfs_getattr_nosec will mask-out AT_GETATTR_NOSEC from any caller using AT_STATX_SYNC_TYPE as mask so that the flag is not important inside this function. Also, since no filesystem is checking the flag anymore, remove the flag entirely now, including the BUG_ON check that never triggered. The net change of the changes here combined with the original commit is that ecryptfs and overlayfs do not call vfs_getattr but only vfs_getattr_nosec. Fixes: 8a924db2d7 ("fs: Pass AT_GETATTR_NOSEC flag to getattr interface function") Reported-by: Al Viro <viro@zeniv.linux.org.uk> Closes: https://lore.kernel.org/linux-fsdevel/20241101011724.GN1350452@ZenIV/T/#u Cc: Tyler Hicks <code@tyhicks.com> Cc: ecryptfs@vger.kernel.org Cc: Miklos Szeredi <miklos@szeredi.hu> Cc: Amir Goldstein <amir73il@gmail.com> Cc: linux-unionfs@vger.kernel.org Cc: Christian Brauner <brauner@kernel.org> Cc: linux-fsdevel@vger.kernel.org Reviewed-by: Christian Brauner <brauner@kernel.org> Signed-off-by: Stefan Berger <stefanb@linux.ibm.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>		2024-11-13 11:46:29 -05:00
..
copy_up.c	overlayfs updates for 6.12	2024-09-19 06:33:18 +02:00
dir.c	ovl: fix copy-up in tmpfile	2024-05-28 10:06:55 +02:00
export.c	ovl: fix encoding fid for lower only root	2024-06-14 10:30:40 +02:00
file.c	ovl: fix file leak in ovl_real_fdget_meta()	2024-09-27 12:38:47 -07:00
inode.c	fs: Simplify getattr interface function checking AT_GETATTR_NOSEC flag	2024-11-13 11:46:29 -05:00
Kconfig	fs: prepare for stackable filesystems backing file helpers	2023-12-23 16:35:08 +02:00
Makefile	ovl: Move xattr support to new xattrs.c file	2023-10-31 00:12:59 +02:00
namei.c	ovl: mark xwhiteouts directory with overlay.opaque='x'	2024-01-23 12:39:48 +02:00
overlayfs.h	fs: Simplify getattr interface function checking AT_GETATTR_NOSEC flag	2024-11-13 11:46:29 -05:00
ovl_entry.h	ovl: mark xwhiteouts directory with overlay.opaque='x'	2024-01-23 12:39:48 +02:00
params.c	ovl: fail if trusted xattrs are needed but caller lacks permission	2024-09-08 15:36:59 +02:00
params.h	ovl: store and show the user provided lowerdir mount option	2023-10-31 00:13:02 +02:00
readdir.c	ovl: mark xwhiteouts directory with overlay.opaque='x'	2024-01-23 12:39:48 +02:00
super.c	ovl: don't set the superblock's errseq_t manually	2024-08-29 11:35:09 +02:00
util.c	kernel_file_open(): get rid of inode argument	2024-04-15 16:03:24 -04:00
xattrs.c	ovl: Support escaped overlay.* xattrs	2023-10-31 00:12:59 +02:00