linux/fs/afs
Anton Blanchard c017386352 afs: Remote abort can cause BUG in rxrpc code
When writing files to afs I sometimes hit a BUG:

kernel BUG at fs/afs/rxrpc.c:179!

With a backtrace of:

	afs_free_call
	afs_make_call
	afs_fs_store_data
	afs_vnode_store_data
	afs_write_back_from_locked_page
	afs_writepages_region
	afs_writepages

The cause is:

	ASSERT(skb_queue_empty(&call->rx_queue));

Looking at a tcpdump of the session the abort happens because we
are exceeding our disk quota:

	rx abort fs reply store-data error diskquota exceeded (32)

So the abort error is valid. We hit the BUG because we haven't
freed all the resources for the call.

By freeing any skbs in call->rx_queue before calling afs_free_call
we avoid hitting leaking memory and avoid hitting the BUG.

Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: David Howells <dhowells@redhat.com>
Cc: <stable@kernel.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2012-03-16 17:01:41 -07:00
..
afs_cm.h afs: support the CB.ProbeUuid RPC op 2008-04-29 08:06:26 -07:00
afs_fs.h AFS: implement file locking 2007-07-16 09:05:43 -07:00
afs_vl.h AFS: Fix silly characters in a comment 2011-07-20 20:48:03 -04:00
afs.h AFS: implement file locking 2007-07-16 09:05:43 -07:00
cache.c Fix common misspellings 2011-03-31 11:26:23 -03:00
callback.c Fix various old email addresses for dwmw2 2008-06-06 11:29:10 -07:00
cell.c Fix common misspellings 2011-03-31 11:26:23 -03:00
cmservice.c afs: add afs_wq and use it instead of the system workqueue 2011-01-14 09:25:11 -08:00
dir.c switch ->create() to umode_t 2012-01-03 22:54:53 -05:00
file.c AFS: Don't put struct file on the stack 2010-05-21 18:31:28 -04:00
flock.c fs/locks.c: prepare for BKL removal 2010-10-05 11:02:04 +02:00
fsclient.c filesystems: add set_nlink() 2011-11-02 12:53:43 +01:00
inode.c filesystems: add set_nlink() 2011-11-02 12:53:43 +01:00
internal.h afs: Read of file returns EBADMSG 2012-03-16 17:01:41 -07:00
Kconfig DNS: Make AFS go to the DNS for AFSDB records for unknown cells 2010-08-05 17:17:51 +00:00
main.c afs: add afs_wq and use it instead of the system workqueue 2011-01-14 09:25:11 -08:00
Makefile FS-Cache: Make kAFS use FS-Cache 2009-04-03 16:42:41 +01:00
misc.c AFS: Correctly translate auth error aborts and don't failover in such cases 2009-06-16 21:20:14 -07:00
mntpt.c vfs: kill ->mnt_devname use in afs printks 2012-01-03 22:52:38 -05:00
netdevices.c afs: BUG to BUG_ON changes 2009-04-09 10:41:19 -07:00
proc.c AFS: Implement an autocell mount capability [ver #2] 2010-08-11 17:11:29 +00:00
rxrpc.c afs: Remote abort can cause BUG in rxrpc code 2012-03-16 17:01:41 -07:00
security.c ->permission() sanitizing: don't pass flags to ->permission() 2011-07-20 01:43:24 -04:00
server.c afs: add afs_wq and use it instead of the system workqueue 2011-01-14 09:25:11 -08:00
super.c vfs: fix the stupidity with i_dentry in inode destructors 2012-01-03 22:52:40 -05:00
vlclient.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h 2010-03-30 22:02:32 +09:00
vlocation.c afs: add afs_wq and use it instead of the system workqueue 2011-01-14 09:25:11 -08:00
vnode.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h 2010-03-30 22:02:32 +09:00
volume.c afs: add bdi backing to mount session. 2010-04-22 11:58:18 +02:00
write.c fs: push i_mutex and filemap_write_and_wait down into ->fsync() handlers 2011-07-20 20:47:59 -04:00