Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-27 13:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity
699ad73456
linux/include/soc
History
Geert Uytterhoeven 144345a4a8 soc: bcm2835: Make !RASPBERRYPI_FIRMWARE dummies return failure 
If CONFIG_RASPBERRYPI_FIRMWARE=n:

    drivers/gpio/gpio-raspberrypi-exp.c: In function ‘rpi_exp_gpio_get_polarity’:
    drivers/gpio/gpio-raspberrypi-exp.c:71: warning: ‘get.polarity’ is used uninitialized in this function
    drivers/gpio/gpio-raspberrypi-exp.c: In function ‘rpi_exp_gpio_get_direction’:
    drivers/gpio/gpio-raspberrypi-exp.c:150: warning: ‘get.direction’ is used uninitialized in this function

The dummy firmware interface functions return 0, which means success,
causing subsequent code to make use of the never initialized output
parameter.

Fix this by making the dummy functions return an error code (-ENOSYS)
instead.

Note that this assumes the firmware always fills in the requested data
in the CONFIG_RASPBERRYPI_FIRMWARE=y case.

Fixes: d45f1a563b ("staging: vc04_services: fix up rpi firmware functions")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
2018-04-16 15:15:23 -07:00
..
arc ARC: mcip: update MCIP debug mask when the new cpu came online 2018-02-28 10:45:31 -08:00
at91 clk: at91: utmi: set the mainck rate 2017-11-01 23:39:49 -07:00
bcm2835 soc: bcm2835: Make !RASPBERRYPI_FIRMWARE dummies return failure 2018-04-16 15:15:23 -07:00
brcmstb
fsl net/wan/fsl_ucc_hdlc: add hdlc-bus support 2017-05-18 10:28:39 -04:00
imx
mediatek iommu/mediatek: Add mt2712 IOMMU support 2017-08-22 16:37:58 +02:00
nps soc: Support for NPS HW scheduling 2016-11-30 11:54:25 -08:00
rockchip soc: rockchip: add header for ddr rate SIP interface 2016-08-31 18:53:24 +02:00
sa1100
tegra firmware: tegra: Simplify channel management 2018-03-08 14:20:58 +01:00