mirror of
https://github.com/torvalds/linux.git
synced 2024-12-04 18:13:04 +00:00
0254f31a7d
The transaction buffer is allocated by using the size of the packet buf,
and subtracting two which seems intended to remove the two tags which are
not present in the target structure. This calculation leads to under
counting memory because of differences between the packet contents and the
target structure. The aid_len field is a u8 in the packet, but a u32 in
the structure, resulting in at least 3 bytes always being under counted.
Further, the aid data is a variable length field in the packet, but fixed
in the structure, so if this field is less than the max, the difference is
added to the under counting.
To fix, perform validation checks progressively to safely reach the
next field, to determine the size of both buffers and verify both tags.
Once all validation checks pass, allocate the buffer and copy the data.
This eliminates freeing memory on the error path, as validation checks are
moved ahead of memory allocation.
Reported-by: Denis Efremov <denis.e.efremov@oracle.com>
Reviewed-by: Guenter Roeck <groeck@google.com>
Fixes:
|
||
|---|---|---|
| .. | ||
| core.c | ||
| i2c.c | ||
| Kconfig | ||
| Makefile | ||
| ndlc.c | ||
| ndlc.h | ||
| se.c | ||
| spi.c | ||
| st-nci.h | ||
| vendor_cmds.c | ||